[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

2023-09-05 Thread via GitHub
dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1316210535 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1491,10 +1526,15 @@ public void testConsumerGroupOffsetFetch

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

2023-09-04 Thread via GitHub
dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314671160 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -631,4 +631,33 @@ public void testValidateOffsetCommit() {

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

2023-09-04 Thread via GitHub
dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r131483 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -631,4 +631,33 @@ public void testValidateOffsetCommit() {

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

2023-09-04 Thread via GitHub
dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314665557 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -181,10 +181,28 @@ public List fetchOffsets( Str

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

2023-09-04 Thread via GitHub
dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314664510 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -181,10 +181,28 @@ public List fetchOffsets( Str

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

2023-09-04 Thread via GitHub
dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314663349 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -823,9 +823,17 @@ public void validateOffsetCommit( /**

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

2023-09-04 Thread via GitHub
dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314661887 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1409,6 +1444,82 @@ public void testFetchAllOffsetsAtDifferen

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

2023-09-04 Thread via GitHub
dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314590003 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -538,17 +537,46 @@ public void validateOffsetCommit( if