[GitHub] [kafka] divijvaidya commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-08-02 Thread via GitHub
divijvaidya commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1281717116 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-08-02 Thread via GitHub
divijvaidya commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1281624661 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-08-01 Thread via GitHub
divijvaidya commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1280353910 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -122,6 +122,18 @@ public final class RemoteLogManagerConfig {