[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…

2021-06-23 Thread GitBox
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-867277063 @bbejeck Failed test also appear in other issues. I think it's unrelated. ``` org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2,

[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…

2021-06-23 Thread GitBox
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-867105129 @bbejeck Thanks for the review. You are right Please help me review again. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…

2021-04-08 Thread GitBox
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-815594893 @bbejeck Thanks for your response !! I see the compatibility claim in NamedInternal. ``` String orElseGenerateWithPrefix(final InternalNameProvider provider,

[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…

2021-02-23 Thread GitBox
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-784072487 @mjsax Hello~ Can you help me to take a look? This is an automated message from the Apache Git Service.