[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-25 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494480847 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1764,6 +1769,145 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-24 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494660983 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1366,6 +1366,12 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-24 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494480847 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1764,6 +1769,145 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490530496 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1763,6 +1768,143 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490527627 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1246,6 +1364,50 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-17 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r490464756 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -157,6 +158,44 @@ case class OngoingReassignmentState(addingReplicas: Seq[Int],

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-16 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r489569400 ## File path: clients/src/main/resources/common/message/AlterIsrRequest.json ## @@ -0,0 +1,44 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-26 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r477618083 ## File path: clients/src/main/resources/common/message/AlterIsrResponse.json ## @@ -0,0 +1,38 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-12 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r469388095 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -748,7 +755,7 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-03 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464718819 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-03 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464705276 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2956,6 +2956,22 @@ class KafkaApis(val requestChannel: RequestChannel, } }