ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1127463069
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1126571253
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -497,51 +501,59 @@ object RequestMetrics {
val ErrorsPerSec = "ErrorsPerSec"
}
-class RequestMetri
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1126570518
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1121367465
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1120551247
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -497,51 +501,59 @@ object RequestMetrics {
val ErrorsPerSec = "ErrorsPerSec"
}
-class RequestMetri
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1116207172
##
core/src/main/scala/kafka/server/DelayedDeleteRecords.scala:
##
@@ -122,12 +121,12 @@ class DelayedDeleteRecords(delayMs: Long,
}
}
-object DelayedDeleteRecords
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1116206680
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -247,10 +248,19 @@ class UnifiedLog(@volatile var logStartOffset: Long,
@volatile private var
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1116205167
##
core/src/main/scala/kafka/log/LogSegment.scala:
##
@@ -689,6 +689,7 @@ object LogSegment {
}
}
-object LogFlushStats extends KafkaMetricsGroup {
- val logFlush
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1072224151
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1072223766
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1072223447
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -293,14 +295,14 @@ class Partition(val topicPartition: TopicPartition,
private var controllerEpoch: Int =
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1070962067
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1070539477
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -70,7 +70,9 @@ class DelayedOperations(topicPartition: TopicPartition,
def numDelayedDelete: Int = deleteR
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1070536098
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1069827409
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -42,7 +43,7 @@ class BrokerMetadataListener(
val snapshotter: Option[MetadataSnapshot
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1069826661
##
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala:
##
@@ -34,7 +33,7 @@ import scala.jdk.CollectionConverters._
/**
* This is an integration test
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1069825536
##
core/src/main/scala/kafka/log/remote/RemoteLogManager.scala:
##
@@ -48,7 +47,7 @@ import scala.jdk.CollectionConverters._
*/
class RemoteLogManager(rlmConfig: Remo
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1061663838
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
18 matches
Mail list logo
