[GitHub] [kafka] jolshan commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

jolshan commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1318833581 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -5633,20 +5643,39 @@ public void testListOffsetsMetadataNonRetriableErrors()

[GitHub] [kafka] jolshan commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

jolshan commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1316539813 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java: ## @@ -72,6 +79,12 @@ private void handleTopicError( ) {

[GitHub] [kafka] jolshan commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

jolshan commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1316416748 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -5634,16 +5637,31 @@ public void testListOffsetsMetadataNonRetriableErrors()

[GitHub] [kafka] jolshan commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

jolshan commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1316414818 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java: ## @@ -72,6 +79,12 @@ private void handleTopicError( ) {