[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r661843738 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 6

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r661843521 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -687,15 +697,8 @@ public void handleSnapshot(SnapshotReader

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r661843371 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -877,6 +880,39 @@ private void replay(ApiMessage message, O

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r661835072 ## File path: raft/src/main/java/org/apache/kafka/raft/Batch.java ## @@ -105,9 +117,10 @@ public int hashCode() { * @param baseOffset offset of the

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091562 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -367,6 +435,36 @@ private void checkSnapshotContents(

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091527 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -282,7 +285,71 @@ public void testSnapshotSaveAndLoad()

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091491 ## File path: metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java ## @@ -269,7 +269,10 @@ public void testSnapshotSaveAndLoad()

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091444 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -374,6 +375,7 @@ object KafkaConfig { val BrokerSessionTimeoutMsProp = "broker.s

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r659091359 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 6

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r658353741 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1049,6 +1052,7 @@ object KafkaConfig { .defineInternal(BrokerHeartbeatInter

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r658352517 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1049,6 +1052,7 @@ object KafkaConfig { .defineInternal(BrokerHeartbeatInter

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r656483156 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1049,6 +1052,7 @@ object KafkaConfig { .defineInternal(BrokerHeartbeatInter

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r655732329 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 6

[GitHub] [kafka] jsancio commented on a change in pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio commented on a change in pull request #10812: URL: https://github.com/apache/kafka/pull/10812#discussion_r655732329 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -74,6 +74,7 @@ object Defaults { val InitialBrokerRegistrationTimeoutMs = 6