lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1717579385
There were 6 unrelated test failures in the last build:
Build / JDK 20 and Scala 2.13 / testTaskRequestWithOldStartMsGetsUpdated() –
org.apache.kafka.trogdor.coordinator.Coordinator
lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1716175625
All comments addressed @junrao , thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1715682457
There were 7 unrelated test failures:
Build / JDK 17 and Scala 2.13 /
testCreateTokenForOtherUserFails(String).quorum=kraft –
kafka.api.DelegationTokenEndToEndAuthorizationWithOwne
lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1714883627
Unit tests added for the validate positions, it was definitely missing.
Also minor fix for a param that ended up wrong in the last merge with the
exponential backoff change. Update
lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1714633959
Thanks for the review @junrao . All comments addressed, only pending is
adding more unit tests for the validatePositions. I'm adding them and will
update shortly
--
This is an automate
lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1712218811
Thanks for review @junrao ! All comments addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1711652623
Thanks @philipnee! I had missed the reset func when renaming, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1710762508
Thanks a lot @philipnee for the review, all comments addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
lianetm commented on PR #14346:
URL: https://github.com/apache/kafka/pull/14346#issuecomment-1710621218
Build completed with 6 unrelated test failures:
Build / JDK 20 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow()
–
org.apache.kafka.connect.mirror.integration.MirrorCon
