[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r607979819 ## File path: docs/upgrade.html ## @@ -37,6 +37,8 @@ Notable changes in 3 The deprecated kafka-preferred-replica-election command line tool was

[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r591997331 ## File path: build.gradle ## @@ -1416,14 +1416,6 @@ project(':streams') { dependencies { api project(':clients') -// use `api` dependency

[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586900476 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586863239 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586863239 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586711923 ## File path: build.gradle ## @@ -974,8 +974,8 @@ project(':core') { from(project(':streams:streams-scala').configurations.runtime) { into("libs/") }

[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586652341 ## File path: streams-examples/.gitignore ## @@ -0,0 +1 @@ +/bin/ Review comment: Just curious. Why do we need this?

[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r586651685 ## File path: build.gradle ## @@ -1528,8 +1523,7 @@ project(':streams') { ':streams:upgrade-system-tests-24:test',