[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-08-04 Thread GitBox
mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-668826609 @abbccdda I updated the PR. I also realized, that it might be better to throw a `TimeoutException` instead of a `TaskAssignmentException` if we hit the new timeout. Updated the

[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-08-03 Thread GitBox
mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-668357683 Updated. Call for review @abbccdda > Also, do we have new unit test coverage for the changes? We did not really change much, only switching from `retries` to a

[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-663135369 Jenkins failed on know flaky tests only. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-663134416 Only the `StreamsStandbyTask.test_standby_tasks_rebalance` system test failed and it's know to be buggy. This is

[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-22 Thread GitBox
mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-662818424 Triggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4070/ This is an