[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1177944732 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java: ## @@ -115,6 +115,9 @@ private void publishDelta(MetadataDelta del

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1176597177 ## core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala: ## @@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest { } @ClusterTest(clust

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1175698954 ## core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala: ## @@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest { } @ClusterTest(clust

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1173127962 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -324,4 +329,29 @@ class ZkMigrationIntegrationTest { assertTrue(firstProducerI

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1173116859 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1123,29 +1165,104 @@ private void claim(int epoch) { // Prepend the acti

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1173116859 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1123,29 +1165,104 @@ private void claim(int epoch) { // Prepend the acti

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1173109856 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -222,7 +245,7 @@ private boolean isValidStateChange(MigrationDriverState

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1172621439 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java: ## @@ -115,6 +115,9 @@ private void publishDelta(MetadataDelta del

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1165614955 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1142,9 +1190,20 @@ public ControllerResult generateRecordsAndResult() throws Excepti

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1165588383 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -108,6 +112,12 @@ public Integer value() { return me

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1150733624 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -869,19 +906,30 @@ public CompletableFuture acceptBatch(List recordBatch)