niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r892884885
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4321,6 +4328,88 @@ void handleFailure(Throwable throwable) {
return new
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r891554323
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4337,25 +4337,22 @@ public DescribeMetadataQuorumResult
describeMetadataQuorum(
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r891518982
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4321,6 +4328,94 @@ void handleFailure(Throwable throwable) {
return new
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r891518561
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4321,6 +4328,94 @@ void handleFailure(Throwable throwable) {
return new
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r890414480
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r889238615
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -4833,6 +4879,92 @@ public void testDescribeFeaturesFailure() {
}
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r889220152
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4321,6 +4328,91 @@ void handleFailure(Throwable throwable) {
return new
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r882205666
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r882249160
##
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##
@@ -1446,6 +1446,35 @@ default DescribeFeaturesResult describeFeatures() {
*/
Update
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r882205666
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r882204566
##
core/src/test/scala/unit/kafka/server/DescribeQuorumIntegrationTest.scala:
##
@@ -26,16 +25,17 @@ import org.apache.kafka.common.protocol.{ApiKeys, Errors}
import
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r882104924
##
core/src/test/scala/unit/kafka/server/DescribeQuorumIntegrationTest.scala:
##
@@ -17,25 +17,30 @@
package kafka.server
import java.io.IOException
-
import kaf
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r882012798
##
core/src/test/scala/unit/kafka/server/DescribeQuorumIntegrationTest.scala:
##
@@ -80,6 +85,36 @@ class DescribeQuorumRequestTest(cluster: ClusterInstance) {
a
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r882011850
##
core/src/test/scala/unit/kafka/server/DescribeQuorumIntegrationTest.scala:
##
@@ -17,25 +17,30 @@
package kafka.server
import java.io.IOException
-
import kaf
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r881044944
##
raft/src/main/java/org/apache/kafka/raft/RaftConfig.java:
##
@@ -256,6 +256,21 @@ public static List
voterConnectionsToNodes(Map nodes) {
Review Comment:
It w
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r881044720
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -318,6 +325,11 @@ public class KafkaAdminClient extends AdminClient {
privat
niket-goel commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r881043900
##
clients/src/main/java/org/apache/kafka/common/utils/QuorumInfo.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
17 matches
Mail list logo