[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156483833 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -2484,6 +2511,48 @@ public void shouldUpdateOffsetIfCorruptedRecordF

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156483107 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -44,6 +44,7 @@ import org.apache.kafka.common.utils.MockTime; impor

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156197845 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -2484,6 +2505,34 @@ public void shouldUpdateOffsetIfCorruptedRecordF

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156196422 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1692,43 +1699,45 @@ public void shouldReturnOffsetsForRepartitionTo

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156165447 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1692,43 +1699,45 @@ public void shouldReturnOffsetsForRepartitionTo

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156164789 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -255,6 +255,9 @@ public void completeRestoration(final java.util.functio

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1149285314 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1699,7 +1705,8 @@ public void shouldReturnOffsetsForRepartitionTopi