[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-12 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r895290288 ## build.gradle: ## @@ -1243,7 +1243,7 @@ project(':clients') { testImplementation libs.bcpkix testImplementation libs.junitJupiter -testImplementation

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-10 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r894213689 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -673,30 +673,26 @@ private long

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-03 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r27862 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -679,10 +679,11 @@ private long

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-02 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r887814333 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -679,10 +679,11 @@ private long

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-02 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r887787750 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -679,10 +679,11 @@ private long

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-06-02 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r887769458 ## build.gradle: ## @@ -1243,7 +1243,7 @@ project(':clients') { testImplementation libs.bcpkix testImplementation libs.junitJupiter -testImplementation

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-05-31 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r886343646 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -679,10 +679,11 @@ private long

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-05-25 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r881686465 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -681,8 +681,8 @@ else if (connectionsMaxReauthMs == null)

[GitHub] [kafka] showuon commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-05-25 Thread GitBox
showuon commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r881686465 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java: ## @@ -681,8 +681,8 @@ else if (connectionsMaxReauthMs == null)