[GitHub] [kafka] showuon commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

2023-04-12 Thread via GitHub
showuon commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1164996982 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws IOExcept

[GitHub] [kafka] showuon commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

2023-04-12 Thread via GitHub
showuon commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1163964084 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws IOExcept

[GitHub] [kafka] showuon commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

2023-04-07 Thread via GitHub
showuon commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1161067012 ## raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java: ## @@ -63,9 +63,12 @@ public KafkaRaftMetrics(Metrics metrics, String metricGrpPrefix, Quo

[GitHub] [kafka] showuon commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

2023-04-07 Thread via GitHub
showuon commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1161067012 ## raft/src/main/java/org/apache/kafka/raft/internals/KafkaRaftMetrics.java: ## @@ -63,9 +63,12 @@ public KafkaRaftMetrics(Metrics metrics, String metricGrpPrefix, Quo

[GitHub] [kafka] showuon commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

2023-04-07 Thread via GitHub
showuon commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1160682237 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws IOExcept