[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-25 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1305605102 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java: ## @@ -153,7 +153,7 @@ private FileBasedRemoteLogMetadat

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-25 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1305605102 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java: ## @@ -153,7 +153,7 @@ private FileBasedRemoteLogMetadat

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-25 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1305302285 ## clients/src/main/java/org/apache/kafka/common/errors/ResourceNotReadyException.java: ## @@ -0,0 +1,14 @@ +package org.apache.kafka.common.errors; + +public class Res

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300830591 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300819413 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300819413 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299492523 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299460688 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299460688 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299460688 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-04 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1284009383 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable, Closea

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-03 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1283916591 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable, Closea

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-03 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1283144899 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable, Closea

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-03 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1282980927 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable, Closea