[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-25 Thread GitBox
tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r658507802 ## File path: clients/src/main/java/org/apache/kafka/common/errors/NoBatchedFindCoordinatorsException.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to

[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-23 Thread GitBox
tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r657570794 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -29,9 +32,9 @@ */

[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-18 Thread GitBox
tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r654335077 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -0,0 +1,156 @@ +/* + *

[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-14 Thread GitBox
tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r649872433 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -858,6 +885,12 @@ public void

[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-09 Thread GitBox
tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648530700 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1305,66 +1305,102 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-07 Thread GitBox
tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r646585310 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -40,7 +43,11 @@ * individual