github-actions[bot] commented on PR #14597:
URL: https://github.com/apache/kafka/pull/14597#issuecomment-1977907333
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
borisssmidtCET commented on PR #14597:
URL: https://github.com/apache/kafka/pull/14597#issuecomment-1840520823
> Thanks for the PR. There are a number of changes in this PR - which ones
actually made a difference to the numbers? Some of them are a bit questionable.
1. The main
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415344533
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -409,9 +411,13 @@ class AclAuthorizer extends Authorizer with Logging {
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415317427
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415349250
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -563,15 +570,20 @@ class AclAuthorizer extends Authorizer with Logging {
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415344533
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -409,9 +411,13 @@ class AclAuthorizer extends Authorizer with Logging {
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415342634
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -331,12 +330,15 @@ class AclAuthorizer extends Authorizer with Logging {
}
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415341068
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415341068
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415317427
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415317427
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415314693
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -53,7 +53,12 @@ public KafkaPrincipal(String principalType, String
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415317427
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415306650
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -68,9 +73,15 @@ public boolean equals(Object o) {
if (this ==
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415314693
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -53,7 +53,12 @@ public KafkaPrincipal(String principalType, String
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415312775
##
clients/src/main/java/org/apache/kafka/common/resource/ResourceType.java:
##
@@ -104,17 +104,18 @@ public static ResourceType fromCode(byte code) {
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415306650
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -68,9 +73,15 @@ public boolean equals(Object o) {
if (this ==
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415306650
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -68,9 +73,15 @@ public boolean equals(Object o) {
if (this ==
ijuma commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1367722984
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -68,9 +73,15 @@ public boolean equals(Object o) {
if (this == o)
ijuma commented on PR #14597:
URL: https://github.com/apache/kafka/pull/14597#issuecomment-1773777853
Thanks for the PR. There are a number of changes in this PR - which ones
actually made a difference to the numbers? Some of them are a bit questionable.
--
This is an automated message
borisssmidtCET opened a new pull request, #14597:
URL: https://github.com/apache/kafka/pull/14597
*More detailed description of your change,
This PR makes the ACL Authorizer significantly faster.
// before
```
Benchmark(aclCount)
21 matches
Mail list logo
