jolshan commented on code in PR #14531:
URL: https://github.com/apache/kafka/pull/14531#discussion_r1447664834
##
clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java:
##
@@ -26,6 +26,15 @@
*/
public interface Partitioner extends Configurable, Closeable {
jolshan commented on PR #14531:
URL: https://github.com/apache/kafka/pull/14531#issuecomment-1885235923
I think this change would require a KIP since it modifies the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
philipnee commented on code in PR #14531:
URL: https://github.com/apache/kafka/pull/14531#discussion_r1446899891
##
clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java:
##
@@ -26,6 +26,15 @@
*/
public interface Partitioner extends Configurable, Closeable
philipnee commented on PR #14531:
URL: https://github.com/apache/kafka/pull/14531#issuecomment-1884215706
@jimbogithub - thanks for the PR, i've got a few questions to clarify:
- `KafkaProducer.partition(...) not throw IllegalArgumentException if the
Partitioner returns
philipnee commented on code in PR #14531:
URL: https://github.com/apache/kafka/pull/14531#discussion_r1446881807
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1368,7 +1368,7 @@ private int partition(ProducerRecord record, byte[]
jimbogithub commented on PR #14531:
URL: https://github.com/apache/kafka/pull/14531#issuecomment-1884148153
This PR is still valid and desired, has no merge conflicts and does build
despite Jenkins protestations. I do not have the ability to add Reviewers.
--
This is an automated
github-actions[bot] commented on PR #14531:
URL: https://github.com/apache/kafka/pull/14531#issuecomment-1884136280
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
jimbogithub commented on PR #14531:
URL: https://github.com/apache/kafka/pull/14531#issuecomment-1758458826
See https://issues.apache.org/jira/browse/KAFKA-14546 for rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jimbogithub opened a new pull request, #14531:
URL: https://github.com/apache/kafka/pull/14531
Allow custom Partitioners to fallback to default partitioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
