nizhikov commented on PR #15387:
URL: https://github.com/apache/kafka/pull/15387#issuecomment-1978412341
@chia7712 Thank you for review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on PR #15387:
URL: https://github.com/apache/kafka/pull/15387#issuecomment-1978406025
@nizhikov thanks for doing this hard job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 merged PR #15387:
URL: https://github.com/apache/kafka/pull/15387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
nizhikov commented on PR #15387:
URL: https://github.com/apache/kafka/pull/15387#issuecomment-1978120545
Hello @chia7712
I checked CI results and failures seems unrelated to changes for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
nizhikov commented on code in PR #15387:
URL: https://github.com/apache/kafka/pull/15387#discussion_r1511880453
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -29,8 +29,8 @@
import org.apache.kafka.common.utils.Utils;
publ
chia7712 commented on code in PR #15387:
URL: https://github.com/apache/kafka/pull/15387#discussion_r1511877196
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -29,8 +29,8 @@
import org.apache.kafka.common.utils.Utils;
publ
nizhikov commented on code in PR #15387:
URL: https://github.com/apache/kafka/pull/15387#discussion_r1511869490
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -29,7 +29,7 @@
import org.apache.kafka.common.utils.Utils;
publ
chia7712 commented on code in PR #15387:
URL: https://github.com/apache/kafka/pull/15387#discussion_r1511863661
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -29,7 +29,7 @@
import org.apache.kafka.common.utils.Utils;
publ
nizhikov commented on code in PR #15387:
URL: https://github.com/apache/kafka/pull/15387#discussion_r1511855485
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -29,7 +29,7 @@
import org.apache.kafka.common.utils.Utils;
publ
chia7712 commented on code in PR #15387:
URL: https://github.com/apache/kafka/pull/15387#discussion_r1511846250
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -29,7 +29,7 @@
import org.apache.kafka.common.utils.Utils;
publ
chia7712 commented on PR #15387:
URL: https://github.com/apache/kafka/pull/15387#issuecomment-1977489464
> ConfigCommand -> DynamicBrokerConfig -> LogCleaner
ummm, I assume that will not be a issue if we get rid of zk after 4.0 :)
--
This is an automated message from the Apache Git
nizhikov commented on PR #15387:
URL: https://github.com/apache/kafka/pull/15387#issuecomment-1977451436
@chia7712
> relation between cleaner configuration and ConfigCommand
`ConfigCommand` -> `DynamicBrokerConfig` -> `LogCleaner`
--
This is an automated message from the Apa
chia7712 commented on PR #15387:
URL: https://github.com/apache/kafka/pull/15387#issuecomment-1977417300
> In order to move ConfigCommand to tools we must move all it's dependencies
which includes KafkaConfig and other core classes to java. This PR moves log
cleaner configuration to Cleaner
nizhikov commented on PR #15387:
URL: https://github.com/apache/kafka/pull/15387#issuecomment-1963486724
Hello @mimaison @ijuma
Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
14 matches
Mail list logo
