nizhikov commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1980426424
@chia7712 Thank you for the review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1980412147
@nizhikov thanks for this refactor. let us deal with next PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 merged PR #15365:
URL: https://github.com/apache/kafka/pull/15365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1980410184
the failed tests pass on my machine.
```sh
./gradlew cleanTest core:test --tests LogDirFailureTest --tests
ReplicaManagerTest --tests TransactionsTest --tests
chia7712 commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1979651000
@nizhikov I feel this PR is ready, and so please check (or list) the failed
tests. If they are unconnected to this PR, I will merge it.
--
This is an automated message from the Apache
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1512610273
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1512609597
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1512597183
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1512598393
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/AuthorizerIntegrationTest.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation
chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1512585166
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/AuthorizerIntegrationTest.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1978121311
Hello @chia7712
I checked CI results and failures seems unrelated to changes for me.
--
This is an automated message from the Apache Git Service.
To respond to the message,
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511850258
##
core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala:
##
@@ -23,15 +23,17 @@ import org.apache.kafka.common.{KafkaException,
chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511828525
##
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##
@@ -72,7 +71,7 @@ import scala.annotation.nowarn
import scala.collection.mutable
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511775382
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511527711
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511507717
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511503172
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511492912
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1511471141
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software
19 matches
Mail list logo
