AyoubOm commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1978135956
> > Another point, I think there are some missing tests in the
foreignkeyjoin package, and problems in naming a test class. For example,
ForeignTableJoinProcessorSupplierTest is not
mjsax commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1977692891
Also, thanks for the PR! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax merged PR #15395:
URL: https://github.com/apache/kafka/pull/15395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1977688896
> Another point, I think there are some missing tests in the foreignkeyjoin
package, and problems in naming a test class. For example,
ForeignTableJoinProcessorSupplierTest is not testing
AyoubOm commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1976087470
> Thanks for the PR! Overall LGTM, but we should add a unit test for the
newly added sensor.
Thanks @mjsax for your review. I added tests of the dropped record sensor (I
believed
AyoubOm commented on PR #15395:
URL: https://github.com/apache/kafka/pull/15395#issuecomment-1963731421
@mjsax Please have a look when you have some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
AyoubOm opened a new pull request, #15395:
URL: https://github.com/apache/kafka/pull/15395
*As described in KAFKA-14747, we are not recording discarded FK join
responses in case of receiving a join response for an old record (whose hash
value has changed in the left table). This PR adds
