Re: [PR] KAFKA-15566: Fix flaky tests in FetchRequestTest.scala in KRaft mode [kafka]

2023-10-19 Thread via GitHub
showuon merged PR #14573: URL: https://github.com/apache/kafka/pull/14573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15566: Fix flaky tests in FetchRequestTest.scala in KRaft mode [kafka]

2023-10-19 Thread via GitHub
showuon commented on PR #14573: URL: https://github.com/apache/kafka/pull/14573#issuecomment-1771954831 Ran 3 times of CI build and no fetchRequestTest failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15566: Fix flaky tests in FetchRequestTest.scala in KRaft mode [kafka]

2023-10-19 Thread via GitHub
showuon commented on PR #14573: URL: https://github.com/apache/kafka/pull/14573#issuecomment-1770924775 > @showuon @dengziming Thanks for approving the PR. I also have identified the root cause of `checkLastFetchedEpochValidation` failure which also needs to call `TestUtils.waitUntilLeaderI

Re: [PR] KAFKA-15566: Fix flaky tests in FetchRequestTest.scala in KRaft mode [kafka]

2023-10-19 Thread via GitHub
tinaselenge commented on PR #14573: URL: https://github.com/apache/kafka/pull/14573#issuecomment-1770870075 @showuon @dengziming Thanks for approving the PR. I also have identified the root cause of `checkLastFetchedEpochValidation` failure which also needs to call `TestUtils.waitUntilLeade

Re: [PR] KAFKA-15566: Fix flaky tests in FetchRequestTest.scala in KRaft mode [kafka]

2023-10-18 Thread via GitHub
showuon commented on PR #14573: URL: https://github.com/apache/kafka/pull/14573#issuecomment-1769750941 @dengziming , do you want to have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-15566: Fix flaky tests in FetchRequestTest.scala in KRaft mode [kafka]

2023-10-18 Thread via GitHub
tinaselenge commented on PR #14573: URL: https://github.com/apache/kafka/pull/14573#issuecomment-1768593969 @showuon thanks for the feedback. I just made an update to use `TestUtils.waitUntilLeaderIsKnown' instead of the sleep function. The tests will now wait for the log to be created on t

[PR] KAFKA-15566: Fix flaky tests in FetchRequestTest.scala in KRaft mode [kafka]

2023-10-18 Thread via GitHub
tinaselenge opened a new pull request, #14573: URL: https://github.com/apache/kafka/pull/14573 - Fixed some of the failing tests in FetchRequestTest. `testFetchWithPartitionsWithIdError` and `testCreateIncrementalFetchWithPartitionsInErrorV12` fail with the following error when en