junrao commented on PR #14465:
URL: https://github.com/apache/kafka/pull/14465#issuecomment-1771843763
@ijuma : Thanks for the comment. Yes, agree that CleanShutdownFileHandler
should be in the storage module.
--
This is an automated message from the Apache Git Service.
To respond to the
CalvinConfluent commented on PR #14465:
URL: https://github.com/apache/kafka/pull/14465#issuecomment-1771750393
@ijuma I will make a PR to move it under the storage.
cc @junrao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1365925380
##
core/src/test/java/kafka/log/CleanShutdownFileHandlerTest.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
ijuma commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1365924863
##
core/src/main/java/kafka/log/CleanShutdownFileHandler.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
junrao merged PR #14465:
URL: https://github.com/apache/kafka/pull/14465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
CalvinConfluent commented on PR #14465:
URL: https://github.com/apache/kafka/pull/14465#issuecomment-1769903140
@junrao Thanks for the review, no relevant tests failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1364872040
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -327,6 +328,10 @@ public ControllerResult
registerBroker(
}
junrao commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1364207786
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -327,6 +328,10 @@ public ControllerResult
registerBroker(
}
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1362968373
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1409,6 +1410,32 @@ class LogManager(logDirs: Seq[File],
None
}
}
+
+ def
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1362968197
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1409,6 +1410,32 @@ class LogManager(logDirs: Seq[File],
None
}
}
+
+ def
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1362967900
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1409,6 +1410,32 @@ class LogManager(logDirs: Seq[File],
None
}
}
+
+ def
junrao commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1362791793
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1409,6 +1410,32 @@ class LogManager(logDirs: Seq[File],
None
}
}
+
+ def
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1361373946
##
core/src/main/java/kafka/log/CleanShutdownFileHandler.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1361372633
##
core/src/main/java/kafka/log/CleanShutdownFileHandler.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1361372153
##
core/src/main/java/kafka/log/CleanShutdownFileHandler.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1361372008
##
core/src/main/java/kafka/log/CleanShutdownFileHandler.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1361371860
##
core/src/main/java/kafka/log/CleanShutdownFileHandler.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1361371469
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -187,6 +187,11 @@ class BrokerLifecycleManager(
*/
private var _channelManager:
junrao commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1361271632
##
core/src/main/java/kafka/log/CleanShutdownFileHandler.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
CalvinConfluent commented on PR #14465:
URL: https://github.com/apache/kafka/pull/14465#issuecomment-1763821572
@junrao Thanks for the suggestions, they are very helpful!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1360170904
##
core/src/test/scala/unit/kafka/log/CleanShutdownFileHandlerTest.scala:
##
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1360170744
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -327,6 +328,10 @@ public ControllerResult
registerBroker(
}
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1360169734
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -206,7 +211,9 @@ class BrokerLifecycleManager(
channelManager:
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1360169536
##
core/src/main/scala/kafka/log/CleanShutdownFileHandler.scala:
##
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1360168951
##
core/src/main/scala/kafka/log/CleanShutdownFileHandler.scala:
##
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
CalvinConfluent commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1360168785
##
core/src/main/scala/kafka/log/CleanShutdownFileHandler.scala:
##
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
junrao commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1358649732
##
core/src/main/scala/kafka/log/CleanShutdownFileHandler.scala:
##
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
27 matches
Mail list logo
