wcarlson5 merged PR #14554:
URL: https://github.com/apache/kafka/pull/14554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apoorvmittal10 commented on PR #14554:
URL: https://github.com/apache/kafka/pull/14554#issuecomment-1771076017
@mjsax Thanks for re-running the jenkins job. I have also replied to all
open comments.
Below are the failure from build which doesn't seems to be related to the
changes in
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1365426257
##
clients/src/main/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsRequest.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1365424708
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6222,4 +6222,62 @@ class KafkaApisTest {
assertEquals(expectedResponse,
mjsax commented on PR #14554:
URL: https://github.com/apache/kafka/pull/14554#issuecomment-1769842128
Triggered a Jenkins re-run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mjsax commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364838008
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6222,4 +6222,62 @@ class KafkaApisTest {
assertEquals(expectedResponse, response.data)
}
+
mjsax commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364836200
##
clients/src/main/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsRequest.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on PR #14554:
URL: https://github.com/apache/kafka/pull/14554#issuecomment-1769500072
@wcarlson5 Thanks for approving. I have check the build and seems it's
broken due to 2 reasons. Can I fix them or else what do you suggest regarding
merge?
```
The
apoorvmittal10 commented on PR #14554:
URL: https://github.com/apache/kafka/pull/14554#issuecomment-1769497837
> Looks good, @apoorvmittal10!
>
> Some minor comments, mostly for my edification.
>
> The tests are a bit anemic. Will they become more "interesting" over time?
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364625811
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364622903
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364622523
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF)
kirktrue commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364309258
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364245593
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF)
hachikuji commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364187482
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) under
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362700550
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6222,4 +6222,62 @@ class KafkaApisTest {
assertEquals(expectedResponse,
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362698415
##
clients/src/test/java/org/apache/kafka/common/requests/PushTelemetryResponseTest.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362698016
##
clients/src/test/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsResponseTest.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362697604
##
clients/src/test/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsResponseTest.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362696790
##
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362690914
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6222,4 +6222,62 @@ class KafkaApisTest {
assertEquals(expectedResponse,
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362679708
##
clients/src/test/java/org/apache/kafka/common/protocol/ProtoUtilsTest.java:
##
@@ -34,6 +34,7 @@ public void testDelayedAllocationSchemaDetection() {
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362670208
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362665976
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362662718
##
clients/src/main/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsRequest.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362658016
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6222,4 +6222,62 @@ class KafkaApisTest {
assertEquals(expectedResponse,
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362652533
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6222,4 +6222,62 @@ class KafkaApisTest {
assertEquals(expectedResponse,
mjsax commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1362568238
##
clients/src/main/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsRequest.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation
apoorvmittal10 commented on PR #14554:
URL: https://github.com/apache/kafka/pull/14554#issuecomment-1766970733
Build reports following failure which seems independent of the PR.
```
Recording test results
[Checks API] No suitable checks publisher found.
--
This is an
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1361190555
##
core/src/main/scala/kafka/network/RequestConvertToJson.scala:
##
@@ -63,6 +63,7 @@ object RequestConvertToJson {
case req: EnvelopeRequest =>
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1361190252
##
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##
@@ -3504,6 +3512,35 @@ private ListTransactionsResponse
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1361189051
##
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##
@@ -113,7 +113,9 @@ public enum ApiKeys {
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1361189484
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF)
AndrewJSchofield commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1361149218
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1360641924
##
checkstyle/suppressions.xml:
##
@@ -63,7 +63,7 @@
files="AbstractResponse.java"/>
+
apoorvmittal10 opened a new pull request, #14554:
URL: https://github.com/apache/kafka/pull/14554
Initial PR for
[KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability)
- [KAFKA-15601](https://issues.apache.org/jira/browse/KAFKA-15601).
36 matches
Mail list logo
