cmccabe merged PR #15118:
URL: https://github.com/apache/kafka/pull/15118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mumrah commented on PR #15118:
URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875988796
All production usages now call `latestProduction` and test usages (including
benchmark classes) call `latestTesting. One exception is is
`QuorumFeatures#defaultFeatureMap(boolean enableUns
cmccabe commented on PR #15118:
URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875906638
Alternately, if we wanted to make this literally impossible to invoke from a
non-test context, we could move `MetadataVersion.latest` into
`MetadataVersionTest.latest`.
The downsid
cmccabe commented on PR #15118:
URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875904378
I agree with @ijuma that just having a boolean isn't very clear.
How about renaming `MetadataVersion.latest()` to
`MetadataVersion.latestTesting()`, and then creating a separate fun
ijuma commented on code in PR #15118:
URL: https://github.com/apache/kafka/pull/15118#discussion_r1440881725
##
core/src/main/java/kafka/server/builders/LogManagerBuilder.java:
##
@@ -48,7 +48,7 @@ public class LogManagerBuilder {
private int maxTransactionTimeoutMs = 15 *
mumrah opened a new pull request, #15118:
URL: https://github.com/apache/kafka/pull/15118
This patch introduces a boolean flag to MetadataVersion#latest which
controls whether or not "unstable" MetadataVersions can be returned. For
testing purposes, we want to be able to automatically pick
