Re: [PR] KAFKA-16082 Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 merged PR #15777: URL: https://github.com/apache/kafka/pull/15777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16082 Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on PR #15777: URL: https://github.com/apache/kafka/pull/15777#issuecomment-2071783047 The failed tests is fixed by https://github.com/chia7712/kafka/commit/6e998cffdd33e343945877ccee1fec8337c7d57d -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] KAFKA-16082 Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on PR #15777: URL: https://github.com/apache/kafka/pull/15777#issuecomment-2070018194 @chia7712 Rebased. PTAL :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] KAFKA-16082 Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on PR #15777: URL: https://github.com/apache/kafka/pull/15777#issuecomment-2070011423 #15776 is merged so please rebase code :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16082 Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on PR #15777: URL: https://github.com/apache/kafka/pull/15777#issuecomment-2068874029 CC: @soarez @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 merged PR #15136: URL: https://github.com/apache/kafka/pull/15136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on PR #15136: URL: https://github.com/apache/kafka/pull/15136#issuecomment-2067228882 the failed `testParseAndValidateAddressesWithReverseLookup` is traced by #15758. will merge it -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1571030504 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1178,6 +1178,33 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1571012160 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,49 +1217,62 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPartitio

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1570959086 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,49 +1217,62 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPar

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1570922398 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,49 +1217,62 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPartitio

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1570920951 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1178,6 +1178,33 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(broke

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1569131419 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,50 +1216,61 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPar

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1570449270 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,50 +1216,63 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPar

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1570449270 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,50 +1216,63 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPar

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1570371982 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1178,6 +1178,33 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1569178614 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,50 +1216,63 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPartitio

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1569131419 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,50 +1216,61 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPar

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1568904632 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1189,50 +1216,61 @@ class LogManager(logDirs: Seq[File], val sourceLog = currentLogs.get(topicPartitio

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1568882032 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1568883111 ## core/src/test/java/kafka/testkit/BrokerNode.java: ## @@ -81,8 +82,7 @@ public BrokerNode build( logDataDirectories = Collections.

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1566938172 ## core/src/test/java/kafka/testkit/BrokerNode.java: ## @@ -81,8 +82,7 @@ public BrokerNode build( logDataDirectories = Collections.

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1565638692 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1565572433 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(broke

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1565571409 ## core/src/test/java/kafka/testkit/BrokerNode.java: ## @@ -81,8 +82,7 @@ public BrokerNode build( logDataDirectories = Collections.

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

chia7712 commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1565569471 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(broke

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

showuon commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1562307197 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(broker

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

showuon commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1562284319 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(broker

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

showuon commented on PR #15136: URL: https://github.com/apache/kafka/pull/15136#issuecomment-2047306952 Will check it again within this week. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

soarez commented on PR #15136: URL: https://github.com/apache/kafka/pull/15136#issuecomment-2046971782 @showuon PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

soarez commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1557442275 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -1437,7 +1438,9 @@ class KRaftClusterTest { assertEquals(Set(1, 2), info.get.isr

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1551349514 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

soarez commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1549709937 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(brokerI

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1549695928 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

showuon commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1544295936 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File], } } + def recoverAbandonedFutureLogs(broker

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

soarez commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1511125756 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2790,7 +2791,6 @@ class ReplicaManager(val config: KafkaConfig, // is unavailable. This is

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

soarez commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r1509052378 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2859,10 +2867,10 @@ class ReplicaManager(val config: KafkaConfig, "local leaders.") replicaF

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

OmniaGM commented on PR #15136: URL: https://github.com/apache/kafka/pull/15136#issuecomment-1914798524 Hi, @rondagostino, @showuon and @cmccabe can one of you have a look into this pr please and merge it if you are happy with the changes? -- This is an automated message from the Apache

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r169837 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2773,6 +2776,12 @@ class ReplicaManager(val config: KafkaConfig, Some(partition, false)

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r169837 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2773,6 +2776,12 @@ class ReplicaManager(val config: KafkaConfig, Some(partition, false)

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

OmniaGM commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r157092 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -5592,6 +5592,63 @@ class ReplicaManagerTest { } } + @ParameterizedTest + @ValueSou

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

OmniaGM commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r142323 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1156,6 +1156,32 @@ class LogManager(logDirs: Seq[File], } } + def maybeRecoverAbandonedFutureLog(to

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

OmniaGM commented on code in PR #15136: URL: https://github.com/apache/kafka/pull/15136#discussion_r142323 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1156,6 +1156,32 @@ class LogManager(logDirs: Seq[File], } } + def maybeRecoverAbandonedFutureLog(to

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

gaurav-narula commented on PR #15136: URL: https://github.com/apache/kafka/pull/15136#issuecomment-1878536740 CC: @OmniaGM @pprovenzano -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif