showuon commented on PR #15133:
URL: https://github.com/apache/kafka/pull/15133#issuecomment-1878558194
> Should we write a test that could have caught this?
Will do! Just want to make sure the solution makes sense.
--
This is an automated message from the Apache Git Service.
To res
showuon commented on PR #15133:
URL: https://github.com/apache/kafka/pull/15133#issuecomment-1878302828
@clolov @satishd @kamalcph , do you think this fix makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
showuon commented on code in PR #15133:
URL: https://github.com/apache/kafka/pull/15133#discussion_r1442611638
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -529,18 +534,28 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Ka
showuon opened a new pull request, #15133:
URL: https://github.com/apache/kafka/pull/15133
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
