Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 merged PR #15154: URL: https://github.com/apache/kafka/pull/15154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on PR #15154: URL: https://github.com/apache/kafka/pull/15154#issuecomment-1899225769 Test failures appear unrelated, and connect:runtime passes for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1457585290 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -392,90 +397,29 @@ public void testSetConfigs() {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1457583523 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrorHandlingIntegrationTest.java: ## @@ -75,9 +77,9 @@ public class ErrorHandlingIntegrationTest

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450941019 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -392,90 +397,29 @@ public void testSetConfigs()

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450933080 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -392,90 +397,29 @@ public void testSetConfigs() {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450932511 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ## @@ -54,7 +65,16 @@ public void put(Collection records) {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450911725 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrorHandlingIntegrationTest.java: ## @@ -75,9 +77,9 @@ public class ErrorHandlingIntegrationT

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450908695 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -392,90 +397,29 @@ public void testSetConfigs()

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450907710 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ## @@ -54,7 +65,16 @@ public void put(Collection records) {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450900313 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ## @@ -44,6 +49,12 @@ public ErrantRecordSinkTask() {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450850940 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ## @@ -44,6 +49,12 @@ public ErrantRecordSinkTask() { pu

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450846319 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -236,7 +237,7 @@ protected V execAndHandleError(Operat

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450843684 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/DeadLetterQueueReporter.java: ## @@ -121,20 +121,22 @@ public static DeadLetterQueueReporter

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450843020 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java: ## @@ -17,82 +17,36 @@ package org.apache.kafka.connect.runtime.error

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450812678 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -80,59 +83,57 @@ public class RetryWithToleranceOperato

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449513344 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java: ## @@ -168,11 +102,13 @@ public String toString(boolean includeMess

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449513344 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java: ## @@ -168,11 +102,13 @@ public String toString(boolean includeMess

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449403859 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -303,48 +303,14 @@ public String toString() {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449403859 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -303,48 +303,14 @@ public String toString() {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449351768 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/DeadLetterQueueReporter.java: ## @@ -121,20 +121,22 @@ public static DeadLetterQueueReporte

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449349792 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/DeadLetterQueueReporter.java: ## @@ -121,20 +121,22 @@ public static DeadLetterQueueReporte

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449347346 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -236,7 +237,7 @@ protected V execAndHandleError(Ope

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449326220 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -80,59 +83,57 @@ public class RetryWithToleranceOper

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449313479 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java: ## @@ -17,82 +17,36 @@ package org.apache.kafka.connect.runtime.er

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449271258 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -143,7 +144,7 @@ public synchronized Future executeFail

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449180005 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -80,59 +83,57 @@ public class RetryWithToleranceOperato

[PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

gharris1727 opened a new pull request, #15154: URL: https://github.com/apache/kafka/pull/15154 The single ProcessingContext in the RetryWithToleranceOperator is subject to a data race when interacted with across multiple threads. Specifically, when the main task thread is converting records