ijuma commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1489643087
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
showuon merged PR #15263:
URL: https://github.com/apache/kafka/pull/15263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15263:
URL: https://github.com/apache/kafka/pull/15263#issuecomment-1925168574
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gaurav-narula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1473758133
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4912,7 +4919,9 @@ class ReplicaManagerTest {
assertTrue(fooPart eq fooPart2)
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1473746536
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4912,7 +4919,9 @@ class ReplicaManagerTest {
assertTrue(fooPart eq fooPart2)
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1473115063
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2759,11 +2761,20 @@ class ReplicaManager(val config: KafkaConfig,
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1472753854
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1471733042
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1471075201
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2759,11 +2761,20 @@ class ReplicaManager(val config: KafkaConfig,
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1470869032
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2759,11 +2761,20 @@ class ReplicaManager(val config: KafkaConfig,
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1470669307
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2759,11 +2761,20 @@ class ReplicaManager(val config: KafkaConfig,
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1470557475
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1470001208
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469993396
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469986094
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469696139
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469691076
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -183,7 +183,7 @@ object HostedPartition {
/**
* This broker hosts the partition, but it is in an
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469680659
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
OmniaGM commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1469680659
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
gaurav-narula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1467590251
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1467584667
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1466580289
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition,
private def
gaurav-narula commented on PR #15263:
URL: https://github.com/apache/kafka/pull/15263#issuecomment-1910373586
CC: @OmniaGM @cmccabe @pprovenzano @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gaurav-narula opened a new pull request, #15263:
URL: https://github.com/apache/kafka/pull/15263
In Kraft mode, the broker fails to handle topic recreation correctly with
broken disks. This is because `ReplicaManager` tracks HostedPartitions which
are on an offline disk but it doesn't
24 matches
Mail list logo
