Re: [PR] KAFKA-16166: Generify RetryWithToleranceOperator and ErrorReporter classes [kafka]

2024-01-22 Thread via GitHub
gharris1727 merged PR #15233: URL: https://github.com/apache/kafka/pull/15233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16166: Generify RetryWithToleranceOperator and ErrorReporter classes [kafka]

2024-01-22 Thread via GitHub
gharris1727 commented on PR #15233: URL: https://github.com/apache/kafka/pull/15233#issuecomment-1905100656 Test failures appear unrelated, and the runtime tests pass for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16166: Generify RetryWithToleranceOperator and ErrorReporter classes [kafka]

2024-01-19 Thread via GitHub
gharris1727 commented on code in PR #15233: URL: https://github.com/apache/kafka/pull/15233#discussion_r1459984454 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java: ## @@ -132,7 +127,6 @@ public void stop() { */ public void cancel() {

Re: [PR] KAFKA-16166: Generify RetryWithToleranceOperator and ErrorReporter classes [kafka]

2024-01-19 Thread via GitHub
C0urante commented on code in PR #15233: URL: https://github.com/apache/kafka/pull/15233#discussion_r1459683206 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java: ## @@ -132,7 +127,6 @@ public void stop() { */ public void cancel() {

[PR] KAFKA-16166: Generify RetryWithToleranceOperator and ErrorReporter classes [kafka]

2024-01-18 Thread via GitHub
gharris1727 opened a new pull request, #15233: URL: https://github.com/apache/kafka/pull/15233 This is a follow-up to #15154 which propagates the generic type for ProcessingContext upward through all its call-sites. I decided to avoid generifying the WorkerTask and instead separate