mimaison merged PR #14206:
URL: https://github.com/apache/kafka/pull/14206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ahuang98 commented on PR #14206:
URL: https://github.com/apache/kafka/pull/14206#issuecomment-2010532534
@mimaison could you help merge this if this looks good to you? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ahuang98 commented on PR #14206:
URL: https://github.com/apache/kafka/pull/14206#issuecomment-1954880081
Thanks @mimaison, looks like this is because I split out the TopicsImageTest
changes into a separate PR. The migration tests depend on the `DELTA1_RECORDS`
defined there so I moved over
mimaison commented on PR #14206:
URL: https://github.com/apache/kafka/pull/14206#issuecomment-1952110096
There's quite a few failures related to ZkMigration in the last CI run:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14206/22/testReport/
--
This is an automated message
ahuang98 commented on PR #14206:
URL: https://github.com/apache/kafka/pull/14206#issuecomment-193746
@mimaison @mumrah I moved unrelated test changes over to
https://github.com/apache/kafka/pull/15373. The latest commit
ahuang98 commented on PR #14206:
URL: https://github.com/apache/kafka/pull/14206#issuecomment-1944388740
@mimaison the PR was originally meant to introduce additional test changes,
I believe @mumrah renamed it after I added the migration fix. I'll move the
tests out and apply your
mimaison commented on code in PR #14206:
URL: https://github.com/apache/kafka/pull/14206#discussion_r1489636848
##
core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala:
##
@@ -226,8 +226,8 @@ class ZkConfigMigrationClient(
val (migrationZkVersion,
ahuang98 commented on PR #14206:
URL: https://github.com/apache/kafka/pull/14206#issuecomment-1942168244
@mimaison tagging you again just in case you have time to take a look
@mumrah I've added the logging change in the meantime - are we okay merging
in the next week if we don't get a
ahuang98 commented on PR #14206:
URL: https://github.com/apache/kafka/pull/14206#issuecomment-1930876640
Is there a downside to having `deleteTopic` in `ZkTopicMigrationClient` not
delete configs? Otherwise changing the logging level seems okay to me.
--
This is an automated message
