cadonna merged PR #15491:
URL: https://github.com/apache/kafka/pull/15491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on code in PR #15491:
URL: https://github.com/apache/kafka/pull/15491#discussion_r1519991935
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -278,32 +278,48 @@ private CompletedFetch handleInitializeSuccess(final
cadonna commented on PR #15491:
URL: https://github.com/apache/kafka/pull/15491#issuecomment-1988816400
> LGTM! I think it's a good solution in the current architecture, though
arguably a bit smelly.
Agree on the arguable smell. The alternative would be to use locks which I
disliked
lucasbru commented on code in PR #15491:
URL: https://github.com/apache/kafka/pull/15491#discussion_r1519911603
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -278,32 +278,48 @@ private CompletedFetch
cadonna commented on code in PR #15491:
URL: https://github.com/apache/kafka/pull/15491#discussion_r1516359058
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -540,6 +540,14 @@ public synchronized FetchPosition
cadonna commented on code in PR #15491:
URL: https://github.com/apache/kafka/pull/15491#discussion_r1516351421
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchCollectorTest.java:
##
@@ -418,14 +648,7 @@ private void buildDependencies() {
}
cadonna opened a new pull request, #15491:
URL: https://github.com/apache/kafka/pull/15491
The AsyncKafkaConsumer might throw an IllegalStateException during the
initialization of a new fetch. The exception is caused by
the partition being unassigned by the background thread before
