dajac merged PR #15546:
URL: https://github.com/apache/kafka/pull/15546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1530443218
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -619,6 +622,22 @@ ConsumerGroup getOrMaybeCreateConsumerGroup(
dongnuo123 commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1530392822
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -598,15 +600,16 @@ public List
describeGroups(
*/
dongnuo123 commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1530392822
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -598,15 +600,16 @@ public List
describeGroups(
*/
dajac commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1529919197
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -598,15 +600,16 @@ public List
describeGroups(
*/
dongnuo123 commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1529010875
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -9298,6 +9298,120 @@ public void
dajac commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1527999364
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1056,7 +1056,12 @@ private
CoordinatorResult consumerGr
dongnuo123 opened a new pull request, #15546:
URL: https://github.com/apache/kafka/pull/15546
This patch enables the empty classic groups to upgrade to classic groups and
empty consumer groups to upgrade to consumer groups.
jira: https://issues.apache.org/jira/browse/KAFKA-16313
