AndrewJSchofield commented on PR #15479:
URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983823759
Thank you @mimaison .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mimaison commented on PR #15479:
URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983790339
Backported to 3.7 and 3.6 too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mimaison merged PR #15479:
URL: https://github.com/apache/kafka/pull/15479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on PR #15479:
URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983744957
Tests failures don't seem related. merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mimaison commented on PR #15479:
URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983510030
I'll wait for the CI to complete before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mimaison commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1515846272
##
clients/src/test/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandlerTest.java:
##
@@ -199,6 +210,54 @@ public void testHandleResponseSanityCheck() {
AndrewJSchofield commented on PR #15479:
URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983013872
@mimaison Please could I have a PR review on this fix to Admin client
DeleteRecords. It's broken from 3.6.0 onwards.
--
This is an automated message from the Apache Git Service
danielgospodinow commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1514907422
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture newFutur
AndrewJSchofield commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1514890396
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture newFutur
danielgospodinow commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1514870475
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture newFutur
AndrewJSchofield commented on PR #15479:
URL: https://github.com/apache/kafka/pull/15479#issuecomment-1980543598
@showuon Would you be able to review this PR please? It's a fix to an
earlier PR which you reviewed, so I think you'll have the context to understand
it.
--
This is an automat
AndrewJSchofield commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1514201905
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture newFutur
kirktrue commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1513571996
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture newFuture(
AndrewJSchofield opened a new pull request, #15479:
URL: https://github.com/apache/kafka/pull/15479
PR https://github.com/apache/kafka/pull/13760 introduced a problem with
KafkaAdmin.deleteRecords. If the request acted on a set of topic-partitions
which spanned multiple leader brokers, the
14 matches
Mail list logo
