cmccabe merged PR #15584:
URL: https://github.com/apache/kafka/pull/15584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe commented on PR #15584:
URL: https://github.com/apache/kafka/pull/15584#issuecomment-2018746846
> I don't think it's a good idea to introduce the new terms mangling &
unmangling when there are already equivalent terms in the codebase –
sanitizing/desanitizing – it makes it unnecessa
cmccabe commented on code in PR #15584:
URL: https://github.com/apache/kafka/pull/15584#discussion_r1538115580
##
core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala:
##
@@ -50,44 +51,54 @@ class ZkConfigMigrationClient(
val adminZkClient = new AdminZkClien
cmccabe commented on code in PR #15584:
URL: https://github.com/apache/kafka/pull/15584#discussion_r1538115580
##
core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala:
##
@@ -50,44 +51,54 @@ class ZkConfigMigrationClient(
val adminZkClient = new AdminZkClien
soarez commented on code in PR #15584:
URL: https://github.com/apache/kafka/pull/15584#discussion_r1537526255
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -324,6 +325,68 @@ class KRaftClusterTest {
}
}
+ def setConsumerByteRate(
+a
cmccabe opened a new pull request, #15584:
URL: https://github.com/apache/kafka/pull/15584
KAFKA-16222 fixed a bug whereby we didn't undo the name mangling used on
client quota entity names stored in ZooKeeper. However, it incorrectly claimed
to fix the handling of default client quota enti