chia7712 merged PR #15885:
URL: https://github.com/apache/kafka/pull/15885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15885:
URL: https://github.com/apache/kafka/pull/15885#issuecomment-2110828020
> looks like we still suffer from thread leaks in CI :( I've rebased from
trunk to trigger CI again
I have noticed that too. so sad :(
--
This is an automated message from the
gaurav-narula commented on PR #15885:
URL: https://github.com/apache/kafka/pull/15885#issuecomment-2110720158
@chia7712 looks like we still suffer from thread leaks in CI :( I've rebased
from trunk to trigger CI again
--
This is an automated message from the Apache Git Service.
To respond
gaurav-narula commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1598806705
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##
@@ -89,14 +90,16 @@ public class TopicBas
chia7712 commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1598474965
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##
@@ -89,14 +90,16 @@ public class TopicBasedRem
gaurav-narula commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1598221923
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -153,6 +173,7 @@ public void run() {
private void pro
gaurav-narula commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1598102664
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -153,6 +173,7 @@ public void run() {
private void pro
kamalcph commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1597914357
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -153,6 +173,7 @@ public void run() {
private void processC
gaurav-narula commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1597672575
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -153,6 +173,7 @@ public void run() {
private void pro
kamalcph commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1597563897
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -153,6 +173,7 @@ public void run() {
private void processC
gaurav-narula commented on PR #15885:
URL: https://github.com/apache/kafka/pull/15885#issuecomment-2106081608
Thanks for the feedback @kamalcph @satishd!
I've modified the tests so that we propagate a `Consumer`
down to `ConsumerTask` and use it only for tests.
This allows us t
satishd commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1595738359
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##
@@ -152,15 +152,17 @@ public void testNewPa
kamalcph commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1595488671
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##
@@ -176,17 +178,18 @@ private void waitUnt
gaurav-narula commented on PR #15885:
URL: https://github.com/apache/kafka/pull/15885#issuecomment-2098848112
CC: @clolov @satishd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
gaurav-narula opened a new pull request, #15885:
URL: https://github.com/apache/kafka/pull/15885
Some tests in TopicBasedRemoteLogMetadataManagerTest flake because
`waitUntilConsumerCatchesUp` may break early before consumer manager has caught
up with all the events.
This PR adds an
15 matches
Mail list logo
