dajac merged PR #16057:
URL: https://github.com/apache/kafka/pull/16057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
jeffkbkim commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1617796172
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -8695,7 +8691,7 @@ public void testLeaveGroupInvalidGroup()
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1617763169
##
checkstyle/suppressions.xml:
##
@@ -347,7 +347,7 @@
+ files="(GroupMetadataManager|GroupMetadataManagerTest).java"/>
Review Comment:
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1617618237
##
checkstyle/suppressions.xml:
##
@@ -347,7 +347,7 @@
+ files="(GroupMetadataManager|GroupMetadataManagerTest).java"/>
Review Comment:
Do we
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1617332456
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -8695,7 +8691,7 @@ public void testLeaveGroupInvalidGroup(
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613991045
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4419,124 @@ private ConsumerGroupMember
validateConsumer
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613943967
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -8695,7 +8691,7 @@ public void testLeaveGroupInvalidGroup() {
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613943409
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4249,13 +4249,7 @@ public CoordinatorResult classicGroupH
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613887650
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4425,128 @@ private ConsumerGroupMember
validateCon
jeffkbkim commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613845801
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -12801,6 +12801,365 @@ public void
testConsumerGroupMember
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613854091
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateConsumer
jeffkbkim commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613835643
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCons
jeffkbkim commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613834993
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCons
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613785754
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateConsumer
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613748822
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCon
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613724622
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCon
jeffkbkim commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613555271
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCons
dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1613089003
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2041,6 +2027,36 @@ private CoordinatorResult
consumerGroupFenceM
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1612296899
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCon
dongnuo123 opened a new pull request, #16057:
URL: https://github.com/apache/kafka/pull/16057
This patch implements the LeaveGroup api to the consumer groups that are in
the mixed mode.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
20 matches
Mail list logo
