Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2024-06-07 Thread via GitHub
mimaison commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-2154623171 Closing this PR since https://github.com/apache/kafka/pull/15516 has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2024-06-07 Thread via GitHub
mimaison closed pull request #10826: KAFKA-7632: Support Compression Level URL: https://github.com/apache/kafka/pull/10826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2024-04-10 Thread via GitHub
mimaison commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-2048127235 I opened https://github.com/apache/kafka/pull/15516 to implement this KIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2024-02-07 Thread via GitHub
ijuma commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850506417 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -188,6 +190,12 @@ public class ProducerConfig extends AbstractConfig {

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2024-02-07 Thread via GitHub
mimaison commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1931723005 I updated the [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Support+Compression+Level) based on [Jun's

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2023-11-08 Thread via GitHub
mimaison commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1801941525 Yes it would be good to get this over the line. @dongjinleekr Do you think you'll have time to update it? or would you need some help? -- This is an automated message from the Apache

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2023-11-06 Thread via GitHub
junrao commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1795952612 One discussion of the PR is around choosing the default value for `compression.level` (https://github.com/apache/kafka/pull/10826#discussion_r917108950). This is tricky since it's

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2023-10-31 Thread via GitHub
ozturkberkay commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1786847820 Hi, I was wondering if this PR would be prioritized in the foreseeable future given there has been a lot of work done already -- This is an automated message from the Apache Git