Re: [PR] MINOR: Small cleanups in Connect [kafka]

2024-01-05 Thread via GitHub
mimaison commented on code in PR #15128: URL: https://github.com/apache/kafka/pull/15128#discussion_r1442689284 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -119,16 +117,16 @@ private boolean isI

Re: [PR] MINOR: Small cleanups in Connect [kafka]

2024-01-05 Thread via GitHub
mimaison merged PR #15128: URL: https://github.com/apache/kafka/pull/15128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Small cleanups in Connect [kafka]

2024-01-04 Thread via GitHub
divijvaidya commented on code in PR #15128: URL: https://github.com/apache/kafka/pull/15128#discussion_r1442237669 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -119,16 +117,16 @@ private boolean

[PR] MINOR: Small cleanups in Connect [kafka]

2024-01-04 Thread via GitHub
mimaison opened a new pull request, #15128: URL: https://github.com/apache/kafka/pull/15128 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr