chia7712 merged PR #19217:
URL: https://github.com/apache/kafka/pull/19217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on PR #19217:
URL: https://github.com/apache/kafka/pull/19217#issuecomment-2732538893
@chia7712 @kirktrue , thanks for review. I addressed all comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
chia7712 commented on PR #19217:
URL: https://github.com/apache/kafka/pull/19217#issuecomment-2731862047
@FrankYang0529 could you please fix the conflicts again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
FrankYang0529 commented on code in PR #19217:
URL: https://github.com/apache/kafka/pull/19217#discussion_r2002207794
##
build.gradle:
##
@@ -1972,6 +1974,11 @@ project(':clients:clients-integration-tests') {
testImplementation libs.slf4jApi
testImplementation project('
m1a2st commented on code in PR #19217:
URL: https://github.com/apache/kafka/pull/19217#discussion_r2001215037
##
build.gradle:
##
@@ -1972,6 +1974,11 @@ project(':clients:clients-integration-tests') {
testImplementation libs.slf4jApi
testImplementation project(':test-c
kirktrue commented on code in PR #19217:
URL: https://github.com/apache/kafka/pull/19217#discussion_r1999895425
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/DescribeAuthorizedOperationsTest.java:
##
@@ -154,7 +147,7 @@ public void
testConsum
chia7712 commented on PR #19217:
URL: https://github.com/apache/kafka/pull/19217#issuecomment-2730214171
@FrankYang0529 please fix the conflicts and move the
RackAwareAutoTopicCreationTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
FrankYang0529 commented on PR #19217:
URL: https://github.com/apache/kafka/pull/19217#issuecomment-2728203773
The `RackAwareAutoTopicCreationTest` will update for
https://github.com/apache/kafka/pull/18801, because it has Scala converter now.
--
This is an automated message from the Apach
chia7712 commented on PR #19217:
URL: https://github.com/apache/kafka/pull/19217#issuecomment-2727552928
`BootstrapControllersIntegrationTest` and `LogManagerIntegrationTest` can
be moved to server module.
--
This is an automated message from the Apache Git Service.
To respond to the mes
chia7712 commented on PR #19217:
URL: https://github.com/apache/kafka/pull/19217#issuecomment-2727549752
@FrankYang0529 Could you please move `RackAwareAutoTopicCreationTest` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
10 matches
Mail list logo
