[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-23 Thread GitBox
vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-618768435 Also, kicked off https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3915/ This is an automated

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-23 Thread GitBox
ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414227525 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-04-23 Thread GitBox
ConcurrencyPractitioner commented on pull request #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-618768078 Reported in JIRA here: https://issues.apache.org/jira/browse/INFRA-20182 This is an automated

[GitHub] [kafka] lbradstreet commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r414250681 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types,

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-23 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414193901 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/PriorTaskAssignor.java ## @@ -0,0 +1,40 @@ +/* + * Licensed

[jira] [Commented] (KAFKA-9913) TopologyDescription should expose all topic name progrematically

2020-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091168#comment-17091168 ] Guozhang Wang commented on KAFKA-9913: -- [~mjsax] I will incorporate this ticket as part of

[GitHub] [kafka] lbradstreet commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414190233 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-04-23 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r414247204 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java ## @@ -148,6 +161,82 @@ public void

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-23 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414251894 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -1,349 +0,0 @@ -/* - * Licensed to the Apache

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-23 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414195680 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -515,84 +520,114 @@ public void

[GitHub] [kafka] ableegoldman commented on pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-04-23 Thread GitBox
ableegoldman commented on pull request #8248: URL: https://github.com/apache/kafka/pull/8248#issuecomment-618726059 Finally ready for review @vvcephei @cadonna @guozhangwang This is an automated message from the Apache Git

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-23 Thread GitBox
ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414201107 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -161,6 +165,9 @@ public void before() throws Exception {

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-23 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-618729924 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] steverod opened a new pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-23 Thread GitBox
steverod opened a new pull request #8543: URL: https://github.com/apache/kafka/pull/8543 …ng. (#8469) In KAFKA-9826, a log whose first dirty offset was past the start of the active segment and past the last cleaned point resulted in an endless cycle of picking the segment to clean

[GitHub] [kafka] steverod opened a new pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-23 Thread GitBox
steverod opened a new pull request #8542: URL: https://github.com/apache/kafka/pull/8542 …ng. (#8469) In KAFKA-9826, a log whose first dirty offset was past the start of the active segment and past the last cleaned point resulted in an endless cycle of picking the segment to clean

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-23 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-618766447 ok to test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ConcurrencyPractitioner removed a comment on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-23 Thread GitBox
ConcurrencyPractitioner removed a comment on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-618687469 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-04-23 Thread GitBox
ConcurrencyPractitioner commented on pull request #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-618766295 @junrao Did try on another PR. Looks like it didn't work. I will fire a JIRA. This is an

[jira] [Comment Edited] (KAFKA-9913) TopologyDescription should expose all topic name progrematically

2020-04-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091168#comment-17091168 ] Guozhang Wang edited comment on KAFKA-9913 at 4/24/20, 4:32 AM: [~mjsax]

[jira] [Commented] (KAFKA-9859) kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation

2020-04-23 Thread Kin Siu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091216#comment-17091216 ] Kin Siu commented on KAFKA-9859: I have been using 2.4.1 to perform application reset, but there are

[jira] [Comment Edited] (KAFKA-9859) kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation

2020-04-23 Thread Kin Siu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091216#comment-17091216 ] Kin Siu edited comment on KAFKA-9859 at 4/24/20, 5:37 AM: -- I have been using

[GitHub] [kafka] mjsax commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-23 Thread GitBox
mjsax commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414205108 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -701,18 +703,33 @@ private KafkaStreams(final InternalTopologyBuilder

[jira] [Assigned] (KAFKA-9127) Needless group coordination overhead for GlobalKTables

2020-04-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-9127: -- Assignee: Sophie Blee-Goldman > Needless group coordination overhead for

[GitHub] [kafka] ijuma commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414296613 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir to

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-23 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414188592 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -1146,4 +1146,13 @@ private static byte checkRange(final byte i) {

[GitHub] [kafka] thspinto commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-23 Thread GitBox
thspinto commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618732263 Could you post your configuration file @bseenu? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-23 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618732741 Hi @bseenu , it will be very helpful to elaborate the operational sequence of your testing case? e.g. which cluster your consumer initially consume from? Did you switch your

[GitHub] [kafka] vvcephei opened a new pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-23 Thread GitBox
vvcephei opened a new pull request #8541: URL: https://github.com/apache/kafka/pull/8541 * add a config to set the TaskAssignor * set the default assignor to HighAvailabilityTaskAssignor * fix broken tests ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] vvcephei commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-23 Thread GitBox
vvcephei commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414214864 ## File path: checkstyle/suppressions.xml ## @@ -181,7 +181,7 @@ files="StreamsPartitionAssignor.java"/> +

[GitHub] [kafka] zshuo commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
zshuo commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618311862 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413720950 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -293,13 +293,6 @@ class TopicCommandWithAdminClientTest

[jira] [Created] (KAFKA-9908) Kafka client always trying "kinit -R" even the ticketCache has been renewed by external

2020-04-23 Thread Bob Wen (Jira)
Bob Wen created KAFKA-9908: -- Summary: Kafka client always trying "kinit -R" even the ticketCache has been renewed by external Key: KAFKA-9908 URL: https://issues.apache.org/jira/browse/KAFKA-9908 Project:

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618329701 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cmccabe commented on issue #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on issue #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-618337731 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (KAFKA-9909) Kafka Streams : offset control to Streams API

2020-04-23 Thread Gopikrishna (Jira)
Gopikrishna created KAFKA-9909: -- Summary: Kafka Streams : offset control to Streams API Key: KAFKA-9909 URL: https://issues.apache.org/jira/browse/KAFKA-9909 Project: Kafka Issue Type:

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-23 Thread GitBox
mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413717848 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1553,6 +1554,50 @@ class KafkaApisTest {

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413719892 ## File path: core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala ## @@ -255,7 +225,7 @@ class ReassignPartitionsCommandArgsTest

[GitHub] [kafka] cmccabe edited a comment on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe edited a comment on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618341335 > For the scram credential related code piece, switched to using --bootstrap-server even we don't support it yet. We need to keep using --zookeeper in the SCRAM case since

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618341335 > For the scram credential related code piece, switched to using --bootstrap-server even we don't support it yet. We need to keep using --zookeeper in the SCRAM case since we don't

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618343269 Same issue with `kafka-reassign-partitions.sh`. It also needs to be converted to use `--bootstrap-server`. This is an

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618342661 It looks like the places where we invoke `kafka-configs.sh` still need to be converted over to use `--bootstrap-server`

[GitHub] [kafka] lbradstreet edited a comment on issue #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
lbradstreet edited a comment on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-618220519 I updated the PR to pass Time everywhere that's required. Note that I did not switch the fetcher tests to use MockTime as it appears they are timing dependent and may depend

[GitHub] [kafka] ijuma commented on issue #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on issue #8467: URL: https://github.com/apache/kafka/pull/8467#issuecomment-618225193 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on issue #8464: KAFKA-9852: Change the max duration that calls to the buffer pool can block from 2000ms to 10ms

2020-04-23 Thread GitBox
ijuma commented on issue #8464: URL: https://github.com/apache/kafka/pull/8464#issuecomment-618226016 Unrelated failed flaky test: > kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

[GitHub] [kafka] ijuma commented on issue #8429: MINOR: Enable fatal warnings with scala 2.13

2020-04-23 Thread GitBox
ijuma commented on issue #8429: URL: https://github.com/apache/kafka/pull/8429#issuecomment-618238203 Unrelated flaky test failure in 1 (out of 3) jobs: > kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618280153 @zshuo No. I've taken a look at the change and it looks good. By commenting `ok to test`, I triggered the Jenkins builds. If those builds pass, I'll merge your PR

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Splitted unit tests for --zookeeper flag removal

2020-04-23 Thread GitBox
cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413713907 ## File path: core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala ## @@ -1408,13 +1408,23 @@ class

[GitHub] [kafka] tombentley commented on a change in pull request #8449: KAFKA-7613: Enable -Xlint:try, fixing warnings

2020-04-23 Thread GitBox
tombentley commented on a change in pull request #8449: URL: https://github.com/apache/kafka/pull/8449#discussion_r413718361 ## File path: clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java ## @@ -32,6 +32,7 @@ * using the default constructor and

[GitHub] [kafka] cmccabe commented on issue #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on issue #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-618334410 For `ConfigCommandTest.scala`, we should keep the tests of the `--zookeeper` command since that is still present in trunk. The goal should be to remove unnecessary dependencies on

[GitHub] [kafka] cmccabe commented on a change in pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on a change in pull request #8527: URL: https://github.com/apache/kafka/pull/8527#discussion_r413718893 ## File path: core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala ## @@ -227,8 +227,10 @@ class DeleteTopicTest extends ZooKeeperTestHarness {

[GitHub] [kafka] cmccabe commented on issue #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-04-23 Thread GitBox
cmccabe commented on issue #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-618338178 Looks like the JDK8 build flaked. ``` 11:00:07 Error occurred during initialization of VM 11:00:07 java.lang.OutOfMemoryError: unable to create new native thread ``` We've

[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

2020-04-23 Thread GitBox
cmccabe commented on issue #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-618343631 There are a lot of whitespace-only changes in this PR that are kind of confusing. Can you please do these in a separate PR or just drop them?

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413540667 ## File path: core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala ## @@ -60,6 +61,7 @@ class ReplicaAlterLogDirsThreadTest {

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413541070 ## File path: core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala ## @@ -60,6 +61,7 @@ class ReplicaAlterLogDirsThreadTest {

[GitHub] [kafka] kkonstantine commented on a change in pull request #8536: KAFKA-9883: Add better error message when REST API forwards a request and leader is not known

2020-04-23 Thread GitBox
kkonstantine commented on a change in pull request #8536: URL: https://github.com/apache/kafka/pull/8536#discussion_r413549161 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java ## @@ -341,7 +341,15 @@ private

[GitHub] [kafka] ijuma commented on issue #8456: MINOR: Annotate KafkaAdminClientTest.testAlterClientQuotas() with @Test

2020-04-23 Thread GitBox
ijuma commented on issue #8456: URL: https://github.com/apache/kafka/pull/8456#issuecomment-618226721 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ijuma opened a new pull request #8537: KAFKA-9907: Switch default build to Scala 2.13

2020-04-23 Thread GitBox
ijuma opened a new pull request #8537: URL: https://github.com/apache/kafka/pull/8537 Scala 2.13.2 introduces support for suppressing warnings, which makes it possible to enable fatal warnings. This is useful enough from a development perspective to justify this change. In

[GitHub] [kafka] ijuma commented on issue #8513: MINOR: jackson 2.10.3

2020-04-23 Thread GitBox
ijuma commented on issue #8513: URL: https://github.com/apache/kafka/pull/8513#issuecomment-618224164 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413563167 ## File path: core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala ## @@ -60,6 +61,7 @@ class ReplicaAlterLogDirsThreadTest {

[GitHub] [kafka] ijuma commented on issue #8427: KAFKA-9761: Use Admin Client default timeout instead of using 5sec timeout default

2020-04-23 Thread GitBox
ijuma commented on issue #8427: URL: https://github.com/apache/kafka/pull/8427#issuecomment-618230317 Thanks for the PR. Since this has potential compatibility implications, it requires a KIP. This is an automated message

[GitHub] [kafka] leonardge commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-23 Thread GitBox
leonardge commented on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618229704 Why is the CI failing? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cadonna commented on issue #8532: HOTFIX: Fix broker bounce system tests

2020-04-23 Thread GitBox
cadonna commented on issue #8532: URL: https://github.com/apache/kafka/pull/8532#issuecomment-618292163 Streams system tests above are green. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ijuma commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

2020-04-23 Thread GitBox
ijuma commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-618204746 The same flaky test failed twice for the JDK 8 and Scala 2.12 build: > kafka.api.TransactionsTest.testBumpTransactionalEpoch The other two builds passed.

[GitHub] [kafka] dajac commented on a change in pull request #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-23 Thread GitBox
dajac commented on a change in pull request #8509: URL: https://github.com/apache/kafka/pull/8509#discussion_r413541177 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3084,12 +3084,9 @@ class KafkaApis(val requestChannel: RequestChannel, // Broker

[GitHub] [kafka] dajac commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-04-23 Thread GitBox
dajac commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r413546760 ## File path: clients/src/test/java/org/apache/kafka/common/requests/AlterReplicaLogDirsResponseTest.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ijuma commented on a change in pull request #8449: KAFKA-7613: Enable -Xlint:try, fixing warnings

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8449: URL: https://github.com/apache/kafka/pull/8449#discussion_r413573833 ## File path: clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java ## @@ -32,6 +32,7 @@ * using the default constructor and will

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-23 Thread GitBox
mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413647728 ## File path: core/src/test/scala/unit/kafka/admin/DescribeConsumerGroupTest.scala ## @@ -52,11 +51,25 @@ class DescribeConsumerGroupTest extends

[GitHub] [kafka] ijuma commented on a change in pull request #8450: KAFKA-7613: Enable -Xlint:rawtypes in clients, fixing warnings

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8450: URL: https://github.com/apache/kafka/pull/8450#discussion_r413572295 ## File path: build.gradle ## @@ -1103,8 +1103,14 @@ project(':clients') { } compileJava.dependsOn 'processMessages' + compileJava { +

[GitHub] [kafka] tombentley commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

2020-04-23 Thread GitBox
tombentley commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-618227764 Thanks @ijuma This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r413563167 ## File path: core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala ## @@ -60,6 +61,7 @@ class ReplicaAlterLogDirsThreadTest {

[GitHub] [kafka] lbradstreet commented on issue #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
lbradstreet commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-618220519 I updated the PR to use Time everywhere that's required. Note that I did not switch the fetcher tests to use MockTime as it appears they are timing dependent and may depend on

[GitHub] [kafka] zshuo commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
zshuo commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618278914 Is there anything else I need to do before it gets merged? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] lrytz commented on a change in pull request #8429: MINOR: Enable fatal warnings with scala 2.13

2020-04-23 Thread GitBox
lrytz commented on a change in pull request #8429: URL: https://github.com/apache/kafka/pull/8429#discussion_r413662887 ## File path: build.gradle ## @@ -484,6 +484,12 @@ subprojects { scalaCompileOptions.additionalParameters += ["-opt:l:inline"]

[jira] [Commented] (KAFKA-9903) kafka ShutdownableThread judge thread isRuning status has some bug

2020-04-23 Thread shilin Lu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090355#comment-17090355 ] shilin Lu commented on KAFKA-9903: -- [~guozhang] [~ijuma] > kafka ShutdownableThread judge thread

[GitHub] [kafka] leonardge commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-23 Thread GitBox
leonardge commented on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264854 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] leonardge removed a comment on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-23 Thread GitBox
leonardge removed a comment on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264854 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] stanislavkozlovski commented on issue #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-23 Thread GitBox
stanislavkozlovski commented on issue #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-618264305 JDK 8 failed with ``` 06:01:27 # 06:01:27 # There is insufficient memory for the Java Runtime Environment to continue. 06:01:27 # Cannot create GC thread. Out of

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618276927 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] junrao commented on issue #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

2020-04-23 Thread GitBox
junrao commented on issue #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-618473781 @cmccabe : Does this look good to you? Thanks. This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-9603) Number of open files keeps increasing in Streams application

2020-04-23 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090715#comment-17090715 ] Bruno Cadonna commented on KAFKA-9603: -- [~lpandzic] Thank you for the information. In the

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-23 Thread GitBox
hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618497996 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-61840 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] abbccdda commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-04-23 Thread GitBox
abbccdda commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r413925987 ## File path: clients/src/main/java/org/apache/kafka/common/requests/EpochEndOffset.java ## @@ -86,4 +84,9 @@ public boolean equals(Object o) {

[GitHub] [kafka] hachikuji commented on issue #8454: KAFKA-9844; Maximum number of members within a group is not always enforced due to a race condition in join group

2020-04-23 Thread GitBox
hachikuji commented on issue #8454: URL: https://github.com/apache/kafka/pull/8454#issuecomment-618505412 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2020-04-23 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090711#comment-17090711 ] Jun Rao commented on KAFKA-2419: Sensor expiring is only used on the broker. For the clients, typically

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

2020-04-23 Thread Patrick Szalapski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090718#comment-17090718 ] Patrick Szalapski commented on KAFKA-9747: -- Yes, please at least give a WARN or ERROR as to why

[jira] [Commented] (KAFKA-9652) Throttle time metric needs to be updated for KIP-219

2020-04-23 Thread Agam Brahma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090732#comment-17090732 ] Agam Brahma commented on KAFKA-9652: Not working on this right now, please go ahead. > Throttle time

[jira] [Comment Edited] (KAFKA-9747) No tasks created for a connector

2020-04-23 Thread Patrick Szalapski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090718#comment-17090718 ] Patrick Szalapski edited comment on KAFKA-9747 at 4/23/20, 4:03 PM:

[jira] [Assigned] (KAFKA-9652) Throttle time metric needs to be updated for KIP-219

2020-04-23 Thread Agam Brahma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Agam Brahma reassigned KAFKA-9652: -- Assignee: Ismael Juma (was: Agam Brahma) > Throttle time metric needs to be updated for

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-23 Thread GitBox
mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413794118 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -84,6 +87,15 @@ object ConsumerGroupCommand extends Logging { } }

[GitHub] [kafka] mimaison commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-23 Thread GitBox
mimaison commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r413794118 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -84,6 +87,15 @@ object ConsumerGroupCommand extends Logging { } }

[GitHub] [kafka] ijuma commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

2020-04-23 Thread GitBox
ijuma commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r413826884 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir to

[GitHub] [kafka] ijuma commented on issue #7231: MINOR: Log firstUnstableOffset in debug log line in LogCleanerManager#cleanableOffsets

2020-04-23 Thread GitBox
ijuma commented on issue #7231: URL: https://github.com/apache/kafka/pull/7231#issuecomment-618430662 Looks like this has a conflict. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] bbejeck commented on issue #8504: KAFKA-9298: reuse mapped stream error in joins

2020-04-23 Thread GitBox
bbejeck commented on issue #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-618450970 @mjsax thanks for the review! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on issue #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-23 Thread GitBox
ijuma commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-618409553 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-9907) Switch default build to Scala 2.13

2020-04-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-9907. Resolution: Fixed > Switch default build to Scala 2.13 > -- > >

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618418722 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ijuma commented on issue #8364: MINOR: Partition is under reassignment when adding and removing

2020-04-23 Thread GitBox
ijuma commented on issue #8364: URL: https://github.com/apache/kafka/pull/8364#issuecomment-618429581 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on issue #8151: MINOR: Add missing @Test annotations to miscellaneous tests

2020-04-23 Thread GitBox
ijuma commented on issue #8151: URL: https://github.com/apache/kafka/pull/8151#issuecomment-618430121 @stanislavkozlovski any thoughts on the comments above? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618400831 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   >