[jira] [Commented] (KAFKA-10287) fix flaky streams/streams_standby_replica_test.py

2020-07-23 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164009#comment-17164009 ] John Roesler commented on KAFKA-10287: -- >From [~cadonna] 's PR: > In PR [#8962|htt

[GitHub] [kafka] soondenana commented on a change in pull request #9054: KAFKA-10282: Remove Log metrics immediately when deleting log

2020-07-23 Thread GitBox
soondenana commented on a change in pull request #9054: URL: https://github.com/apache/kafka/pull/9054#discussion_r459766825 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1151,6 +1149,16 @@ class LogManager(logDirs: Seq[File], } } } + + pri

[jira] [Assigned] (KAFKA-10287) fix flaky streams/streams_standby_replica_test.py

2020-07-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-10287: -- Assignee: Bruno Cadonna (was: Chia-Ping Tsai) > fix flaky streams/streams_standby_re

[jira] [Commented] (KAFKA-10287) fix flaky streams/streams_standby_replica_test.py

2020-07-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164012#comment-17164012 ] Chia-Ping Tsai commented on KAFKA-10287: {quote} Sorry, I was not aware that you

[GitHub] [kafka] junrao merged pull request #9059: KAFKA-10300 fix flaky core/group_mode_transactions_test.py

2020-07-23 Thread GitBox
junrao merged pull request #9059: URL: https://github.com/apache/kafka/pull/9059 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-10300) fix flaky core/group_mode_transactions_test.py

2020-07-23 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10300. - Fix Version/s: 2.7.0 Resolution: Fixed merged to trunk > fix flaky core/group_mode_transactions_

[GitHub] [kafka] ableegoldman commented on a change in pull request #8988: KAFKA-10199: Separate restore threads [WIP]

2020-07-23 Thread GitBox
ableegoldman commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r459768271 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -365,72 +368,104 @@ private Changelog

[GitHub] [kafka] ableegoldman commented on a change in pull request #8988: KAFKA-10199: Separate restore threads [WIP]

2020-07-23 Thread GitBox
ableegoldman commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r459776764 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -310,18 +313,14 @@ public void enforc

[GitHub] [kafka] guozhangwang commented on pull request #9068: MINOR: INFO log4j when request re-join

2020-07-23 Thread GitBox
guozhangwang commented on pull request #9068: URL: https://github.com/apache/kafka/pull/9068#issuecomment-663282642 @vvcephei @abbccdda This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] guozhangwang opened a new pull request #9068: MINOR: INFO log4j when request re-join

2020-07-23 Thread GitBox
guozhangwang opened a new pull request #9068: URL: https://github.com/apache/kafka/pull/9068 While debugging a rebalance scenario I found that inside rejoinNeededOrPending when we trigger rebalance due to metadata or subscription changes it is not logged, and hence it's actually a bit tric

[GitHub] [kafka] guozhangwang commented on pull request #9068: MINOR: INFO log4j when request re-join

2020-07-23 Thread GitBox
guozhangwang commented on pull request #9068: URL: https://github.com/apache/kafka/pull/9068#issuecomment-663282928 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #9068: MINOR: INFO log4j when request re-join

2020-07-23 Thread GitBox
guozhangwang commented on pull request #9068: URL: https://github.com/apache/kafka/pull/9068#issuecomment-663282973 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459788176 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -131,11 +135,40 @@ public void setGlobalPr

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459790103 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -131,11 +135,40 @@ public void setGlobalPr

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459790323 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void restoreStat

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459791370 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void restoreStat

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459791741 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void restoreStat

[GitHub] [kafka] vitojeng opened a new pull request #9069: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2020-07-23 Thread GitBox
vitojeng opened a new pull request #9069: URL: https://github.com/apache/kafka/pull/9069 follow-up #8200 KAFKA-5876's PR break into multiple parts, this PR is part 2: apply UnknownStateStoreException ### Committer Checklist (excluded from commit message) - [ ] Verify desi

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r459793713 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -96,13 +104,15 @@ public InternalTopicManage

[GitHub] [kafka] guozhangwang commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459799708 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void rest

[GitHub] [kafka] guozhangwang commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r459800202 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -154,27 +164,34 @@ public InternalTop

[GitHub] [kafka] vitojeng commented on a change in pull request #9069: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2020-07-23 Thread GitBox
vitojeng commented on a change in pull request #9069: URL: https://github.com/apache/kafka/pull/9069#discussion_r459805054 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -693,6 +695,16 @@ public void shouldNotGetQueryMetadataWithPartit

[jira] [Commented] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164063#comment-17164063 ] Guozhang Wang commented on KAFKA-10284: --- What [~ableegoldman] described seems alig

[GitHub] [kafka] huxihx commented on pull request #9051: KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work

2020-07-23 Thread GitBox
huxihx commented on pull request #9051: URL: https://github.com/apache/kafka/pull/9051#issuecomment-663309863 @rajinisivaram Thanks for the review, merging to trunk This is an automated message from the Apache Git Service. To

[GitHub] [kafka] huxihx merged pull request #9051: KAFKA-10268: dynamic config like "--delete-config log.retention.ms" doesn't work

2020-07-23 Thread GitBox
huxihx merged pull request #9051: URL: https://github.com/apache/kafka/pull/9051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-10268) dynamic config like "--delete-config log.retention.ms" doesn't work

2020-07-23 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx resolved KAFKA-10268. Fix Version/s: 2.7.0 Resolution: Fixed > dynamic config like "--delete-config log.retention.ms" doe

[GitHub] [kafka] showuon commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-23 Thread GitBox
showuon commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r459818087 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -62,6 +65,7 @@ private static fi

[GitHub] [kafka] vvcephei opened a new pull request #9070: MINOR: speed up release script

2020-07-23 Thread GitBox
vvcephei opened a new pull request #9070: URL: https://github.com/apache/kafka/pull/9070 Fixes slow release due to establishing a separate SSH connection per file to copy. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Ve

[GitHub] [kafka] showuon commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-23 Thread GitBox
showuon commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r459822704 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -315,9 +319,34 @@ public void testRep

[GitHub] [kafka] vvcephei commented on pull request #9070: MINOR: speed up release script

2020-07-23 Thread GitBox
vvcephei commented on pull request #9070: URL: https://github.com/apache/kafka/pull/9070#issuecomment-663321224 Hey all, after waiting at least 10 hours cumulatively for file uploads (so far) for the 2.5.1 release candidates, I've been feeling motivated to try and improve the situation.

[jira] [Created] (KAFKA-10305) Print usage when parsing fails for ConsumerPerformance

2020-07-23 Thread huxihx (Jira)
huxihx created KAFKA-10305: -- Summary: Print usage when parsing fails for ConsumerPerformance Key: KAFKA-10305 URL: https://issues.apache.org/jira/browse/KAFKA-10305 Project: Kafka Issue Type: Improv

[GitHub] [kafka] vvcephei commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
vvcephei commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459827653 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -131,11 +135,40 @@ public void setGloba

[GitHub] [kafka] vvcephei commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
vvcephei commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459827997 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void restoreS

[GitHub] [kafka] vvcephei commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
vvcephei commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459827952 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void restoreS

[GitHub] [kafka] vvcephei commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
vvcephei commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459827653 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -131,11 +135,40 @@ public void setGloba

[GitHub] [kafka] showuon commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-23 Thread GitBox
showuon commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-663329158 @mimaison , thanks for your comments. I've updated in this commit: https://github.com/apache/kafka/pull/9029/commits/c2e2d70c1a2317794ce49292024a977a02159445. What I did are: 1

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-23 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r459837317 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void restoreStat

[GitHub] [kafka] ijuma commented on pull request #9065: KAFKA-10301: Do not clear Partition#remoteReplicasMap during partition assignment updates

2020-07-23 Thread GitBox
ijuma commented on pull request #9065: URL: https://github.com/apache/kafka/pull/9065#issuecomment-663335011 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r459850212 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -454,6 +456,41 @@ public void flush(

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r459850831 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -49,6 +61,31 @@ this.stateDirectory

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r459853500 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -38,13 +41,39 @@ */ final class StateM

[jira] [Commented] (KAFKA-10284) Group membership update due to static member rejoin should be persisted

2020-07-23 Thread Akshay Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164146#comment-17164146 ] Akshay Sharma commented on KAFKA-10284: --- At initial, Group Coordinator will assign

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r459857477 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -243,18 +242,24 @@ public void handleAssignmen

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r459858314 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -466,15 +458,8 @@ public void postCommit() {

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r459859152 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -93,8 +93,8 @@ public boolean isActive() {

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-23 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r459859723 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -542,13 +530,22 @@ public void closeCleanAndRec

[GitHub] [kafka] huxihx opened a new pull request #9071: KAFKA-10305: Print usage when parsing fails for ConsumerPerformance

2020-07-23 Thread GitBox
huxihx opened a new pull request #9071: URL: https://github.com/apache/kafka/pull/9071 https://issues.apache.org/jira/browse/KAFKA-10305 When `kafka-consumer-perf-test.sh` is executed without required options or no options at all, only the error message is displayed. It's better off

[GitHub] [kafka] huxihx commented on pull request #7711: KAFKA-9157: Avoid generating empty segments if all records are deleted after cleaning

2020-07-23 Thread GitBox
huxihx commented on pull request #7711: URL: https://github.com/apache/kafka/pull/7711#issuecomment-663360469 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

<    1   2