[GitHub] [kafka] dajac commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-12 Thread GitBox
dajac commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r521902936 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java ## @@ -194,7 +106,27 @@ private ProduceRequest build(short version,

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-12 Thread GitBox
chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r521927723 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java ## @@ -194,7 +106,27 @@ private ProduceRequest build(short versio

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-12 Thread GitBox
chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r521931887 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java ## @@ -323,27 +222,30 @@ public String toString(boolean verbose)

[GitHub] [kafka] feyman2016 opened a new pull request #9588: KAFKA-10699: Add system test coverage for group coordinator migration

2020-11-12 Thread GitBox
feyman2016 opened a new pull request #9588: URL: https://github.com/apache/kafka/pull/9588 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade note

[GitHub] [kafka] feyman2016 commented on pull request #9588: KAFKA-10699: Add system test coverage for group coordinator migration

2020-11-12 Thread GitBox
feyman2016 commented on pull request #9588: URL: https://github.com/apache/kafka/pull/9588#issuecomment-725938758 Running without the fix in KAFKA-10284(https://github.com/apache/kafka/pull/9270), the `FencedInstanceIdException` will be thrown. ---

[GitHub] [kafka] feyman2016 edited a comment on pull request #9588: KAFKA-10699: Add system test coverage for group coordinator migration

2020-11-12 Thread GitBox
feyman2016 edited a comment on pull request #9588: URL: https://github.com/apache/kafka/pull/9588#issuecomment-725938758 Running without the fix in KAFKA-10284(https://github.com/apache/kafka/pull/9270), the `FencedInstanceIdException` will be thrown, details as below. Test log: ```

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-12 Thread GitBox
chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r521927723 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java ## @@ -194,7 +106,27 @@ private ProduceRequest build(short versio

[jira] [Created] (KAFKA-10709) Sender#sendProduceRequest should use auto-generated protocol directly

2020-11-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10709: -- Summary: Sender#sendProduceRequest should use auto-generated protocol directly Key: KAFKA-10709 URL: https://issues.apache.org/jira/browse/KAFKA-10709 Project: Ka

[jira] [Resolved] (KAFKA-10446) add "lz4" and "zstd" to compression type of benchmark_test.py

2020-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10446. Resolution: Won't Fix > add "lz4" and "zstd" to compression type of benchmark_test.py > --

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-12 Thread GitBox
chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r521957221 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java ## @@ -194,7 +106,27 @@ private ProduceRequest build(short versio

[jira] [Resolved] (KAFKA-10438) Lazy initialization of record header to reduce memory usage in validating records

2020-11-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10438. Fix Version/s: 2.8.0 Resolution: Fixed > Lazy initialization of record header to re

[GitHub] [kafka] chia7712 closed pull request #9587: Fix memory leak in JmxReporter

2020-11-12 Thread GitBox
chia7712 closed pull request #9587: URL: https://github.com/apache/kafka/pull/9587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9587: Fix memory leak in JmxReporter

2020-11-12 Thread GitBox
chia7712 commented on pull request #9587: URL: https://github.com/apache/kafka/pull/9587#issuecomment-725960391 @vergilchiu I'm going to close this PR. feel free to reopen it if you have other idea. This is an automated mess

[jira] [Created] (KAFKA-10710) MirrorMaker 2 creates all combinations of herders

2020-11-12 Thread Julien C (Jira)
Julien C created KAFKA-10710: Summary: MirrorMaker 2 creates all combinations of herders Key: KAFKA-10710 URL: https://issues.apache.org/jira/browse/KAFKA-10710 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10710) MirrorMaker 2 creates all combinations of herders

2020-11-12 Thread Julien C (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien C updated KAFKA-10710: - Description: We are using MM2 distributed to synchronize topics from a "Central" broker down to multipl

[jira] [Updated] (KAFKA-10710) MirrorMaker 2 creates all combinations of herders

2020-11-12 Thread Julien C (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien C updated KAFKA-10710: - Description: We are using MM2 distributed to synchronize topics from a "Central" broker down to multipl

[jira] [Updated] (KAFKA-10710) MirrorMaker 2 creates all combinations of herders

2020-11-12 Thread Julien C (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien C updated KAFKA-10710: - Description: We are using MM2 distributed to synchronize topics from a "Central" broker down to multipl

[jira] [Created] (KAFKA-10711) A low value in commit.interval.ms leads to unnecessary committing offsets

2020-11-12 Thread Ruslan Gryn (Jira)
Ruslan Gryn created KAFKA-10711: --- Summary: A low value in commit.interval.ms leads to unnecessary committing offsets Key: KAFKA-10711 URL: https://issues.apache.org/jira/browse/KAFKA-10711 Project: Kafk

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #7498: KAFKA-9023: Log request destination when the Producer gets disconnected

2020-11-12 Thread GitBox
stanislavkozlovski commented on a change in pull request #7498: URL: https://github.com/apache/kafka/pull/7498#discussion_r521996452 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -639,8 +644,9 @@ else if (error == Errors.CLUS

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #7498: KAFKA-9023: Log request destination when the Producer gets disconnected

2020-11-12 Thread GitBox
stanislavkozlovski commented on a change in pull request #7498: URL: https://github.com/apache/kafka/pull/7498#discussion_r52132 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -659,6 +655,12 @@ else if (error == Errors.CLU

[jira] [Assigned] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-10515: -- Assignee: Mickael Maison > NPE: Foreign key join serde may not be initialized with de

[jira] [Assigned] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-10515: -- Assignee: Thorsten Hake (was: Mickael Maison) > NPE: Foreign key join serde may not

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-12 Thread GitBox
chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r522005653 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java ## @@ -204,118 +75,79 @@ public ProduceResponse(Map responses) {

[jira] [Commented] (KAFKA-10309) KafkaProducer's sendOffsetsToTransaction should not block infinitively

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230553#comment-17230553 ] Mickael Maison commented on KAFKA-10309: Fidex in https://github.com/apache/kafk

[jira] [Comment Edited] (KAFKA-10309) KafkaProducer's sendOffsetsToTransaction should not block infinitively

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230553#comment-17230553 ] Mickael Maison edited comment on KAFKA-10309 at 11/12/20, 11:45 AM: --

[jira] [Resolved] (KAFKA-10309) KafkaProducer's sendOffsetsToTransaction should not block infinitively

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10309. Resolution: Fixed > KafkaProducer's sendOffsetsToTransaction should not block infinitively

[jira] [Closed] (KAFKA-10309) KafkaProducer's sendOffsetsToTransaction should not block infinitively

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison closed KAFKA-10309. -- > KafkaProducer's sendOffsetsToTransaction should not block infinitively > ---

[jira] [Commented] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230559#comment-17230559 ] Mickael Maison commented on KAFKA-10417: SInce there's still no PR, removing 2.6

[jira] [Updated] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10417: --- Fix Version/s: (was: 2.6.1) > suppress() with cogroup() throws ClassCastException >

[jira] [Comment Edited] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230559#comment-17230559 ] Mickael Maison edited comment on KAFKA-10417 at 11/12/20, 11:47 AM: --

[jira] [Updated] (KAFKA-9861) Process Simplification - Community Validation of Kafka Release Candidates

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-9861: -- Fix Version/s: (was: 2.6.1) > Process Simplification - Community Validation of Kafka Releas

[jira] [Commented] (KAFKA-9861) Process Simplification - Community Validation of Kafka Release Candidates

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230560#comment-17230560 ] Mickael Maison commented on KAFKA-9861: --- Since there's still no PR, removing 2.6.1

[GitHub] [kafka] stanislavkozlovski commented on pull request #7498: KAFKA-9023: Log request destination when the Producer gets disconnected

2020-11-12 Thread GitBox
stanislavkozlovski commented on pull request #7498: URL: https://github.com/apache/kafka/pull/7498#issuecomment-726079643 test failures for JDK 15 seem unrelated: ``` kafka.server.ScramServerStartupTest.testAuthentications org.apache.zookeeper.KeeperException$NoAuthException: Keeper

[GitHub] [kafka] cadonna commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

2020-11-12 Thread GitBox
cadonna commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522027942 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -314,6 +317,50 @@ public void buildAndOpti

[GitHub] [kafka] feyman2016 commented on pull request #9588: KAFKA-10699: Add system test coverage for group coordinator migration

2020-11-12 Thread GitBox
feyman2016 commented on pull request #9588: URL: https://github.com/apache/kafka/pull/9588#issuecomment-726134837 The failed test: `org.apache.kafka.streams.integration.StreamTableJoinTopologyOptimizationIntegrationTest.shouldDoStreamTableJoinWithDifferentNumberOfPartitions[Optimization` d

[GitHub] [kafka] feyman2016 edited a comment on pull request #9588: KAFKA-10699: Add system test coverage for group coordinator migration

2020-11-12 Thread GitBox
feyman2016 edited a comment on pull request #9588: URL: https://github.com/apache/kafka/pull/9588#issuecomment-726134837 Call for review @abbccdda :) The failed test: `org.apache.kafka.streams.integration.StreamTableJoinTopologyOptimizationIntegrationTest.shouldDoStreamTableJoinWithDiff

[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-11-12 Thread GitBox
iprithv commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-726148418 Thanks for approving @chia7712 , have attached the images of before and after message. https://user-images.githubusercontent.com/48927540/98959127-fb4d5180-2528-11eb-9f72-4

[GitHub] [kafka] twobeeb opened a new pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-12 Thread GitBox
twobeeb opened a new pull request #9589: URL: https://github.com/apache/kafka/pull/9589 As described in JIRA KAFKA-10710, Running mirror maker 2 with multiple clusters defined in the clusters properties creates a herder for all the possible combinations even if the "link" are not wante

[GitHub] [kafka] vvcephei commented on a change in pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

2020-11-12 Thread GitBox
vvcephei commented on a change in pull request #9489: URL: https://github.com/apache/kafka/pull/9489#discussion_r522203482 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -703,6 +703,16 @@ void runOnce() { /

[GitHub] [kafka] chia7712 commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-11-12 Thread GitBox
chia7712 commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-726159989 @iprithv Thanks for the sharing. nit: there is a redundant space before “batchSize”. This is an automated messag

[jira] [Created] (KAFKA-10712) Update release scripts to Python3

2020-11-12 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-10712: -- Summary: Update release scripts to Python3 Key: KAFKA-10712 URL: https://issues.apache.org/jira/browse/KAFKA-10712 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-10713) Surprising behaviour when bootstrap servers are separated by semicolons

2020-11-12 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-10713: -- Summary: Surprising behaviour when bootstrap servers are separated by semicolons Key: KAFKA-10713 URL: https://issues.apache.org/jira/browse/KAFKA-10713 Project:

[jira] [Updated] (KAFKA-10713) Surprising behaviour when bootstrap servers are separated by semicolons

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10713: --- Description: When creating a Kafka client with bootstrap.servers set to "kafka-0:9092;kafka

[jira] [Updated] (KAFKA-10713) Surprising behaviour when bootstrap servers are separated by semicolons

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10713: --- Description: When creating a Kafka client with {{bootstrap.servers}} set to "kafka-0:9092;k

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522381803 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java ## @@ -71,6 +78,21 @@ public Pattern topicP

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522384690 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java ## @@ -71,6 +78,21 @@ public Pattern topicP

[GitHub] [kafka] jolshan opened a new pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2020-11-12 Thread GitBox
jolshan opened a new pull request #9590: URL: https://github.com/apache/kafka/pull/9590 The current behavior for KafkaConsumer.beginningOffsets on compacted topics is to always return offset 0. However, when looking at the record with the earliest timestamp in the log with KafkaConsumer.of

[jira] [Created] (KAFKA-10714) Save unnecessary end txn call when the transaction is confirmed to be done

2020-11-12 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10714: --- Summary: Save unnecessary end txn call when the transaction is confirmed to be done Key: KAFKA-10714 URL: https://issues.apache.org/jira/browse/KAFKA-10714 Project: Kaf

[GitHub] [kafka] hachikuji merged pull request #9201: MINOR: Increase the amount of time available to the `test_verifiable_producer` test

2020-11-12 Thread GitBox
hachikuji merged pull request #9201: URL: https://github.com/apache/kafka/pull/9201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] Lincong commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-11-12 Thread GitBox
Lincong commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r522441321 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1236,9 +1236,19 @@ class KafkaApis(val requestChannel: RequestChannel, val topicM

[GitHub] [kafka] Lincong commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-11-12 Thread GitBox
Lincong commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r522441321 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1236,9 +1236,19 @@ class KafkaApis(val requestChannel: RequestChannel, val topicM

[GitHub] [kafka] JimGalasyn opened a new pull request #9591: DOCS-5813: Update tip about multi-cluster support

2020-11-12 Thread GitBox
JimGalasyn opened a new pull request #9591: URL: https://github.com/apache/kafka/pull/9591 Fixes internal ticket DOCS-5813. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-12 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r522472868 ## File path: core/src/test/scala/unit/kafka/network/RequestConvertToJsonTest.scala ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522384690 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java ## @@ -71,6 +78,21 @@ public Pattern topicP

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522384690 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamSourceNode.java ## @@ -71,6 +78,21 @@ public Pattern topicP

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522476382 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -895,6 +898,55 @@ public void shouldUseSpecifiedNameForAgg

[jira] [Created] (KAFKA-10715) Support Kafka connect converter for AVRO

2020-11-12 Thread Ravindranath Kakarla (Jira)
Ravindranath Kakarla created KAFKA-10715: Summary: Support Kafka connect converter for AVRO Key: KAFKA-10715 URL: https://issues.apache.org/jira/browse/KAFKA-10715 Project: Kafka Issu

[GitHub] [kafka] ableegoldman commented on a change in pull request #9583: [KAFKA-10705]: Make state stores not readable by others

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r522514992 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,15 @@ public StateDirectory(fin

[jira] [Commented] (KAFKA-10665) Flaky Test StreamTableJoinTopologyOptimizationIntegrationTest.shouldDoStreamTableJoinWithDifferentNumberOfPartitions[Optimization = all]

2020-11-12 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231048#comment-17231048 ] Mickael Maison commented on KAFKA-10665: Failure while building 2.6.1: https://

[GitHub] [kafka] olafurpg commented on pull request #9548: Disable inlining of Scala library methods.

2020-11-12 Thread GitBox
olafurpg commented on pull request #9548: URL: https://github.com/apache/kafka/pull/9548#issuecomment-726424250 Feel free to commandeer this PR if you still think it’s a good idea. I totally understand the reasoning to keep things unchanged so I’m not sure I’m the best person to push this

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522525068 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -314,6 +317,50 @@ public void buildAn

[GitHub] [kafka] mjsax commented on a change in pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-12 Thread GitBox
mjsax commented on a change in pull request #9568: URL: https://github.com/apache/kafka/pull/9568#discussion_r522531710 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -575,17 +577,22 @@ private void setRepa

[GitHub] [kafka] mjsax commented on a change in pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-12 Thread GitBox
mjsax commented on a change in pull request #9568: URL: https://github.com/apache/kafka/pull/9568#discussion_r522531802 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java ## @@ -135,6 +141,37 @@ private Admin createAdminC

[GitHub] [kafka] mjsax commented on a change in pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-12 Thread GitBox
mjsax commented on a change in pull request #9568: URL: https://github.com/apache/kafka/pull/9568#discussion_r522531802 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java ## @@ -135,6 +141,37 @@ private Admin createAdminC

[GitHub] [kafka] mjsax commented on a change in pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-12 Thread GitBox
mjsax commented on a change in pull request #9568: URL: https://github.com/apache/kafka/pull/9568#discussion_r522531802 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java ## @@ -135,6 +141,37 @@ private Admin createAdminC

[GitHub] [kafka] ableegoldman commented on pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

2020-11-12 Thread GitBox
ableegoldman commented on pull request #9582: URL: https://github.com/apache/kafka/pull/9582#issuecomment-726433686 > According to the ticket similar work needs to be done for table() and globalTable(). What do you think of adding subtasks to the ticket to track what has already been done

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow reading the same topic multiple times in the DSL

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r522549685 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -314,6 +317,50 @@ public void buildAn

[jira] [Created] (KAFKA-10716) Streams processId is unstable across restarts resulting in task mass migration

2020-11-12 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-10716: -- Summary: Streams processId is unstable across restarts resulting in task mass migration Key: KAFKA-10716 URL: https://issues.apache.org/jira/browse/KAFKA-10716

[jira] [Commented] (KAFKA-10678) Re-deploying Streams app causes rebalance and task migration

2020-11-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231084#comment-17231084 ] A. Sophie Blee-Goldman commented on KAFKA-10678: Yeah, it seems like any

[jira] [Commented] (KAFKA-10716) Streams processId is unstable across restarts resulting in task mass migration

2020-11-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231116#comment-17231116 ] A. Sophie Blee-Goldman commented on KAFKA-10716: There are a few possibl

[GitHub] [kafka] ableegoldman commented on a change in pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9489: URL: https://github.com/apache/kafka/pull/9489#discussion_r522579641 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -703,6 +703,16 @@ void runOnce() {

[jira] [Commented] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2020-11-12 Thread Richard Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231123#comment-17231123 ] Richard Yu commented on KAFKA-10575: Thanks for letting me know! I was already looki

[GitHub] [kafka] ableegoldman commented on a change in pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9489: URL: https://github.com/apache/kafka/pull/9489#discussion_r522591013 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -703,6 +703,16 @@ void runOnce() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9568: URL: https://github.com/apache/kafka/pull/9568#discussion_r522591645 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -575,17 +577,22 @@ private void

[GitHub] [kafka] abbccdda merged pull request #9588: KAFKA-10699: Add system test coverage for group coordinator migration

2020-11-12 Thread GitBox
abbccdda merged pull request #9588: URL: https://github.com/apache/kafka/pull/9588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ableegoldman commented on a change in pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9568: URL: https://github.com/apache/kafka/pull/9568#discussion_r522594933 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java ## @@ -135,6 +141,37 @@ private Admin creat

[GitHub] [kafka] ableegoldman commented on a change in pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9568: URL: https://github.com/apache/kafka/pull/9568#discussion_r522595543 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java ## @@ -135,6 +141,37 @@ private Admin creat

[GitHub] [kafka] chia7712 commented on pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-11-12 Thread GitBox
chia7712 commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-726491192 @Lincong Thanks for updating code. Could you fix the conflicting files as well? This is an automated message fro

[GitHub] [kafka] Lincong commented on pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-11-12 Thread GitBox
Lincong commented on pull request #9435: URL: https://github.com/apache/kafka/pull/9435#issuecomment-726495188 > @Lincong Thanks for updating code. Could you fix the conflicting files as well? Conflicts resolved This

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518488577 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -255,8 +255,9 @@ public ByteBuffe

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-12 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r522596527 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +375,93 @@ public void setUncaughtExceptionHandler(final T

[GitHub] [kafka] chia7712 commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-12 Thread GitBox
chia7712 commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r522670294 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java ## @@ -204,118 +75,79 @@ public ProduceResponse(Map responses) {

[jira] [Assigned] (KAFKA-10713) Surprising behaviour when bootstrap servers are separated by semicolons

2020-11-12 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-10713: --- Assignee: Tom Bentley > Surprising behaviour when bootstrap servers are separated by semico

[GitHub] [kafka] guozhangwang commented on a change in pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

2020-11-12 Thread GitBox
guozhangwang commented on a change in pull request #9569: URL: https://github.com/apache/kafka/pull/9569#discussion_r522675518 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -713,6 +715,8 @@ public void sendOffsetsToTransaction(M

[jira] [Created] (KAFKA-10717) ACL authorization log when consumer requires all topics

2020-11-12 Thread Stefan Bejan (Jira)
Stefan Bejan created KAFKA-10717: Summary: ACL authorization log when consumer requires all topics Key: KAFKA-10717 URL: https://issues.apache.org/jira/browse/KAFKA-10717 Project: Kafka Issue