[GitHub] [kafka] highluck commented on pull request #9786: MINOR: remove unnecessary code AND Type clarification

2021-04-28 Thread GitBox
highluck commented on pull request #9786: URL: https://github.com/apache/kafka/pull/9786#issuecomment-828285957 ping @chia7712 thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[jira] [Updated] (KAFKA-12723) Potential NPE in SnapshottableHashTable.java

2021-04-28 Thread loyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loyi updated KAFKA-12723: - Description: The method mergeFrom of {color:#de350b}HashTier{color} maybe has potential NPE ,  the attribute

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[jira] [Updated] (KAFKA-12723) Potential NPE in SnapshottableHashTable.java

2021-04-28 Thread loyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loyi updated KAFKA-12723: - Description: The method mergeFrom of {color:#de350b}HashTier{color} maybe has potential NPE ,  the attribute

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-28 Thread GitBox
kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r621909685 ## File path: raft/src/main/java/org/apache/kafka/raft/metadata/AbstractApiMessageSerde.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] highluck removed a comment on pull request #9786: MINOR: remove unnecessary code AND Type clarification

2021-04-28 Thread GitBox
highluck removed a comment on pull request #9786: URL: https://github.com/apache/kafka/pull/9786#issuecomment-785059958 ping @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r621951920 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -108,6 +107,8 @@ private boolean

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-28 Thread GitBox
kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r621925315 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java ## @@ -0,0 +1,105 @@

[jira] [Created] (KAFKA-12723) Potential NPE in SnapshottableHashTable.java

2021-04-28 Thread loyi (Jira)
loyi created KAFKA-12723: Summary: Potential NPE in SnapshottableHashTable.java Key: KAFKA-12723 URL: https://issues.apache.org/jira/browse/KAFKA-12723 Project: Kafka Issue Type: Bug Affects

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-04-28 Thread GitBox
tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-828333212 @hachikuji Thanks, I was being slow on the uptake, but what you describe makes perfect sense. I've moved the logic to the GroupMetadataManager, am using the max observed epoch

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[jira] [Updated] (KAFKA-12723) Potential NPE in SnapshottableHashTable.java

2021-04-28 Thread loyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loyi updated KAFKA-12723: - Description: The method mergeFrom of {color:#de350b}HashTier{color} maybe has potential NPE ,  the attribute

[GitHub] [kafka] saddays opened a new pull request #10601: KAFKA-12723: Fix potential NPE in HashTier

2021-04-28 Thread GitBox
saddays opened a new pull request #10601: URL: https://github.com/apache/kafka/pull/10601 Fix potential NPE , [kafka-12723](https://issues.apache.org/jira/browse/KAFKA-12723) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] ijuma commented on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration `testRuntime`

2021-04-28 Thread GitBox
ijuma commented on pull request #10466: URL: https://github.com/apache/kafka/pull/10466#issuecomment-828682155 Unrelated failures, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-12718) SessionWindows are closed too early

2021-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334964#comment-17334964 ] Matthias J. Sax commented on KAFKA-12718: - I was just looking into `suppress()` implementation,

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-04-28 Thread GitBox
mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r622492083 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to

[GitHub] [kafka] wcarlson5 commented on pull request #10603: WIP: handle missing sink topics in a separate way

2021-04-28 Thread GitBox
wcarlson5 commented on pull request #10603: URL: https://github.com/apache/kafka/pull/10603#issuecomment-828769426 This will not work without significant other changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] wcarlson5 closed pull request #10603: WIP: handle missing sink topics in a separate way

2021-04-28 Thread GitBox
wcarlson5 closed pull request #10603: URL: https://github.com/apache/kafka/pull/10603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ijuma merged pull request #10466: KAFKA-12417: streams `copyDependentLibs` should not copy testRuntime configuration jars

2021-04-28 Thread GitBox
ijuma merged pull request #10466: URL: https://github.com/apache/kafka/pull/10466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Reopened] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-04-28 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-9295: --- Still failing, saw this on both the Java 8 and Java 11 build of a PR:

[GitHub] [kafka] hachikuji commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-28 Thread GitBox
hachikuji commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622470077 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -67,6 +74,30 @@ protected LeaderState( }

[GitHub] [kafka] hachikuji commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-28 Thread GitBox
hachikuji commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622470077 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -67,6 +74,30 @@ protected LeaderState( }

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-28 Thread GitBox
hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622473204 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -1267,6 +1266,64 @@ class PlaintextConsumerTest extends

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-04-28 Thread GitBox
mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r622492627 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to

[GitHub] [kafka] mjsax commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-04-28 Thread GitBox
mjsax commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-828736200 \cc @vvcephei who was RM for 2.8 for tracking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-8613) Set default grace period to 0

2021-04-28 Thread Israel Ekpo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334984#comment-17334984 ] Israel Ekpo commented on KAFKA-8613: I noticed that the method signature in the KIP had the incorrect

[GitHub] [kafka] hachikuji commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-04-28 Thread GitBox
hachikuji commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r622494008 ## File path: raft/src/main/java/org/apache/kafka/raft/BatchReader.java ## @@ -60,19 +61,21 @@ @Override void close(); -class Batch { +

[GitHub] [kafka] ableegoldman merged pull request #10607: MINOR: bump version to 2.6.3-SNAPSHOT in missing files

2021-04-28 Thread GitBox
ableegoldman merged pull request #10607: URL: https://github.com/apache/kafka/pull/10607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman opened a new pull request #10607: MINOR: bump version to 2.6.3-SNAPSHOT in missing files

2021-04-28 Thread GitBox
ableegoldman opened a new pull request #10607: URL: https://github.com/apache/kafka/pull/10607 I was just editing something on the release process wiki and noticed that under the "Cut Branch" section, which it says to skip for bugfix releases, there's actually a list of files that it then

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-28 Thread GitBox
kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r622606093 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogSegmentMetadataTransform.java ## @@ -0,0

[jira] [Resolved] (KAFKA-12417) streams module should use `testRuntimeClasspath` instead of `testRuntime` configuration

2021-04-28 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović resolved KAFKA-12417. Resolution: Done Resolving as done (commit is merged into trunk). > streams

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-28 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622456807 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -984,19 +1003,26 @@ class LogCleanerTest { def distinctValuesBySegment =

[GitHub] [kafka] hachikuji commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-04-28 Thread GitBox
hachikuji commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-828703078 @tombentley Thanks for the updates. I made a few small changes in this patch: https://github.com/hachikuji/kafka/commit/27ba937cc7b7da230ccc4f0c8220f680c4a542fe. The main

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622472215 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private

[GitHub] [kafka] jsancio commented on pull request #10278: KAFKA-10526: leader fsync deferral on write

2021-04-28 Thread GitBox
jsancio commented on pull request #10278: URL: https://github.com/apache/kafka/pull/10278#issuecomment-828720442 @vamossagar12 Can you add a description to the PR? It is helpful when reviewing this PR to know what strategy you are using to manage the flush offset and log flush. -- This

[jira] [Commented] (KAFKA-8613) Set default grace period to 0

2021-04-28 Thread Israel Ekpo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335015#comment-17335015 ] Israel Ekpo commented on KAFKA-8613: I have the initial changes (without the Unit tests yet) here

[GitHub] [kafka] dielhennr closed pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-28 Thread GitBox
dielhennr closed pull request #10480: URL: https://github.com/apache/kafka/pull/10480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (KAFKA-12727) Flaky test ListConsumerGroupTest.testListConsumerGroupsWithStates

2021-04-28 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12727: -- Summary: Flaky test ListConsumerGroupTest.testListConsumerGroupsWithStates Key: KAFKA-12727 URL: https://issues.apache.org/jira/browse/KAFKA-12727

[GitHub] [kafka] dejan2609 opened a new pull request #10606: KAFKA-12728: [Work In Progress] gradle version upgrade: 6.8 -->> 7.0

2021-04-28 Thread GitBox
dejan2609 opened a new pull request #10606: URL: https://github.com/apache/kafka/pull/10606 **_JIRA ticket:_** https://issues.apache.org/jira/browse/KAFKA-12728 **_Related pull requests:_** - #10203 - #10466 Note: we will wait for a Gradle 7.0.1 patch ◀️ -- This

[GitHub] [kafka] ableegoldman commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
ableegoldman commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622474244 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private

[GitHub] [kafka] ableegoldman merged pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-28 Thread GitBox
ableegoldman merged pull request #10573: URL: https://github.com/apache/kafka/pull/10573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman commented on pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-28 Thread GitBox
ableegoldman commented on pull request #10573: URL: https://github.com/apache/kafka/pull/10573#issuecomment-828752351 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-04-28 Thread GitBox
jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r622425656 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -1335,6 +1313,57 @@ public void

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-28 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622456807 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -984,19 +1003,26 @@ class LogCleanerTest { def distinctValuesBySegment =

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-04-28 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334937#comment-17334937 ] A. Sophie Blee-Goldman commented on KAFKA-9295: --- It's failing on {noformat}

[jira] [Updated] (KAFKA-12724) Add 2.8.0 to system tests and streams upgrade tests

2021-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12724: Component/s: system tests streams > Add 2.8.0 to system tests and

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2021-04-28 Thread GitBox
jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r622505823 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -1267,6 +1266,64 @@ class PlaintextConsumerTest extends

[jira] [Updated] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

2021-04-28 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-10800: --- Description: When the state machine attempts to create a snapshot

[GitHub] [kafka] wcarlson5 removed a comment on pull request #10603: WIP: handle missing sink topics in a separate way

2021-04-28 Thread GitBox
wcarlson5 removed a comment on pull request #10603: URL: https://github.com/apache/kafka/pull/10603#issuecomment-828525217 @ableegoldman @rodesai @cadonna as a rough improvement what do you think? I don't think that we need to get this perfect right now but I think that any

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-28 Thread GitBox
kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r621909054 ## File path: raft/src/main/java/org/apache/kafka/raft/metadata/AbstractApiMessageSerde.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-12728) Update Gradle version: 6.8 -->> 7.0

2021-04-28 Thread Jira
Dejan Stojadinović created KAFKA-12728: -- Summary: Update Gradle version: 6.8 -->> 7.0 Key: KAFKA-12728 URL: https://issues.apache.org/jira/browse/KAFKA-12728 Project: Kafka Issue Type:

[GitHub] [kafka] jsancio commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-28 Thread GitBox
jsancio commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622455380 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -67,6 +74,30 @@ protected LeaderState( }

[GitHub] [kafka] ableegoldman commented on a change in pull request #10597: KAFKA-5876: Apply StreamsNotStartedException for Interactive Queries

2021-04-28 Thread GitBox
ableegoldman commented on a change in pull request #10597: URL: https://github.com/apache/kafka/pull/10597#discussion_r622464617 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -344,7 +345,7 @@ private boolean isRunningOrRebalancing() {

[GitHub] [kafka] jsancio commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-28 Thread GitBox
jsancio commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r622489394 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -67,6 +74,30 @@ protected LeaderState( }

[GitHub] [kafka] ableegoldman commented on pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-28 Thread GitBox
ableegoldman commented on pull request #10573: URL: https://github.com/apache/kafka/pull/10573#issuecomment-828751235 Tons of flaky test failures, all unrelated. Mostly Connect and Raft, a few Streams tests that are known to be flaky which I left some thoughts on the ticket for. Going to

[GitHub] [kafka] junrao commented on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-04-28 Thread GitBox
junrao commented on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-828795518 I think the upgrade case is similar---it's rare and transient. So, we could choose to have a simpler and less optimized way for handling it. I am not sure if we trigger metadata

[GitHub] [kafka] dengziming commented on pull request #10598: MINOR: rename wrong topic id variable name and description

2021-04-28 Thread GitBox
dengziming commented on pull request #10598: URL: https://github.com/apache/kafka/pull/10598#issuecomment-828185212 > @dengziming nice improvement. LGTM > > BTW, line#203 (https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/ConsoleConsumer.scala#L203) has

[GitHub] [kafka] dajac commented on a change in pull request #10599: KAFKA-12716; Add `Admin` API to abort transactions

2021-04-28 Thread GitBox
dajac commented on a change in pull request #10599: URL: https://github.com/apache/kafka/pull/10599#discussion_r621881429 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionResult.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a change in pull request #10599: KAFKA-12716; Add `Admin` API to abort transactions

2021-04-28 Thread GitBox
dajac commented on a change in pull request #10599: URL: https://github.com/apache/kafka/pull/10599#discussion_r621882118 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionSpec.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] showuon commented on pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

2021-04-28 Thread GitBox
showuon commented on pull request #10547: URL: https://github.com/apache/kafka/pull/10547#issuecomment-828180085 Failed tests are all un-related. (Not in MirrorMakerIntegrationTest) ``` Build / JDK 11 and Scala 2.13 /

[GitHub] [kafka] vitojeng commented on a change in pull request #10597: KAFKA-5876: Apply StreamsNotStartedException for Interactive Queries

2021-04-28 Thread GitBox
vitojeng commented on a change in pull request #10597: URL: https://github.com/apache/kafka/pull/10597#discussion_r621901521 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -344,7 +345,7 @@ private boolean isRunningOrRebalancing() {

[GitHub] [kafka] tombentley commented on pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion

2021-04-28 Thread GitBox
tombentley commented on pull request #10023: URL: https://github.com/apache/kafka/pull/10023#issuecomment-828376561 @hachikuji any chance you could review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon edited a comment on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon edited a comment on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-828440406 @ableegoldman , thanks for your great comments! If there's a best reviewer contest, I'd definitely vote for you! :) I've replied your `getUnassignedPartitions` comments.

[GitHub] [kafka] kamalcph opened a new pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-04-28 Thread GitBox
kamalcph opened a new pull request #10602: URL: https://github.com/apache/kafka/pull/10602 * Ran `./gradlew streams:testAll` to verify the streams upgrade test. * Ran individual system test in my local setup. ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] kamalcph commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-04-28 Thread GitBox
kamalcph commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r622198249 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -0,0 +1,299 @@ +/* + * Licensed

[GitHub] [kafka] kamalcph commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-04-28 Thread GitBox
kamalcph commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-828471522 @chia7712 @mjsax @ijuma Ping for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[jira] [Updated] (KAFKA-12724) Add 2.8.0 to system tests and streams upgrade tests

2021-04-28 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-12724: - Description: Kafka v2.8.0 is released. We should add this version to the system

[jira] [Created] (KAFKA-12724) Add 2.8.0 to system tests and streams upgrade tests

2021-04-28 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-12724: Summary: Add 2.8.0 to system tests and streams upgrade tests Key: KAFKA-12724 URL: https://issues.apache.org/jira/browse/KAFKA-12724 Project: Kafka

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622064430 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-828440406 @ableegoldman , thanks for your great comments! If there's a best reviewer contest, I'd definitely vote for you! :) I've replied the `getUnassignedPartitions` comments. Please

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622040343 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622210601 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] guozhangwang merged pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-28 Thread GitBox
guozhangwang merged pull request #10462: URL: https://github.com/apache/kafka/pull/10462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Assigned] (KAFKA-7572) Producer should not send requests with negative partition id

2021-04-28 Thread Wenhao Ji (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenhao Ji reassigned KAFKA-7572: Assignee: Wenhao Ji > Producer should not send requests with negative partition id >

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622707404 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -163,127 +159,179 @@ private boolean

[jira] [Commented] (KAFKA-12718) SessionWindows are closed too early

2021-04-28 Thread Bernardo Yusti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335118#comment-17335118 ] Bernardo Yusti commented on KAFKA-12718: Hi [~mjsax] , I would like to help out with this

[jira] [Updated] (KAFKA-12729) controller leader keep disconnected and block the cluster

2021-04-28 Thread luws (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luws updated KAFKA-12729: - Attachment: image-2021-04-29-11-35-52-191.png > controller leader keep disconnected and block the cluster >

[jira] [Updated] (KAFKA-12729) controller leader keep disconnected and block the cluster

2021-04-28 Thread luws (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luws updated KAFKA-12729: - Description: kafka version. 2.12-2.1.1 after zk flash disconnected  then broker6 become the controller leader

[jira] [Updated] (KAFKA-12729) controller leader keep disconnected and block the cluster

2021-04-28 Thread luws (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luws updated KAFKA-12729: - Attachment: image-2021-04-29-11-35-26-994.png > controller leader keep disconnected and block the cluster >

[jira] [Updated] (KAFKA-12729) controller leader keep disconnected and block the cluster

2021-04-28 Thread luws (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luws updated KAFKA-12729: - Attachment: image-2021-04-29-11-35-41-393.png > controller leader keep disconnected and block the cluster >

[jira] [Updated] (KAFKA-12729) controller leader keep disconnected and block the cluster

2021-04-28 Thread luws (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luws updated KAFKA-12729: - Description: kafka version. 2.12-2.1.1 after zk flash disconnected  then broker6 become the controller leader

[GitHub] [kafka] ableegoldman opened a new pull request #10608: MINOR: clean up some remaining locking stuff in StateDirectory

2021-04-28 Thread GitBox
ableegoldman opened a new pull request #10608: URL: https://github.com/apache/kafka/pull/10608 Minor followup to https://github.com/apache/kafka/pull/10342 that I noticed while working on the NamedTopology stuff. Cleans up a few things: 1. We no longer need locking for the global

[GitHub] [kafka] ableegoldman commented on a change in pull request #10608: MINOR: clean up some remaining locking stuff in StateDirectory

2021-04-28 Thread GitBox
ableegoldman commented on a change in pull request #10608: URL: https://github.com/apache/kafka/pull/10608#discussion_r622718411 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java ## @@ -315,7 +314,7 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #10608: MINOR: clean up some remaining locking stuff in StateDirectory

2021-04-28 Thread GitBox
ableegoldman commented on a change in pull request #10608: URL: https://github.com/apache/kafka/pull/10608#discussion_r622718411 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java ## @@ -315,7 +314,7 @@ public void

[GitHub] [kafka] ableegoldman commented on pull request #10608: MINOR: clean up some remaining locking stuff in StateDirectory

2021-04-28 Thread GitBox
ableegoldman commented on pull request #10608: URL: https://github.com/apache/kafka/pull/10608#issuecomment-828927542 call for review any of @wcarlson5 @lct45 @cadonna @guozhangwang @mjsax @vvcephei @rodesai -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622670757 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on pull request #10598: MINOR: rename wrong topic id variable name and description

2021-04-28 Thread GitBox
showuon commented on pull request #10598: URL: https://github.com/apache/kafka/pull/10598#issuecomment-828879776 @chia7712 , I've updated my github profile. It's `show...@gmail.com`. Haha~ -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

2021-04-28 Thread GitBox
showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r622705781 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -163,127 +159,179 @@ private boolean

[jira] [Updated] (KAFKA-12729) controller leader keep disconnected and block the cluster

2021-04-28 Thread luws (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luws updated KAFKA-12729: - Attachment: image-2021-04-29-11-33-24-303.png > controller leader keep disconnected and block the cluster >

[jira] [Updated] (KAFKA-12729) controller leader keep disconnected and block the cluster

2021-04-28 Thread luws (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luws updated KAFKA-12729: - Attachment: image-2021-04-29-11-33-53-048.png > controller leader keep disconnected and block the cluster >

[jira] [Updated] (KAFKA-12729) controller leader keep disconnected and block the cluster

2021-04-28 Thread luws (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luws updated KAFKA-12729: - Attachment: image-2021-04-29-11-34-18-654.png > controller leader keep disconnected and block the cluster >

  1   2   >