[PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
showuon opened a new pull request, #15077: URL: https://github.com/apache/kafka/pull/15077 Following @dajac 's finding in https://github.com/apache/kafka/pull/15063, I found we also create new RemoteLogManager in ReplicaManagerTest, but didn't close them. While investigating Replica

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
showuon commented on PR #15077: URL: https://github.com/apache/kafka/pull/15077#issuecomment-1870075510 @dajac @jolshan @satishd , call for review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1436885274 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2693,6 +2693,9 @@ class ReplicaManagerTest { } else { assertTrue(stray0.isInst

Re: [PR] MINOR: Upgrade Zstd-jni to 1.5.5-11 [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on PR #14798: URL: https://github.com/apache/kafka/pull/14798#issuecomment-1870137596 @ijuma may I ask another review since I changed to a newer version since your last approval. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] KAFKA-16047: Leverage the fenceProducers timeout in the InitProducerId [kafka]

2023-12-27 Thread via GitHub
akaltsikis opened a new pull request, #15078: URL: https://github.com/apache/kafka/pull/15078 KAFKA-16047: Leverage the fenceProducers timeout in the InitProducerId This is expected to respect the timeout that fenceProducers have, in the InitProducerId request. ### Committe

[jira] [Commented] (KAFKA-16047) Source connector with EOS enabled have some InitProducerId requests timing out, effectively failing all the tasks & the whole connector

2023-12-27 Thread Angelos Kaltsikis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800731#comment-17800731 ] Angelos Kaltsikis commented on KAFKA-16047: --- Hey [~gharris1727], here is the M

Re: [PR] MINOR: New year code clean up - misc [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on PR #15071: URL: https://github.com/apache/kafka/pull/15071#issuecomment-1870147486 @ijuma requesting your review on this cleanup as well please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: New year code cleanup - include final keyword [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on code in PR #15072: URL: https://github.com/apache/kafka/pull/15072#discussion_r1436914220 ## clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java: ## @@ -479,7 +479,7 @@ private static class NodeConnectionState { private f

Re: [PR] MINOR: New year code cleanup - include final keyword [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on PR #15072: URL: https://github.com/apache/kafka/pull/15072#issuecomment-1870156605 Checkstyle doesn't have a rule [1] available to enforce that fields which are not changing are marked as final. Hence, I am not changing anything in the checkstyle here in this PR.

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
showuon commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1436972102 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2693,6 +2693,9 @@ class ReplicaManagerTest { } else { assertTrue(stray0.isInstance

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
satishd commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1436993064 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4020,6 +4031,7 @@ class ReplicaManagerTest { doneLatch.countDown() } finally {

Re: [PR] MINOR: New year code cleanup - include final keyword [kafka]

2023-12-27 Thread via GitHub
vamossagar12 commented on PR #15072: URL: https://github.com/apache/kafka/pull/15072#issuecomment-1870244078 Thanks @divijvaidya , I think Ismael's point is correct. From what I recall, the streams final rule also expects the method arguements etc to be final as well (apart from local varia

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
showuon commented on PR #15077: URL: https://github.com/apache/kafka/pull/15077#issuecomment-1870263212 @satishd , I've closed all the instances in finally block quietly in this commit: https://github.com/apache/kafka/pull/15077/commits/dd913a8668cf773a51403e482cc704b44cb0e8a1 . Thanks.

[jira] [Created] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-16052: Summary: OOM in Kafka test suite Key: KAFKA-16052 URL: https://issues.apache.org/jira/browse/KAFKA-16052 Project: Kafka Issue Type: Bug Affects Versions:

[jira] [Created] (KAFKA-16053) Fix leaked Default DirectoryService

2023-12-27 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-16053: Summary: Fix leaked Default DirectoryService Key: KAFKA-16053 URL: https://issues.apache.org/jira/browse/KAFKA-16053 Project: Kafka Issue Type: Sub-task

[PR] KAFKA-16053: Fix leaks of KDC server in tests [kafka]

2023-12-27 Thread via GitHub
divijvaidya opened a new pull request, #15079: URL: https://github.com/apache/kafka/pull/15079 # Problem We are facing OOM while running test suite for Apache Kafka as discussed in https://lists.apache.org/thread/d5js0xpsrsvhgjb10mbzo9cwsy8087x4 # Changes This JIRA fixes ~2

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1437022630 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2704,28 +2710,30 @@ class ReplicaManagerTest { time = time, scheduler = time

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
showuon commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1437024347 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2704,28 +2710,30 @@ class ReplicaManagerTest { time = time, scheduler = time.sch

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
showuon commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1437026129 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2704,28 +2710,30 @@ class ReplicaManagerTest { time = time, scheduler = time.sch

[jira] [Updated] (KAFKA-16053) Fix leaked Default DirectoryService

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16053: - Description: Heap dump hinted towards a leaked DefaultDirectoryService while running :core:test

[jira] [Updated] (KAFKA-16053) Fix leaked Default DirectoryService

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16053: - Attachment: Screenshot 2023-12-27 at 13.18.33.png > Fix leaked Default DirectoryService > --

Re: [PR] KAFKA-16053: Fix leaks of KDC server in tests [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on PR #15079: URL: https://github.com/apache/kafka/pull/15079#issuecomment-1870288475 @dajac @ableegoldman please review. This is not the root cause of our recent OOM errors but is a contributor to it. (cc: @stanislavkozlovski as a potential backport to 3.7) --

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-27 at 14.04.52.png > OOM in Kafka test suite > --

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800764#comment-17800764 ] Divij Vaidya commented on KAFKA-16052: -- The tests are still running but as of now t

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
divijvaidya commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1437034332 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2704,28 +2710,30 @@ class ReplicaManagerTest { time = time, scheduler = time

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-27 at 14.22.21.png > OOM in Kafka test suite > --

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Description: Our test suite is failing with frequent OOM. Discussion in the mailing list is her

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Description: Our test suite is failing with frequent OOM. Discussion in the mailing list is her

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Description: Our test suite is failing with frequent OOM. Discussion in the mailing list is her

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Description: Our test suite is failing with frequent OOM. Discussion in the mailing list is her

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Description: *Problem* Our test suite is failing with frequent OOM. Discussion in the mailing li

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-27 at 14.45.20.png > OOM in Kafka test suite > --

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800770#comment-17800770 ] Divij Vaidya commented on KAFKA-16052: -- We have a org.mockito.internal.verification

[jira] [Created] (KAFKA-16054) Sudden 100% CPU on a broker

2023-12-27 Thread Oleksandr Shulgin (Jira)
Oleksandr Shulgin created KAFKA-16054: - Summary: Sudden 100% CPU on a broker Key: KAFKA-16054 URL: https://issues.apache.org/jira/browse/KAFKA-16054 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800772#comment-17800772 ] Divij Vaidya commented on KAFKA-16052: -- Let's try to find the test which was runnin

[jira] [Updated] (KAFKA-16054) Sudden 100% CPU on a broker

2023-12-27 Thread Oleksandr Shulgin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Shulgin updated KAFKA-16054: -- Description: We have observed now for the 3rd time in production the issue where a Kaf

[jira] [Updated] (KAFKA-16054) Sudden 100% CPU on a broker

2023-12-27 Thread Oleksandr Shulgin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Shulgin updated KAFKA-16054: -- Description: We have observed now for the 3rd time in production the issue where a Kaf

[jira] [Updated] (KAFKA-16054) Sudden 100% CPU on a broker

2023-12-27 Thread Oleksandr Shulgin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Shulgin updated KAFKA-16054: -- Description: We have observed now for the 3rd time in production the issue where a Kaf

[jira] [Updated] (KAFKA-16054) Sudden 100% CPU on a broker

2023-12-27 Thread Oleksandr Shulgin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Shulgin updated KAFKA-16054: -- Description: We have observed now for the 3rd time in production the issue where a Kaf

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800772#comment-17800772 ] Divij Vaidya edited comment on KAFKA-16052 at 12/27/23 2:01 PM: --

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-27 at 15.31.09.png > OOM in Kafka test suite > --

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800788#comment-17800788 ] Divij Vaidya commented on KAFKA-16052: -- ok, I might have found the offending test.

[jira] [Updated] (KAFKA-15904) Downgrade tests are failing with directory.id 

2023-12-27 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano updated KAFKA-15904: -- Fix Version/s: 3.7.0 (was: 3.8.0) > Downgrade tests are failing

[jira] [Resolved] (KAFKA-15904) Downgrade tests are failing with directory.id 

2023-12-27 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano resolved KAFKA-15904. --- Resolution: Fixed This was merged into trunk a month ago, long before the 3.7 branch

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800797#comment-17800797 ] Divij Vaidya commented on KAFKA-16052: -- I am now running a single threaded test exe

[PR] KAFKA-16051: Fixed deadlock in StandaloneHerder [kafka]

2023-12-27 Thread via GitHub
developster opened a new pull request, #15080: URL: https://github.com/apache/kafka/pull/15080 *Description of the change* Changed StandaloneHerder to always synchronize on itself before invoking any methods on MemoryConfigBackingStore. This helped the situation as the order of acquiring

[jira] [Commented] (KAFKA-16051) Deadlock on connector initialization

2023-12-27 Thread Octavian Ciubotaru (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800814#comment-17800814 ] Octavian Ciubotaru commented on KAFKA-16051: Hi [~gharris1727] , Thank you f

[jira] [Commented] (KAFKA-16051) Deadlock on connector initialization

2023-12-27 Thread Octavian Ciubotaru (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800815#comment-17800815 ] Octavian Ciubotaru commented on KAFKA-16051: I do not have the privileges to

[jira] [Updated] (KAFKA-15495) Partition truncated when the only ISR member restarts with an empty disk

2023-12-27 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-15495: -- Summary: Partition truncated when the only ISR member restarts with an empty disk (was: KRaft

[jira] [Updated] (KAFKA-15495) Partition truncated when the only ISR member restarts with an empty disk

2023-12-27 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-15495: -- Affects Version/s: 3.6.1 3.5.2 3.5.0

[jira] [Updated] (KAFKA-15495) Partition truncated when the only ISR member restarts with an empty disk

2023-12-27 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-15495: -- Affects Version/s: 3.2.1 3.1.2 3.0.2

[jira] [Updated] (KAFKA-15495) Partition truncated when the only ISR member restarts with an empty disk

2023-12-27 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-15495: -- Affects Version/s: 2.7.2 2.6.3 3.1.0

[jira] [Updated] (KAFKA-15495) Partition truncated when the only ISR member restarts with an empty disk

2023-12-27 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-15495: -- Affects Version/s: 2.2.1 2.3.0 2.1.1

[jira] [Updated] (KAFKA-15495) Partition truncated when the only ISR member restarts with an empty disk

2023-12-27 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-15495: -- Description: Assume a topic-partition has just a single leader replica in the ISR. Assume ne

[jira] [Assigned] (KAFKA-16044) Throttling using Topic Partition Quota

2023-12-27 Thread Afshin Moazami (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Afshin Moazami reassigned KAFKA-16044: -- Assignee: Afshin Moazami > Throttling using Topic Partition Quota >

[jira] [Assigned] (KAFKA-16043) Add Quota configuration for topics

2023-12-27 Thread Afshin Moazami (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Afshin Moazami reassigned KAFKA-16043: -- Assignee: Afshin Moazami > Add Quota configuration for topics > -

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-27 Thread via GitHub
sciclon2 commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1437137364 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws Exception {

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-27 Thread via GitHub
sciclon2 commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1437137364 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws Exception {

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-27 at 17.44.09.png > OOM in Kafka test suite > --

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800828#comment-17800828 ] Divij Vaidya commented on KAFKA-16052: -- Digging into the new heap dump after disabl

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
jolshan commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1437157116 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2639,59 +2639,65 @@ class ReplicaManagerTest { time = time, scheduler = time.sch

[jira] [Commented] (KAFKA-15147) Measure pending and outstanding Remote Segment operations

2023-12-27 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800832#comment-17800832 ] Christo Lolov commented on KAFKA-15147: --- Heya [~enether]! I believe all the work t

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

2023-12-27 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800833#comment-17800833 ] Christo Lolov commented on KAFKA-14132: --- Heya [~enether], thanks for checking in o

[jira] [Commented] (KAFKA-15495) Partition truncated when the only ISR member restarts with an empty disk

2023-12-27 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800845#comment-17800845 ] Ron Dagostino commented on KAFKA-15495: --- Thanks, [~jsancio]. I've updated the tit

Re: [PR] KAFKA-16047: Leverage the fenceProducers timeout in the InitProducerId [kafka]

2023-12-27 Thread via GitHub
gharris1727 commented on code in PR #15078: URL: https://github.com/apache/kafka/pull/15078#discussion_r1437200184 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java: ## @@ -82,9 +86,10 @@ InitProducerIdRequest.Builder buildSingleRequest

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800851#comment-17800851 ] Justine Olshan commented on KAFKA-16052: Thanks Divij for the digging. These tes

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800852#comment-17800852 ] Justine Olshan commented on KAFKA-16052: I can also take a look at the heap dump

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800853#comment-17800853 ] Divij Vaidya commented on KAFKA-16052: -- Yes Justine, that is my current line of tho

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800855#comment-17800855 ] Justine Olshan commented on KAFKA-16052: Doing a quick scan at the InterceptedIn

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800855#comment-17800855 ] Justine Olshan edited comment on KAFKA-16052 at 12/27/23 7:19 PM:

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800855#comment-17800855 ] Justine Olshan edited comment on KAFKA-16052 at 12/27/23 7:20 PM:

[jira] [Assigned] (KAFKA-16045) ZkMigrationIntegrationTest.testMigrateTopicDeletion flaky

2023-12-27 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-16045: Assignee: David Arthur > ZkMigrationIntegrationTest.testMigrateTopicDeletion flaky >

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800865#comment-17800865 ] Justine Olshan commented on KAFKA-16052: Taking a look at removing the mock as w

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800874#comment-17800874 ] Ismael Juma commented on KAFKA-16052: - Have you tried clearing the mocks during tear

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800875#comment-17800875 ] Ismael Juma commented on KAFKA-16052: - It can be done via Mockito.framework().clearI

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800877#comment-17800877 ] Justine Olshan commented on KAFKA-16052: Ah – good point [~ijuma]. I will look i

[PR] WIP -- clear mocks in AbstractCoordinatorConcurrencyTest [kafka]

2023-12-27 Thread via GitHub
jolshan opened a new pull request, #15081: URL: https://github.com/apache/kafka/pull/15081 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800880#comment-17800880 ] Justine Olshan commented on KAFKA-16052: There are only four tests in the group

[PR] KAFKA-16045 Fix flaky testMigrateTopicDeletions [kafka]

2023-12-27 Thread via GitHub
mumrah opened a new pull request, #15082: URL: https://github.com/apache/kafka/pull/15082 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Duplicate method; The QuotaUtils one is used. [kafka]

2023-12-27 Thread via GitHub
jolshan commented on PR #15066: URL: https://github.com/apache/kafka/pull/15066#issuecomment-1870661247 @afshing -- can you link the commit that moved the code in your description? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Created] (KAFKA-16055) Thread unsafe use of HashMap stored in QueryableStoreProvider#storeProviders

2023-12-27 Thread Kohei Nozaki (Jira)
Kohei Nozaki created KAFKA-16055: Summary: Thread unsafe use of HashMap stored in QueryableStoreProvider#storeProviders Key: KAFKA-16055 URL: https://issues.apache.org/jira/browse/KAFKA-16055 Project:

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-28 at 00.13.06.png > OOM in Kafka test suite > --

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800892#comment-17800892 ] Divij Vaidya commented on KAFKA-16052: -- I don't think that clearing the mocks is he

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800892#comment-17800892 ] Divij Vaidya edited comment on KAFKA-16052 at 12/27/23 11:19 PM: -

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-28 at 00.18.56.png > OOM in Kafka test suite > --

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800893#comment-17800893 ] Divij Vaidya commented on KAFKA-16052: -- Also, when we look at what is inside the In

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800893#comment-17800893 ] Divij Vaidya edited comment on KAFKA-16052 at 12/27/23 11:23 PM: -

[jira] [Commented] (KAFKA-15997) Ensure fairness in the uniform assignor

2023-12-27 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800900#comment-17800900 ] Ritika Reddy commented on KAFKA-15997: -- Hey, from what I understand you are trying

[jira] [Comment Edited] (KAFKA-15997) Ensure fairness in the uniform assignor

2023-12-27 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800900#comment-17800900 ] Ritika Reddy edited comment on KAFKA-15997 at 12/28/23 1:39 AM: --

[jira] [Commented] (KAFKA-15997) Ensure fairness in the uniform assignor

2023-12-27 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800901#comment-17800901 ] Ritika Reddy commented on KAFKA-15997: -- In case of the first assignment, I have wri

[jira] [Comment Edited] (KAFKA-15997) Ensure fairness in the uniform assignor

2023-12-27 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800900#comment-17800900 ] Ritika Reddy edited comment on KAFKA-15997 at 12/28/23 1:41 AM: --

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800902#comment-17800902 ] Justine Olshan commented on KAFKA-16052: Thanks Divij. This might be a few thing

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800903#comment-17800903 ] Justine Olshan commented on KAFKA-16052: It looks like the method that is actual

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800903#comment-17800903 ] Justine Olshan edited comment on KAFKA-16052 at 12/28/23 2:05 AM:

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800909#comment-17800909 ] Justine Olshan commented on KAFKA-16052: So I realized that every test runs thou

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800909#comment-17800909 ] Justine Olshan edited comment on KAFKA-16052 at 12/28/23 2:35 AM:

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
satishd commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1437341409 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2704,28 +2710,30 @@ class ReplicaManagerTest { time = time, scheduler = time.sch

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-27 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800911#comment-17800911 ] Justine Olshan commented on KAFKA-16052: What do we think about lowering the num

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
satishd commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1437344252 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -167,7 +167,7 @@ class ReplicaManagerTest { .foreach(checkpointFile => assertTrue(File

Re: [PR] MINOR: close leaking threads in replica manager tests [kafka]

2023-12-27 Thread via GitHub
showuon commented on code in PR #15077: URL: https://github.com/apache/kafka/pull/15077#discussion_r1437350213 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2639,59 +2639,65 @@ class ReplicaManagerTest { time = time, scheduler = time.sch

  1   2   >