phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526035266
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
yashmayya merged PR #15499:
URL: https://github.com/apache/kafka/pull/15499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1999010980
Sorry that I missed the ping. Thanks Satish for helping review. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525852213
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/GroupState.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1999553646
> Are you suggesting to find more reviewers for this PR?
Yep, if they have free cycle
Anyway, I will take a look later. Thanks for updating code
--
This is an
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-
[
https://issues.apache.org/jira/browse/KAFKA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16349:
Description:
`ShutdownableThread` calls `Exit.exit()` when the thread's operation throws
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526237310
##
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##
@@ -42,6 +42,32 @@ class KafkaServerTest extends QuorumTestHarness {
chia7712 merged PR #15507:
URL: https://github.com/apache/kafka/pull/15507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1999649048
@ChrisAHolland thanks for contribution. If you have free cycle, please help
us fix the flaky. There are a bunch of tickets about flaky tests :)
--
This is an automated message from
lucasbru merged PR #15537:
URL: https://github.com/apache/kafka/pull/15537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru merged PR #15538:
URL: https://github.com/apache/kafka/pull/15538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526346873
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -911,9 +911,13 @@ void maybeReconcile() {
SortedSet
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-
mumrah commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1526384089
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1369,7 +1384,23 @@ void handleBrokerInControlledShutdown(int brokerId, long
dajac commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526420387
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -970,7 +973,11 @@ void maybeReconcile() {
Jeff Kim created KAFKA-16379:
Summary: add metric to measure time spent in purgatory
Key: KAFKA-16379
URL: https://issues.apache.org/jira/browse/KAFKA-16379
Project: Kafka
Issue Type: Sub-task
dongnuo123 closed pull request #15442: KAFKA-16313: offline group protocol
migration
URL: https://github.com/apache/kafka/pull/15442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongnuo123 opened a new pull request, #15546:
URL: https://github.com/apache/kafka/pull/15546
This patch enables the empty classic groups to upgrade to classic groups and
empty consumer groups to upgrade to consumer groups.
jira: https://issues.apache.org/jira/browse/KAFKA-16313
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526229909
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -116,14 +116,14 @@ public class HeartbeatRequestManager
dajac opened a new pull request, #15545:
URL: https://github.com/apache/kafka/pull/15545
In https://github.com/apache/kafka/pull/15364, we introduced, thoughtfully,
a non-backward compatible record change for the new consumer group protocol. So
it is a good opportunity for cleaning unused
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526268639
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
lucasbru commented on PR #15330:
URL: https://github.com/apache/kafka/pull/15330#issuecomment-1999644666
LGTM, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lucasbru merged PR #15330:
URL: https://github.com/apache/kafka/pull/15330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru merged PR #15539:
URL: https://github.com/apache/kafka/pull/15539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru merged PR #15540:
URL: https://github.com/apache/kafka/pull/15540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526349331
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,25 +530,18 @@ public ConsumerGroupHeartbeatRequestData
johnnychhsu commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1526027063
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -19,82 +19,236 @@ package kafka.admin
import
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525853816
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -0,0 +1,1241 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1999374812
@chia7712
I addressed all your comments. Please, take a look one more time.
> This is the last one and it is good time to give more reviews
Are you suggesting to
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526107034
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -116,14 +116,14 @@ public class HeartbeatRequestManager
apoorvmittal10 closed pull request #15532: KAFKA-16359: Corrected manifest file
for kafka-clients
URL: https://github.com/apache/kafka/pull/15532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac merged PR #15528:
URL: https://github.com/apache/kafka/pull/15528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-15490.
---
Fix Version/s: 3.6.2
Resolution: Fixed
> Invalid path provided to the log failure channel
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525847102
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/CsvUtils.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827431#comment-17827431
]
Luke Chen commented on KAFKA-16372:
---
If that's the case since 0.9.0.0, I would treat it as a document
showuon commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1525901824
##
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##
@@ -42,6 +42,32 @@ class KafkaServerTest extends QuorumTestHarness {
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1525926407
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1524592939
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java:
##
@@ -185,4 +185,18 @@ public interface MembershipManager extends
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1525940513
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -911,9 +911,13 @@ void maybeReconcile() {
SortedSet
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526079968
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
apoorvmittal10 commented on PR #15532:
URL: https://github.com/apache/kafka/pull/15532#issuecomment-1999421797
Re-triggering the build by re-opening the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526177488
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
soarez commented on PR #15335:
URL: https://github.com/apache/kafka/pull/15335#issuecomment-1999531297
@OmniaGM can you resolve the conflicts for this PR? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525874456
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -0,0 +1,1241 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1525912448
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,25 +530,18 @@ public ConsumerGroupHeartbeatRequestData
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1525955340
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
swuferhong opened a new pull request, #15544:
URL: https://github.com/apache/kafka/pull/15544
This pr is aims to fix the wrong highWatermark assert equals condition in
`HighwatermarkPersistenceTest`. The highWatermark need lower than LEO, but in
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526193892
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -116,14 +116,14 @@ public class HeartbeatRequestManager
nizhikov commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-1999413290
Hello @OmniaGM
I think this PR still too big for one change.
Can we split it?
We can start with LogConfiguration:
```
/** * Log Configuration
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-
ableegoldman merged PR #15508:
URL: https://github.com/apache/kafka/pull/15508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525841048
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -155,4 +157,17 @@ public static Set minus(Set set, T...toRemove) {
return res;
}
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525842667
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/CsvUtils.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1999556511
Hello @mimaison , @jolshan
Do you have time to review this PR?
We are ready to move `ConsumerGroupCommand` to tools - all tests moved to
java, I've checked system tests and
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525896298
##
bin/kafka-consumer-groups.sh:
##
@@ -14,4 +14,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-exec
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526096328
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1525935835
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1525952640
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
yashmayya commented on PR #15499:
URL: https://github.com/apache/kafka/pull/15499#issuecomment-1999406741
Test failures are unrelated, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526869018
##
core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala:
##
@@ -72,6 +72,8 @@ class AddPartitionsToTxnManagerTest {
private val
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1526958117
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##
@@ -177,6 +178,86 @@ class TransactionMarkerChannelManagerTest
mumrah commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526390858
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-277204
I will take a look for some unassigned tickets! Do you have any in
particular?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1526795838
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526861466
##
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java:
##
@@ -392,7 +393,8 @@ public enum Errors {
UNKNOWN_CONTROLLER_ID(116, "This controller ID
dongnuo123 opened a new pull request, #15547:
URL: https://github.com/apache/kafka/pull/15547
This pr is based on #14675 where enabling kraft in
testConsumptionWithBrokerFailures showed flakiness. We'll need to find a way to
fix it.
### Committer Checklist (excluded from commit
dongnuo123 commented on code in PR #14675:
URL: https://github.com/apache/kafka/pull/14675#discussion_r1526926450
##
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##
@@ -77,8 +83,9 @@ class ConsumerBounceTest extends AbstractConsumerTest with
Logging {
stan-is-hate closed pull request #12402: remove min_cluster_size() calls
URL: https://github.com/apache/kafka/pull/12402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527026867
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -173,9 +173,9 @@ class LogValidatorTest {
assertEquals(now,
stan-is-hate closed pull request #12120: Add mini test
URL: https://github.com/apache/kafka/pull/12120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #15486:
URL: https://github.com/apache/kafka/pull/15486#issuecomment-2000460307
I was thinking about this change and am wondering if we should bump all the
transactional APIs to make it clear this error can be returned. Let me get back
to you @sjhajharia -- I will
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526864714
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -3523,6 +3524,129 @@ public void
mjsax commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1526870886
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527029580
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -82,6 +82,13 @@ class ListOffsetsIntegrationTest extends
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1526810331
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1526811182
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
ijuma commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1526810480
##
gradle/dependencies.gradle:
##
@@ -100,10 +100,10 @@ versions += [
commonsCli: "1.4",
commonsValidator: "1.7",
dropwizardMetrics: "4.1.12.1",
- gradle:
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526868437
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -975,12 +978,13 @@ class ReplicaManager(val config: KafkaConfig,
/**
*
- * @param
[
https://issues.apache.org/jira/browse/KAFKA-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongnuo Lyu updated KAFKA-15756:
Description:
There is one flaky test left, we need to figure out how to reduce the flakiness.
artemlivshits commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1526939166
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##
@@ -177,6 +178,86 @@ class
chia7712 commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-2001031718
> Do you have any in particular?
how about https://issues.apache.org/jira/browse/KAFKA-16376 ? or check the
following link:
chia7712 commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1527016313
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2718,7 +2719,7 @@ public void testDropCommitOnBatchExpiry()
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1527018572
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527041931
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -209,7 +209,7 @@ private static FilterResult filterTo(TopicPartition
partition,
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526605829
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -976,6 +974,10 @@ void maybeReconcile() {
}
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526685631
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2256,6 +2384,26 @@ void handleFailure(Throwable throwable) {
[
https://issues.apache.org/jira/browse/KAFKA-16375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827587#comment-17827587
]
Kirk True commented on KAFKA-16375:
---
[~lianetm]—do we want this in 3.8?
> Fix logic for discarding
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526594353
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
Johnny Hsu created KAFKA-16380:
--
Summary: Rename the shallowOffsetOfMaxTimestamp in LogSegment
Key: KAFKA-16380
URL: https://issues.apache.org/jira/browse/KAFKA-16380
Project: Kafka
Issue Type:
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526696015
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -639,6 +639,25 @@ public void testDescribe(String quorum) throws
[
https://issues.apache.org/jira/browse/KAFKA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827594#comment-17827594
]
Kirk True commented on KAFKA-16190:
---
Thank you [~phong260702] for your help on this! :)
> Member
johnnychhsu commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-237478
thanks @junrao @chia7712 @showuon for the suggestions and comments!
I have updated the following:
- rename the ValidationResult.shallowOffsetOfMaxTimestamp to
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526595161
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526609264
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -29,6 +29,8 @@
import
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526609264
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -29,6 +29,8 @@
import
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526587744
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -82,6 +82,13 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness
lucasbru merged PR #15401:
URL: https://github.com/apache/kafka/pull/15401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1 - 100 of 125 matches
Mail list logo
