chia7712 commented on PR #15512:
URL: https://github.com/apache/kafka/pull/15512#issuecomment-2006002354
I have pushed a commit to rebase code and fix conflict. will merge it if
there is no connected failure.
--
This is an automated message from the Apache Git Service.
To respond to the
chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2005884703
I have rebase the PR to trigger QA again, and I will merge it if no related
failed tests.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sjhajharia commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1529793846
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -3523,6 +3524,128 @@ public void
sjhajharia commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1529794514
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3040,6 +3048,7 @@ class ReplicaManagerTest {
transactionalId = transactionalId,
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1529919190
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -219,15 +225,16 @@ class BrokerLifecycleManagerTest {
Collections.emptyMap(),
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng reassigned KAFKA-16385:
-
Assignee: Kuan Po Tseng
> Segment is rolled before segment.ms or segment.bytes
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828227#comment-17828227
]
Kuan Po Tseng commented on KAFKA-16385:
---
I'm willing to take over this ! Many thanks !
> Segment
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-2006292277
Thanks for the review @junrao. Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2006340058
@chia7712 PR merged with the latest trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16385:
--
Description:
Steps to reproduce:
0. Startup a broker with `log.retention.check.interval.ms=1000` to
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828247#comment-17828247
]
Divij Vaidya commented on KAFKA-16385:
--
[~showuon] I must be missing something here but the current
Luke Chen created KAFKA-16385:
-
Summary: Segment is rolled before segment.ms or segment.bytes
breached
Key: KAFKA-16385
URL: https://issues.apache.org/jira/browse/KAFKA-16385
Project: Kafka
dajac commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1529919197
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -598,15 +600,16 @@ public List
describeGroups(
*/
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1529927411
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -197,11 +197,17 @@ class BrokerLifecycleManagerTest {
result
}
- def
[
https://issues.apache.org/jira/browse/KAFKA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianbin Chen resolved KAFKA-16378.
--
Resolution: Fixed
> Under tiered storage, deleting local logs does not free disk space
>
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2006320092
@nizhikov sorry for late review. could you rebase code and I will take a
look later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16385:
--
Affects Version/s: 3.5.1
> Segment is rolled before segment.ms or segment.bytes breached
>
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16385:
--
Description:
Steps to reproduce:
0. Startup a broker with `log.retention.check.interval.ms=1000` to
[
https://issues.apache.org/jira/browse/KAFKA-13361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828245#comment-17828245
]
Mickael Maison commented on KAFKA-13361:
Dongjin had written a KIP
fvaleri commented on code in PR #13516:
URL: https://github.com/apache/kafka/pull/13516#discussion_r1530075375
##
examples/src/main/java/kafka/examples/ExactlyOnceMessageProcessor.java:
##
@@ -81,111 +88,115 @@ public ExactlyOnceMessageProcessor(final String
inputTopic,
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828250#comment-17828250
]
Jorge Esteban Quilcate Otoya commented on KAFKA-10409:
--
[~dhawalkapil] thanks for
fvaleri commented on code in PR #13516:
URL: https://github.com/apache/kafka/pull/13516#discussion_r1530075375
##
examples/src/main/java/kafka/examples/ExactlyOnceMessageProcessor.java:
##
@@ -81,111 +88,115 @@ public ExactlyOnceMessageProcessor(final String
inputTopic,
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828251#comment-17828251
]
Luke Chen commented on KAFKA-16385:
---
[~divijvaidya], I agree with you in Kafka, we don't have clear
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828281#comment-17828281
]
Chia-Ping Tsai commented on KAFKA-16385:
It seems to me the scenario is about " should we roll
dajac commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1530443218
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -619,6 +622,22 @@ ConsumerGroup getOrMaybeCreateConsumerGroup(
[
https://issues.apache.org/jira/browse/KAFKA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828365#comment-17828365
]
Igor Soarez commented on KAFKA-13906:
-
That is correct [~showuon]
> Invalid replica state
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530718724
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -0,0 +1,1240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16385:
--
Description:
Steps to reproduce:
0. Startup a broker with `log.retention.check.interval.ms=1000` to
chia7712 commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530643112
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -664,7 +664,7 @@ object TestUtils extends Logging {
* until the leader is elected and metadata is
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530807872
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -0,0 +1,1240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-16386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Quah updated KAFKA-16386:
--
Description:
KAFKA-14402
PoAn Yang created KAFKA-16387:
-
Summary: Allow kafka-metadata-shell to read a running server
metadata
Key: KAFKA-16387
URL: https://issues.apache.org/jira/browse/KAFKA-16387
Project: Kafka
wernerdv commented on PR #15558:
URL: https://github.com/apache/kafka/pull/15558#issuecomment-2007211486
Hello, @mimaison
Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongnuo123 commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1530392822
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -598,15 +600,16 @@ public List
describeGroups(
*/
chia7712 commented on code in PR #15552:
URL: https://github.com/apache/kafka/pull/15552#discussion_r1530699013
##
docs/ops.html:
##
@@ -3797,14 +3797,6 @@ Modifying certain dynamic configurations on the standalone KRaft
controller
- ZooKeeper to KRaft
Migration
[
https://issues.apache.org/jira/browse/KAFKA-16153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828444#comment-17828444
]
Chia-Ping Tsai commented on KAFKA-16153:
IIRC, only production-ready can be acceptable. we don't
Sean Quah created KAFKA-16386:
-
Summary: NETWORK_EXCEPTIONs from transaction verification are not
translated
Key: KAFKA-16386
URL: https://issues.apache.org/jira/browse/KAFKA-16386
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828319#comment-17828319
]
Luke Chen edited comment on KAFKA-16385 at 3/19/24 12:58 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828319#comment-17828319
]
Luke Chen edited comment on KAFKA-16385 at 3/19/24 12:57 PM:
-
chia7712 merged PR #15476:
URL: https://github.com/apache/kafka/pull/15476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2007459578
@johnnychhsu thanks for this contribution! please complete the follow-up:
1. 3.6 branch has many conflicts so please file a PR for branch 3.6
2. update KIP-734 for the offset of
[
https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16341:
---
Fix Version/s: 3.8.0
3.7.1
> Fix un-compressed records
>
[
https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828407#comment-17828407
]
Chia-Ping Tsai commented on KAFKA-16341:
pending for backporting to 3.6
> Fix un-compressed
Chia-Ping Tsai created KAFKA-16388:
--
Summary: add production-ready test of 3.3 - 3.6 release to
MetadataVersionTest.testFromVersionString
Key: KAFKA-16388
URL: https://issues.apache.org/jira/browse/KAFKA-16388
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1530741929
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3040,6 +3048,7 @@ class ReplicaManagerTest {
transactionalId = transactionalId,
dajac commented on code in PR #15533:
URL: https://github.com/apache/kafka/pull/15533#discussion_r1530481757
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1190,10 +1190,11 @@ private
CoordinatorResult consumerGr
squah-confluent opened a new pull request, #15559:
URL: https://github.com/apache/kafka/pull/15559
KIP-890 Part 1 introduced verification of transactions with the transaction
coordinator on the `Produce` and `TxnOffsetCommit` paths. This introduced the
possibility of new errors when
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828319#comment-17828319
]
Luke Chen commented on KAFKA-16385:
---
[~divijvaidya], I was thinking the use case you mentioned:
_I
dongnuo123 commented on code in PR #15546:
URL: https://github.com/apache/kafka/pull/15546#discussion_r1530392822
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -598,15 +600,16 @@ public List
describeGroups(
*/
dajac commented on code in PR #15533:
URL: https://github.com/apache/kafka/pull/15533#discussion_r1530489017
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -1904,16 +2000,7 @@ public void testReconciliationProcess() {
dajac commented on PR #15533:
URL: https://github.com/apache/kafka/pull/15533#issuecomment-200748
@jeffkbkim @jolshan @lianetm Thanks for your comments. I addressed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dajac commented on PR #15533:
URL: https://github.com/apache/kafka/pull/15533#issuecomment-2007332396
> They are the only three optional fields, right?
There are actually mandatory in full requests.
> Also, my understanding is that there are cases where we don't set
lianetm commented on PR #15533:
URL: https://github.com/apache/kafka/pull/15533#issuecomment-2007369164
LGTM, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2007409274
JDK 11 gets cancel. It should be fine as it gets test in previous QA
I run the failed tests on my local:
```sh
./gradlew cleanTest :tools:test --tests
brandboat commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1530599572
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java:
##
@@ -1037,7 +1038,7 @@ public void
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530708691
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -664,7 +664,7 @@ object TestUtils extends Logging {
* until the leader is elected and metadata is
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530832758
##
checkstyle/import-control.xml:
##
@@ -330,6 +330,7 @@
+
Review Comment:
This not required.
Sorry for that, should
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2007792800
@chia7712 I addressed all your comments. Please, take a look one more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16389:
--
Attachment: KAFKA-16389.patch
> consumer_test.py’s test_valid_assignment fails with new consumer
>
[
https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828501#comment-17828501
]
keith.paulson commented on KAFKA-8154:
--
[~tmancill] What is involved with getting this fix
dajac merged PR #15533:
URL: https://github.com/apache/kafka/pull/15533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16367.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Full ConsumerGroupHeartbeat response must be
[
https://issues.apache.org/jira/browse/KAFKA-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter updated KAFKA-16384:
--
Issue Type: Improvement (was: Bug)
> KRaft controller number recommendation
>
[
https://issues.apache.org/jira/browse/KAFKA-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter updated KAFKA-16384:
--
Affects Version/s: 3.7.0
> KRaft controller number recommendation
> --
>
Kirk True created KAFKA-16389:
-
Summary: consumer_test.py’s test_valid_assignment fails with new
consumer
Key: KAFKA-16389
URL: https://issues.apache.org/jira/browse/KAFKA-16389
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16389:
--
Description:
The following error is reported when running the {{test_valid_assignment}} test
from
[
https://issues.apache.org/jira/browse/KAFKA-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter updated KAFKA-16384:
--
Component/s: (was: controller)
> KRaft controller number recommendation
>
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530815007
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/CsvUtils.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner reassigned KAFKA-14482:
-
Assignee: Ismael Juma (was: Dmitry Werner)
> Move LogLoader to storage module
>
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner reassigned KAFKA-14482:
-
Assignee: Ismael Juma (was: Dmitry Werner)
> Move LogLoader to storage module
>
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner reassigned KAFKA-14482:
-
Assignee: Dmitry Werner (was: Ismael Juma)
> Move LogLoader to storage module
>
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828518#comment-17828518
]
Dmitry Werner commented on KAFKA-14482:
---
[~ijuma] Thank you for the explanation.
> Move LogLoader
[
https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16389:
--
Description:
The following error is reported when running the {{test_valid_assignment}} test
from
[
https://issues.apache.org/jira/browse/KAFKA-16388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828542#comment-17828542
]
Kuan Po Tseng commented on KAFKA-16388:
---
I'm willing to take over this~ Thanks !
> add
[
https://issues.apache.org/jira/browse/KAFKA-16388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng reassigned KAFKA-16388:
-
Assignee: Kuan Po Tseng
> add production-ready test of 3.3 - 3.6 release to
>
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828514#comment-17828514
]
Ismael Juma commented on KAFKA-14482:
-
[~javakillah] This ticket can't be done until the dependency
nizhikov commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-2007922919
Hello @OmniaGM
Are you be able to split this PR in several to simplify review and merge?
My jira https://issues.apache.org/jira/browse/KAFKA-14588 blocked by
migration
dongnuo123 commented on code in PR #14675:
URL: https://github.com/apache/kafka/pull/14675#discussion_r1531051374
##
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##
@@ -89,6 +96,8 @@ class ConsumerBounceTest extends AbstractConsumerTest with
Logging {
[
https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16389:
--
Description:
The following error is reported when running the {{test_valid_assignment}} test
from
[
https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828538#comment-17828538
]
Kirk True commented on KAFKA-16389:
---
I've attached a patch which _appears_ to address the issue in the
CalvinConfluent commented on code in PR #15541:
URL: https://github.com/apache/kafka/pull/15541#discussion_r1531252560
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -270,14 +270,7 @@ public void run() {
while (!forceClose &&
CalvinConfluent commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2008340124
@kirktrue Move the test to the Sender test because less mock is needed to
repro the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Philip Nee created KAFKA-16390:
--
Summary: consumer_bench_test.py failed using AsyncKafkaConsumer
Key: KAFKA-16390
URL: https://issues.apache.org/jira/browse/KAFKA-16390
Project: Kafka
Issue
sjhajharia commented on PR #15486:
URL: https://github.com/apache/kafka/pull/15486#issuecomment-2008655935
On that note @jolshan , do we any more open questions to address or we are
good to go with this PR? Or are we in flux for
PoAn Yang created KAFKA-16391:
-
Summary: Cleanup .lock file after server is down
Key: KAFKA-16391
URL: https://issues.apache.org/jira/browse/KAFKA-16391
Project: Kafka
Issue Type: Improvement
gaurav-narula closed pull request #15527: MINOR: fix javadoc warnings
URL: https://github.com/apache/kafka/pull/15527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gaoran10 commented on code in PR #13516:
URL: https://github.com/apache/kafka/pull/13516#discussion_r1531455051
##
examples/src/main/java/kafka/examples/ExactlyOnceMessageProcessor.java:
##
@@ -81,111 +88,115 @@ public ExactlyOnceMessageProcessor(final String
inputTopic,
[
https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828594#comment-17828594
]
Chia-Ping Tsai commented on KAFKA-16385:
{quote}
One potential way to improve this is to use the
[
https://issues.apache.org/jira/browse/KAFKA-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828597#comment-17828597
]
PoAn Yang commented on KAFKA-16391:
---
Yes, I think so. From source code, it only close file channel.
github-actions[bot] commented on PR #15027:
URL: https://github.com/apache/kafka/pull/15027#issuecomment-2008611925
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008700834
the failed test pass on my local:
```sh
./gradlew cleanTest :streams:test --tests
HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores
jolshan commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-200839
Looks pretty reasonable to me. I also want to get a +1 from Kirk to make
sure he agrees it makes sense.
I will also let the tests run.
--
This is an automated message from the
chia7712 commented on PR #15512:
URL: https://github.com/apache/kafka/pull/15512#issuecomment-2008579703
the failed tests pass on my local:
```sh
./gradlew cleanTest :streams:test --tests
HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores
chia7712 merged PR #15512:
URL: https://github.com/apache/kafka/pull/15512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
omkreddy commented on PR #15481:
URL: https://github.com/apache/kafka/pull/15481#issuecomment-2008684718
@showuon Can we merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12187.
Fix Version/s: 3.8.0
Resolution: Fixed
> replace assertTrue(obj instanceof X) by
[
https://issues.apache.org/jira/browse/KAFKA-12217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12217.
Resolution: Fixed
> Apply the new features of Junit 5.8 to code base
>
[
https://issues.apache.org/jira/browse/KAFKA-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828595#comment-17828595
]
Chia-Ping Tsai commented on KAFKA-16391:
[~yangpoan] pardon me, are those .lock files existent
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530813020
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -144,18 +145,18 @@ private void
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1530918656
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -254,33 +261,38 @@ class BrokerLifecycleManagerTest {
@Test
def
1 - 100 of 123 matches
Mail list logo
