ckmbks commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-2026804291
Who can reslove that test failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Rashi-Confluent opened a new pull request, #15623:
URL: https://github.com/apache/kafka/pull/15623
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
nizhikov commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2026879663
Tests looks OK for me.
I've checked locally and `kafka.server.ReplicaManagerTest` fails with the
same error in trunk.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-16068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
johndoe reassigned KAFKA-16068:
---
Assignee: johndoe
> Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin
> scan
showuon commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1544263703
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -289,13 +289,17 @@ class BrokerMetadataPublisher(
try {
// Start log manag
chia7712 commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1544283639
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -189,14 +190,47 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarn
chia7712 commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2026944004
```
./gradlew cleanTest :metadata:test --tests
QuorumControllerMetricsIntegrationTest.testClosingQuorumControllerClosesMetrics
--tests QuorumControllerTest.testFenceMultipleBrokers :c
FrankYang0529 opened a new pull request, #15624:
URL: https://github.com/apache/kafka/pull/15624
Add unit tests for `FileLock`.
Ref: https://github.com/apache/kafka/pull/15568#pullrequestreview-1950676267
### Committer Checklist (excluded from commit message)
- [ ] Verify des
showuon commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1544295936
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File],
}
}
+ def recoverAbandonedFutureLogs(broker
showuon commented on code in PR #15521:
URL: https://github.com/apache/kafka/pull/15521#discussion_r1544325278
##
server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:
##
@@ -310,6 +301,62 @@ void testOnCompletion() throws Exception {
}
}
+
chia7712 commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2027038241
the flaky of `ReplicaManagerTest` is related to #15373
see https://github.com/apache/kafka/pull/15373/files#r1544335647
--
This is an automated message from the Apache Git Service.
T
chia7712 commented on code in PR #15373:
URL: https://github.com/apache/kafka/pull/15373#discussion_r1544335647
##
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##
@@ -88,7 +101,7 @@ public class ClusterImageTest {
setId(2).
setEp
[
https://issues.apache.org/jira/browse/KAFKA-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16447:
---
Summary: Fix failed ReplicaManagerTest (was: Fix flaky ReplicaManagerTest)
> Fix failed Rep
Chia-Ping Tsai created KAFKA-16447:
--
Summary: Fix flaky ReplicaManagerTest
Key: KAFKA-16447
URL: https://issues.apache.org/jira/browse/KAFKA-16447
Project: Kafka
Issue Type: Bug
chia7712 commented on code in PR #15373:
URL: https://github.com/apache/kafka/pull/15373#discussion_r1544339792
##
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##
@@ -88,7 +101,7 @@ public class ClusterImageTest {
setId(2).
setEp
[
https://issues.apache.org/jira/browse/KAFKA-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832165#comment-17832165
]
PoAn Yang commented on KAFKA-16447:
---
Hi [~chia7712], I would like to take the issue. M
[
https://issues.apache.org/jira/browse/KAFKA-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832167#comment-17832167
]
Chia-Ping Tsai commented on KAFKA-16447:
{quote}
I would like to take the issue.
wernerdv commented on code in PR #15558:
URL: https://github.com/apache/kafka/pull/15558#discussion_r1544364893
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -216,7 +217,10 @@ Set findConsumerGroups()
Collection list
wernerdv commented on code in PR #15558:
URL: https://github.com/apache/kafka/pull/15558#discussion_r1544364748
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java:
##
@@ -320,4 +322,19 @@ static void createCompactedTopic(String topicName, short
par
mimaison commented on code in PR #15558:
URL: https://github.com/apache/kafka/pull/15558#discussion_r1544383751
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -216,7 +217,10 @@ Set findConsumerGroups()
Collection list
wernerdv commented on code in PR #15558:
URL: https://github.com/apache/kafka/pull/15558#discussion_r1544403086
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -216,7 +217,10 @@ Set findConsumerGroups()
Collection list
abhijeetk88 opened a new pull request, #15625:
URL: https://github.com/apache/kafka/pull/15625
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
[
https://issues.apache.org/jira/browse/KAFKA-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16397.
Fix Version/s: 3.8.0
Resolution: Fixed
> Use ByteBufferOutputStream to avoid array
chia7712 merged PR #15589:
URL: https://github.com/apache/kafka/pull/15589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov reassigned KAFKA-16447:
---
Assignee: Nikolay Izhikov
> Fix failed ReplicaManagerTest
> ---
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1544483152
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
th
Damien Gasparina created KAFKA-16448:
Summary: Add Kafka Streams exception handler for exceptions
occuring during processing (KIP-1033)
Key: KAFKA-16448
URL: https://issues.apache.org/jira/browse/KAFKA-16448
[
https://issues.apache.org/jira/browse/KAFKA-16448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Damien Gasparina updated KAFKA-16448:
-
Description: Jira to follow work on KIP: [KIP-1033: Add Kafka Streams
exception handler
mumrah commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1544478846
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2185,9 +2184,155 @@ void handleFailure(Throwable throwable) {
comp
[
https://issues.apache.org/jira/browse/KAFKA-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832210#comment-17832210
]
Chia-Ping Tsai commented on KAFKA-16447:
[~nizhikov] thanks for taking over this
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832226#comment-17832226
]
Johnny Hsu commented on KAFKA-16310:
thanks [~junrao] for pointing this out and shar
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832228#comment-17832228
]
Chia-Ping Tsai commented on KAFKA-16310:
{quote}
I got more context and also fee
gharris1727 closed pull request #15623: Testing the terraform file
URL: https://github.com/apache/kafka/pull/15623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
gharris1727 commented on PR #15623:
URL: https://github.com/apache/kafka/pull/15623#issuecomment-2027405515
@Rashi-Confluent This is probably the wrong upstream 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1544636515
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
ijuma commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2027407574
> AclAuthorizer
We should not move this since it will be deleted as part of ZK removal. I
would focus on moving classes that we don't intend to delete soon.
--
This is an automated
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1544639778
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
th
johnnychhsu commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r154463
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1460,10 +1460,8 @@ class ReplicaManager(val config: KafkaConfig,
warn("Unable to fetch dat
johnnychhsu commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2027410113
@kamalcph just updated, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nizhikov commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2027411004
@ijuma Are you suggesting to move `AclAuthorizer` in this PR? Or it could be
postponed until all dependencies are ready?
--
This is an automated message from the Apache Git Service.
To
johnnychhsu commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1544639805
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
gharris1727 merged PR #15423:
URL: https://github.com/apache/kafka/pull/15423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
nizhikov commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2027422531
@ijuma Please, ignore my last question, I misread your statement :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
jolshan commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2027424479
I don't have further comments. I will restart the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
junrao commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2027526301
> Do we need to revert all of them? the paths we had fixed works well now.
>
> 1. It seems to me adding comments for both "recover" and "follower" cases
can remind readers that this
raminqaf commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1544749273
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java:
##
Review Comment:
@gharris1727 Thanks for the fast review! I have addres
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1544749533
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2185,9 +2184,155 @@ void handleFailure(Throwable throwable) {
raminqaf commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1544749545
##
streams/src/main/java/org/apache/kafka/streams/state/internals/JoinSide.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
raminqaf commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1544749545
##
streams/src/main/java/org/apache/kafka/streams/state/internals/JoinSide.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Yusu Gao created KAFKA-16449:
Summary: Kafka Docker run foce formatting with Zookeeper connect
setup and block kafka running
Key: KAFKA-16449
URL: https://issues.apache.org/jira/browse/KAFKA-16449
Project
wernerdv closed pull request #15101: KAFKA-16072: JUnit 5 extension to detect
thread leak
URL: https://github.com/apache/kafka/pull/15101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gharris1727 commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1544787082
##
streams/src/main/java/org/apache/kafka/streams/state/internals/JoinSide.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
gharris1727 commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1544779363
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java:
##
@@ -41,6 +41,7 @@
import java.util.Optional;
import java.util.Set;
i
[
https://issues.apache.org/jira/browse/KAFKA-16434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari updated KAFKA-16434:
Description:
We have two topics : _left-topic[String, LeftRecord]_ and _right-topic[String,
Strin
akatona84 commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1544810115
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,22 +38,32 @@ import org.mockito.Mockito.{mock, when}
import java.uti
kirktrue opened a new pull request, #15626:
URL: https://github.com/apache/kafka/pull/15626
Added a new optional `group_protocol` parameter to the test methods, then
passed that down to the methods involved.
New new consumer only works with 3.7+, so I added a new `@matrix` block with
kirktrue commented on PR #15626:
URL: https://github.com/apache/kafka/pull/15626#issuecomment-2027703629
@lucasbru—here's another system test to review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
[
https://issues.apache.org/jira/browse/KAFKA-16420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16420:
Description:
The Exit class is not thread-safe, and exposes our tests to race conditions and
inco
[
https://issues.apache.org/jira/browse/KAFKA-16420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16420:
Summary: Refactor utils.Exit call-sites to use thread-safe alternative
(was: Add thread-safe alte
Greg Harris created KAFKA-16450:
---
Summary: Add thread-safe alternative to Exit
Key: KAFKA-16450
URL: https://issues.apache.org/jira/browse/KAFKA-16450
Project: Kafka
Issue Type: Task
gharris1727 commented on PR #15601:
URL: https://github.com/apache/kafka/pull/15601#issuecomment-2027729205
This PR looks like it'll have merge conflicts with #15510. Since that is
fixing a bug it should probably have higher priority than this refactor, can
you rebase on top of their change
kirktrue opened a new pull request, #15627:
URL: https://github.com/apache/kafka/pull/15627
Migrated the following tests for the new consumer:
- `test_fencing_static_consumer`
- `test_static_consumer_bounce`
- `test_static_consumer_persisted_after_rejoin`
### Committer Che
kirktrue commented on PR #15627:
URL: https://github.com/apache/kafka/pull/15627#issuecomment-2027764974
@lucasbru—can you take a look at this system test? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
kirktrue opened a new pull request, #15628:
URL: https://github.com/apache/kafka/pull/15628
Added a new optional `group_protocol` parameter to the test methods, then
passed that down to the `setup_consumer` method.
Unfortunately, because the new consumer can only be used with the new
gharris1727 commented on code in PR #15520:
URL: https://github.com/apache/kafka/pull/15520#discussion_r1544876870
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -329,6 +329,11 @@ public static String LOGGER_CLUSTER_KEY(Stri
kirktrue commented on PR #15628:
URL: https://github.com/apache/kafka/pull/15628#issuecomment-2027781431
@lucasbru—here's another system test migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kirktrue opened a new pull request, #15629:
URL: https://github.com/apache/kafka/pull/15629
Added a new optional `group_protocol` parameter to the test methods, then
passed that down to the `setup_consumer` method.
Unfortunately, because the new consumer can only be used with the new
kirktrue commented on PR #15629:
URL: https://github.com/apache/kafka/pull/15629#issuecomment-2027785610
@lucasbru—and another system test migration to review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
gharris1727 commented on PR #15520:
URL: https://github.com/apache/kafka/pull/15520#issuecomment-2027797163
Test failures appear unrelated, and the connect runtime tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
gharris1727 merged PR #15520:
URL: https://github.com/apache/kafka/pull/15520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
Justine Olshan created KAFKA-16451:
--
Summary: testDeltaFollower tests failing in ReplicaManager
Key: KAFKA-16451
URL: https://issues.apache.org/jira/browse/KAFKA-16451
Project: Kafka
Issue T
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832325#comment-17832325
]
Greg Harris commented on KAFKA-16223:
-
PR 1/3 merged, leaving this open.
> Replace
jolshan commented on code in PR #15373:
URL: https://github.com/apache/kafka/pull/15373#discussion_r1544929534
##
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##
@@ -88,7 +101,7 @@ public class ClusterImageTest {
setId(2).
setEpo
[
https://issues.apache.org/jira/browse/KAFKA-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832330#comment-17832330
]
Justine Olshan commented on KAFKA-16451:
closing as it is a duplicate of
https:
[
https://issues.apache.org/jira/browse/KAFKA-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-16451.
Resolution: Duplicate
> testDeltaFollower tests failing in ReplicaManager
> --
jolshan commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2027801197
Some failing tests are due to
https://issues.apache.org/jira/browse/KAFKA-16447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ahuang98 commented on code in PR #15373:
URL: https://github.com/apache/kafka/pull/15373#discussion_r1544930494
##
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##
@@ -88,7 +101,7 @@ public class ClusterImageTest {
setId(2).
setEp
[
https://issues.apache.org/jira/browse/KAFKA-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832332#comment-17832332
]
Alyssa Huang commented on KAFKA-16447:
--
[~yangpoan] go for it, sorry for breaking t
ahuang98 commented on code in PR #15373:
URL: https://github.com/apache/kafka/pull/15373#discussion_r1544932474
##
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##
@@ -88,7 +101,7 @@ public class ClusterImageTest {
setId(2).
setEp
[
https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832334#comment-17832334
]
Greg Harris commented on KAFKA-16344:
-
[~janardhanag] I don't understand what you me
jolshan merged PR #15541:
URL: https://github.com/apache/kafka/pull/15541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1545058512
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
[
https://issues.apache.org/jira/browse/KAFKA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832368#comment-17832368
]
Johnny Hsu commented on KAFKA-13906:
hey [~soarez] [~showuon] I would like to work o
[
https://issues.apache.org/jira/browse/KAFKA-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu reassigned KAFKA-13906:
--
Assignee: Johnny Hsu
> Invalid replica state transition
>
>
chia7712 merged PR #15572:
URL: https://github.com/apache/kafka/pull/15572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15572:
URL: https://github.com/apache/kafka/pull/15572#issuecomment-2027901054
@nizhikov thanks for this migration!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1545074098
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
th
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2027904152
> I think both are important. First, it's important to be able to derive
the same thing consistently from the leader and the follower log. This affects
things like the time indexing ent
FrankYang0529 opened a new pull request, #15630:
URL: https://github.com/apache/kafka/pull/15630
Ref: https://github.com/apache/kafka/pull/15373/files#r1544335647
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test cove
kamalcph commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2027930309
> Instead of getting the number from yammer metrics, we can check the metric
counter and see if it increased
For my understanding, Could you please explain how this patch fixed the
[
https://issues.apache.org/jira/browse/KAFKA-16447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832394#comment-17832394
]
Luke Chen commented on KAFKA-16447:
---
PR: [https://github.com/apache/kafka/pull/15630]
FrankYang0529 commented on PR #15630:
URL: https://github.com/apache/kafka/pull/15630#issuecomment-2027938143
> @FrankYang0529 , thanks for the fix! Could you add some explanation about
why the test failed and why your change fixes it in the PR description? Thanks.
I udpated the descr
92 matches
Mail list logo
