[jira] [Assigned] (KAFKA-10378) issue when create producer using java

2020-08-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-10378: - Assignee: Luke Chen > issue when create producer using java >

[GitHub] [kafka] guozhangwang commented on a change in pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-08-10 Thread GitBox
guozhangwang commented on a change in pull request #8549: URL: https://github.com/apache/kafka/pull/8549#discussion_r468327920 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -1366,6 +1366,10 @@ public void

[GitHub] [kafka] stanislavkozlovski commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

2020-08-10 Thread GitBox
stanislavkozlovski commented on pull request #9155: URL: https://github.com/apache/kafka/pull/9155#issuecomment-671714884 I just updated the PR description to mention that both tests were using Jackson `2.10.5`. Apologies for the misleading, I must have got confused by the numerous tests

[GitHub] [kafka] showuon commented on pull request #9158: MINOR: Update the quickstart link in readme

2020-08-10 Thread GitBox
showuon commented on pull request #9158: URL: https://github.com/apache/kafka/pull/9158#issuecomment-671702480 @rhauch , could you review this small PR to update quickstart link? Thanks. This is an automated message from the

[GitHub] [kafka] showuon opened a new pull request #9158: MINOR: Update the quickstart link in readme

2020-08-10 Thread GitBox
showuon opened a new pull request #9158: URL: https://github.com/apache/kafka/pull/9158 After the new website launched, the quickstart link also changed. Update the quickstart link in readme.md. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-10 Thread GitBox
ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r468218540 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImpl.java ## @@ -0,0 +1,148 @@ +/* + *

[GitHub] [kafka] apovzner commented on pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-10 Thread GitBox
apovzner commented on pull request #8768: URL: https://github.com/apache/kafka/pull/8768#issuecomment-671684203 @rajinisivaram Thanks for your review. I updated this PR to expose 'connection-accept-rate' metrics, addressed the remaining comments, and the test should also be fixed.

[jira] [Commented] (KAFKA-10381) Add broker to a cluster not rebalancing partitions

2020-08-10 Thread Yogesh BG (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175147#comment-17175147 ] Yogesh BG commented on KAFKA-10381: --- One more observation is that when i restart the leader node for

[GitHub] [kafka] hachikuji commented on a change in pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

2020-08-10 Thread GitBox
hachikuji commented on a change in pull request #9112: URL: https://github.com/apache/kafka/pull/9112#discussion_r468270027 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -229,7 +205,7 @@ class MetadataCacheTest {

[jira] [Commented] (KAFKA-10223) ReplicaNotAvailableException must be retriable to handle reassignments

2020-08-10 Thread Dongjoon Hyun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175094#comment-17175094 ] Dongjoon Hyun commented on KAFKA-10223: --- Thank you for the confirmation, [~rsivaram]. >

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468111300 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureCache.scala ## @@ -82,18 +110,54 @@ object FinalizedFeatureCache extends Logging {

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-10 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r468149236 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1215,64 @@ default AlterClientQuotasResult

[GitHub] [kafka] vvcephei commented on pull request #9141: MINOR: Improve checks for CogroupedStreamAggregateBuilder

2020-08-10 Thread GitBox
vvcephei commented on pull request #9141: URL: https://github.com/apache/kafka/pull/9141#issuecomment-671622789 Verified the last commit only changed whitespace before merging. This is an automated message from the Apache

[GitHub] [kafka] vvcephei merged pull request #9141: MINOR: Improve checks for CogroupedStreamAggregateBuilder

2020-08-10 Thread GitBox
vvcephei merged pull request #9141: URL: https://github.com/apache/kafka/pull/9141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

2020-08-10 Thread GitBox
ijuma commented on pull request #9155: URL: https://github.com/apache/kafka/pull/9155#issuecomment-671617848 Merged to master and cherry-picked to 2.6, 2.5 and 2.4 branches. This is an automated message from the Apache Git

[GitHub] [kafka] vvcephei commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-10 Thread GitBox
vvcephei commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r468214782 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SlidingWindows.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vvcephei commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-10 Thread GitBox
vvcephei commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r468214782 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SlidingWindows.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vvcephei commented on pull request #9141: MINOR: Improve checks for CogroupedStreamAggregateBuilder

2020-08-10 Thread GitBox
vvcephei commented on pull request #9141: URL: https://github.com/apache/kafka/pull/9141#issuecomment-671609419 All the tests were green except for the flaky ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]

[GitHub] [kafka] vvcephei commented on a change in pull request #9141: MINOR: Improve checks for CogroupedStreamAggregateBuilder

2020-08-10 Thread GitBox
vvcephei commented on a change in pull request #9141: URL: https://github.com/apache/kafka/pull/9141#discussion_r468206463 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -85,68 +160,38 @@

[jira] [Commented] (KAFKA-10383) KTable Join on Foreign key is opinionated

2020-08-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175074#comment-17175074 ] John Roesler commented on KAFKA-10383: -- Thanks for the report, [~marcolotz]. This seems like a

[GitHub] [kafka] skaundinya15 commented on pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer

2020-08-10 Thread GitBox
skaundinya15 commented on pull request #9143: URL: https://github.com/apache/kafka/pull/9143#issuecomment-671599091 I re-ran the system tests for `streams_broker_compatibility_test` here:

[jira] [Updated] (KAFKA-10383) KTable Join on Foreign key is opinionated

2020-08-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10383: - Component/s: (was: core) streams > KTable Join on Foreign key is

[GitHub] [kafka] guozhangwang merged pull request #9153: MINOR: Fix state transition diagram for stream threads

2020-08-10 Thread GitBox
guozhangwang merged pull request #9153: URL: https://github.com/apache/kafka/pull/9153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-08-10 Thread GitBox
apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r468175154 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -70,37 +80,38 @@ class ConnectionQuotasTest {

[GitHub] [kafka] ijuma merged pull request #9155: MINOR: Ensure a single version of scala-library is used

2020-08-10 Thread GitBox
ijuma merged pull request #9155: URL: https://github.com/apache/kafka/pull/9155 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

2020-08-10 Thread GitBox
ijuma commented on pull request #9155: URL: https://github.com/apache/kafka/pull/9155#issuecomment-671562430 2 builds passed, 1 flaky test failure for Java 8. This is an automated message from the Apache Git Service. To

[jira] [Created] (KAFKA-10384) Separate converters from generated messages

2020-08-10 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-10384: Summary: Separate converters from generated messages Key: KAFKA-10384 URL: https://issues.apache.org/jira/browse/KAFKA-10384 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10383) KTable Join on Foreign key is opinionated

2020-08-10 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Lotz updated KAFKA-10383: --- Description: *Status Quo:* The current implementation of [KIP-213 

[jira] [Updated] (KAFKA-10383) KTable Join on Foreign key is opinionated

2020-08-10 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Lotz updated KAFKA-10383: --- Description: *Status Quo:* The current implementation of [KIP-213 

[jira] [Updated] (KAFKA-10383) KTable Join on Foreign key is opinionated

2020-08-10 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Lotz updated KAFKA-10383: --- Description: *Status Quo:* The current implementation of [KIP-213 

[jira] [Created] (KAFKA-10383) KTable Join on Foreign key is opinionated

2020-08-10 Thread Marco Lotz (Jira)
Marco Lotz created KAFKA-10383: -- Summary: KTable Join on Foreign key is opinionated Key: KAFKA-10383 URL: https://issues.apache.org/jira/browse/KAFKA-10383 Project: Kafka Issue Type:

[GitHub] [kafka] cadonna commented on a change in pull request #9153: MINOR: Fix state transition diagram for stream threads

2020-08-10 Thread GitBox
cadonna commented on a change in pull request #9153: URL: https://github.com/apache/kafka/pull/9153#discussion_r468121273 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -93,7 +95,7 @@ * |

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468111785 ## File path: core/src/main/scala/kafka/server/BrokerFeatures.scala ## @@ -0,0 +1,192 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468111300 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureCache.scala ## @@ -82,18 +110,54 @@ object FinalizedFeatureCache extends Logging {

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468109791 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1647,6 +1865,192 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] ableegoldman commented on a change in pull request #9153: MINOR: Fix state transition diagram for stream threads

2020-08-10 Thread GitBox
ableegoldman commented on a change in pull request #9153: URL: https://github.com/apache/kafka/pull/9153#discussion_r468104424 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -93,7 +95,7 @@ * |

[jira] [Resolved] (KAFKA-9659) Kafka Streams / Consumer configured for static membership fails on "fatal exception: group.instance.id gets fenced"

2020-08-10 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9659. -- Fix Version/s: 2.6.0 Resolution: Fixed > Kafka Streams / Consumer configured for static

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468103224 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1647,6 +1865,192 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-08-10 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-671520491 @chia7712 : I agree mostly with your assessment. For most delayed operations, the checking for the completeness of the operation and the calling of onComplete() don't have to be

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468101982 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -977,14 +1179,30 @@ class KafkaController(val config: KafkaConfig, /**

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468097360 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -266,6 +275,199 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] lct45 opened a new pull request #9157: Update for KIP-450 to handle early records

2020-08-10 Thread GitBox
lct45 opened a new pull request #9157: URL: https://github.com/apache/kafka/pull/9157 Handles records that fall between 0 and the timeDifference that would normally create negative windows. This puts a new record that falls into this range in a window from [0, timeDifference] and creates

[GitHub] [kafka] dajac commented on a change in pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-10 Thread GitBox
dajac commented on a change in pull request #9136: URL: https://github.com/apache/kafka/pull/9136#discussion_r468093788 ## File path: clients/src/main/java/org/apache/kafka/common/config/provider/DirectoryConfigProvider.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] dajac commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

2020-08-10 Thread GitBox
dajac commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r468090360 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java ## @@ -74,7 +77,9 @@ public RequestAndSize parseRequest(ByteBuffer

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-10 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174986#comment-17174986 ] Sophie Blee-Goldman commented on KAFKA-10357: - How are we going to handle

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468089357 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -266,6 +275,199 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] skaundinya15 commented on pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer

2020-08-10 Thread GitBox
skaundinya15 commented on pull request #9143: URL: https://github.com/apache/kafka/pull/9143#issuecomment-671506739 Link for system test run for this branch:

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468085443 ## File path: clients/src/main/resources/common/message/UpdateFeaturesResponse.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r468084269 ## File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] big-andy-coates commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-10 Thread GitBox
big-andy-coates commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-671501927 @mjsax as discussed. Please review. I think this change makes the output from the table filter semantically correct, i.e. we no longer output tombstones for rows

[GitHub] [kafka] hachikuji commented on pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

2020-08-10 Thread GitBox
hachikuji commented on pull request #9112: URL: https://github.com/apache/kafka/pull/9112#issuecomment-671500806 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] skaundinya15 commented on pull request #9142: MINOR: Fix delete_topic for system tests

2020-08-10 Thread GitBox
skaundinya15 commented on pull request #9142: URL: https://github.com/apache/kafka/pull/9142#issuecomment-671498810 Link to system test run from this branch:

[jira] [Created] (KAFKA-10382) MockProducer is not ThreadSafe, ideally it should be as the implementation it mocks is

2020-08-10 Thread Antony Stubbs (Jira)
Antony Stubbs created KAFKA-10382: - Summary: MockProducer is not ThreadSafe, ideally it should be as the implementation it mocks is Key: KAFKA-10382 URL: https://issues.apache.org/jira/browse/KAFKA-10382

[jira] [Commented] (KAFKA-10370) WorkerSinkTask: IllegalStateException cased by consumer.seek(tp, offsets) when (tp, offsets) are supplied by WorkerSinkTaskContext

2020-08-10 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174955#comment-17174955 ] Ning Zhang commented on KAFKA-10370: Hi [~rhauch], when you have a chance, I would like to get your

[GitHub] [kafka] big-andy-coates opened a new pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-10 Thread GitBox
big-andy-coates opened a new pull request #9156: URL: https://github.com/apache/kafka/pull/9156 fixes: [KAFKA-10077](https://issues.apache.org/jira/browse/KAFKA-10077). Enable sending old values on `KTable.filter` call to avoid the filter forwarding tombstones for rows that do not

[jira] [Updated] (KAFKA-10077) Filter downstream of state-store results in spurious tombstones

2020-08-10 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-10077: Summary: Filter downstream of state-store results in spurious tombstones (was: Filter downstream

[jira] [Issue Comment Deleted] (KAFKA-10370) WorkerSinkTask: IllegalStateException cased by consumer.seek(tp, offsets) when (tp, offsets) are supplied by WorkerSinkTaskContext

2020-08-10 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang updated KAFKA-10370: --- Comment: was deleted (was: https://github.com/apache/kafka/pull/9145) > WorkerSinkTask:

[jira] [Updated] (KAFKA-10370) WorkerSinkTask: IllegalStateException cased by consumer.seek(tp, offsets) when (tp, offsets) are supplied by WorkerSinkTaskContext

2020-08-10 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang updated KAFKA-10370: --- Reviewer: Randall Hauch > WorkerSinkTask: IllegalStateException cased by consumer.seek(tp, offsets)

[jira] [Updated] (KAFKA-10370) WorkerSinkTask: IllegalStateException cased by consumer.seek(tp, offsets) when (tp, offsets) are supplied by WorkerSinkTaskContext

2020-08-10 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang updated KAFKA-10370: --- Fix Version/s: (was: 2.6.0) 2.7.0 > WorkerSinkTask: IllegalStateException

[GitHub] [kafka] ijuma commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

2020-08-10 Thread GitBox
ijuma commented on pull request #9155: URL: https://github.com/apache/kafka/pull/9155#issuecomment-671482140 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-10381) Add broker to a cluster not rebalancing partitions

2020-08-10 Thread Yogesh BG (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh BG updated KAFKA-10381: -- Affects Version/s: 2.3.0 > Add broker to a cluster not rebalancing partitions >

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-08-10 Thread GitBox
junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r467279790 ## File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-10381) Add broker to a cluster not rebalancing partitions

2020-08-10 Thread Yogesh BG (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh BG updated KAFKA-10381: -- Priority: Major (was: Trivial) > Add broker to a cluster not rebalancing partitions >

[jira] [Created] (KAFKA-10381) Add broker to a cluster not rebalancing partitions

2020-08-10 Thread Yogesh BG (Jira)
Yogesh BG created KAFKA-10381: - Summary: Add broker to a cluster not rebalancing partitions Key: KAFKA-10381 URL: https://issues.apache.org/jira/browse/KAFKA-10381 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10381) Add broker to a cluster not rebalancing partitions

2020-08-10 Thread Yogesh BG (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh BG updated KAFKA-10381: -- Priority: Trivial (was: Major) > Add broker to a cluster not rebalancing partitions >

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-10 Thread GitBox
rajinisivaram commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r467848781 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ScramMechanism.java ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] abbccdda commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

2020-08-10 Thread GitBox
abbccdda commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r468005080 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -88,15 +88,17 @@ class SocketServer(val config: KafkaConfig, private val

[GitHub] [kafka] stanislavkozlovski commented on pull request #9155: MINOR: Ensure a single version of scala-library is used

2020-08-10 Thread GitBox
stanislavkozlovski commented on pull request #9155: URL: https://github.com/apache/kafka/pull/9155#issuecomment-671429610 In 2.4 we use `def defaultScala212Version = '2.12.10'` yet it gets updated to `2.12.12` due to the jackson-module-scala library using the 2.12.12 version of

[GitHub] [kafka] stanislavkozlovski opened a new pull request #9155: MINOR: Ensure a single version of scala-library is used

2020-08-10 Thread GitBox
stanislavkozlovski opened a new pull request #9155: URL: https://github.com/apache/kafka/pull/9155 This patch ensures we use a force resolution strategy for the scala-library dependency I've tested this locally and saw a difference in the output: With the change (using 2.4 and

[GitHub] [kafka] tombentley commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-10 Thread GitBox
tombentley commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-671424344 @mimaison done. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] tombentley commented on a change in pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-10 Thread GitBox
tombentley commented on a change in pull request #9136: URL: https://github.com/apache/kafka/pull/9136#discussion_r467984879 ## File path: clients/src/main/java/org/apache/kafka/common/config/provider/DirectoryConfigProvider.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the

[GitHub] [kafka] abbccdda commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

2020-08-10 Thread GitBox
abbccdda commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467975757 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java ## @@ -37,11 +37,22 @@ public RequestHeader(Struct struct, short

[GitHub] [kafka] abbccdda commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

2020-08-10 Thread GitBox
abbccdda commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r467975394 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java ## @@ -69,4 +69,11 @@ * Returns the

[GitHub] [kafka] vvcephei commented on a change in pull request #9073: MINOR: add task ':streams:testAll'

2020-08-10 Thread GitBox
vvcephei commented on a change in pull request #9073: URL: https://github.com/apache/kafka/pull/9073#discussion_r467975526 ## File path: build.gradle ## @@ -1266,6 +1266,27 @@ project(':streams') { if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }

[GitHub] [kafka] astubbs opened a new pull request #9154: Threadsafe mock producer

2020-08-10 Thread GitBox
astubbs opened a new pull request #9154: URL: https://github.com/apache/kafka/pull/9154 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-08-10 Thread GitBox
chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-671337544 @guozhangwang @abbccdda More comments? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cadonna commented on pull request #9153: MINOR: Fix state transition diagram for stream threads

2020-08-10 Thread GitBox
cadonna commented on pull request #9153: URL: https://github.com/apache/kafka/pull/9153#issuecomment-671328193 Call for review: @guozhangwang @ableegoldman This is an automated message from the Apache Git Service. To

[GitHub] [kafka] cadonna commented on a change in pull request #9153: MINOR: Fix state transition diagram for stream threads

2020-08-10 Thread GitBox
cadonna commented on a change in pull request #9153: URL: https://github.com/apache/kafka/pull/9153#discussion_r467872227 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -80,11 +80,13 @@ * |

[GitHub] [kafka] cadonna commented on a change in pull request #9153: MINOR: Fix state transition diagram for stream threads

2020-08-10 Thread GitBox
cadonna commented on a change in pull request #9153: URL: https://github.com/apache/kafka/pull/9153#discussion_r467871730 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -93,7 +95,7 @@ * |

[GitHub] [kafka] cadonna opened a new pull request #9153: MINOR: Fix state transition diagram for stream threads

2020-08-10 Thread GitBox
cadonna opened a new pull request #9153: URL: https://github.com/apache/kafka/pull/9153 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174279#comment-17174279 ] Bruno Cadonna commented on KAFKA-10357: --- I have a couple of questions regarding wild idea 1): 1)

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #9150: KAFKA-9839; Broker should accept control requests with newer broker epoch

2020-08-10 Thread GitBox
viktorsomogyi edited a comment on pull request #9150: URL: https://github.com/apache/kafka/pull/9150#issuecomment-671323114 2.3: https://github.com/apache/kafka/pull/9151 2.4: https://github.com/apache/kafka/pull/9152

[GitHub] [kafka] viktorsomogyi commented on pull request #9150: KAFKA-9839; Broker should accept control requests with newer broker epoch

2020-08-10 Thread GitBox
viktorsomogyi commented on pull request #9150: URL: https://github.com/apache/kafka/pull/9150#issuecomment-671323114 2.3: https://github.com/apache/kafka/pull/9151 2.4: https://github.com/apache/kafka/pull/9151 This is an

[GitHub] [kafka] viktorsomogyi opened a new pull request #9152: KAFKA-9839; Broker should accept control requests with newer broker epoch

2020-08-10 Thread GitBox
viktorsomogyi opened a new pull request #9152: URL: https://github.com/apache/kafka/pull/9152 A broker throws IllegalStateException if the broker epoch in the LeaderAndIsr/UpdateMetadataRequest/StopReplicaRequest is larger than its current broker epoch. However, there is no guarantee that

[GitHub] [kafka] viktorsomogyi opened a new pull request #9151: KAFKA-9839; Broker should accept control requests with newer broker epoch

2020-08-10 Thread GitBox
viktorsomogyi opened a new pull request #9151: URL: https://github.com/apache/kafka/pull/9151 A broker throws IllegalStateException if the broker epoch in the LeaderAndIsr/UpdateMetadataRequest/StopReplicaRequest is larger than its current broker epoch. However, there is no guarantee that

[jira] [Commented] (KAFKA-10223) ReplicaNotAvailableException must be retriable to handle reassignments

2020-08-10 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174223#comment-17174223 ] Rajini Sivaram commented on KAFKA-10223: [~dongjoon] This is not a 2.6.0 issue,

[jira] [Commented] (KAFKA-10377) Delete Useless Code

2020-08-10 Thread Bingkun.ji (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174202#comment-17174202 ] Bingkun.ji commented on KAFKA-10377: [~dongjin]  [~tombentley]    Thank you for your reply >

[jira] [Resolved] (KAFKA-10377) Delete Useless Code

2020-08-10 Thread Bingkun.ji (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bingkun.ji resolved KAFKA-10377. Resolution: Not A Problem > Delete Useless Code > --- > > Key:

[jira] [Commented] (KAFKA-10377) Delete Useless Code

2020-08-10 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174183#comment-17174183 ] Dongjin Lee commented on KAFKA-10377: - [~tombentley] is right. Those codes are not useless.

[jira] [Assigned] (KAFKA-8362) LogCleaner gets stuck after partition move between log directories

2020-08-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-8362: Assignee: Luke Chen > LogCleaner gets stuck after partition move between log directories >

[GitHub] [kafka] showuon commented on a change in pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

2020-08-10 Thread GitBox
showuon commented on a change in pull request #9149: URL: https://github.com/apache/kafka/pull/9149#discussion_r467755721 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -430,7 +434,7 @@ private void

[GitHub] [kafka] viktorsomogyi commented on pull request #9150: KAFKA-9839; Broker should accept control requests with newer broker epoch

2020-08-10 Thread GitBox
viktorsomogyi commented on pull request #9150: URL: https://github.com/apache/kafka/pull/9150#issuecomment-671213384 @apovzner @hachikuji would you please review this backport? And while I'm at it, I can backport these onto the 2.3 and 2.4 lines as well.

[jira] [Commented] (KAFKA-10377) Delete Useless Code

2020-08-10 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174157#comment-17174157 ] Tom Bentley commented on KAFKA-10377: - This is used to generate the [protocol

[GitHub] [kafka] viktorsomogyi opened a new pull request #9150: KAFKA-9839; Broker should accept control requests with newer broker epoch

2020-08-10 Thread GitBox
viktorsomogyi opened a new pull request #9150: URL: https://github.com/apache/kafka/pull/9150 This is a backport of #8509. A broker throws IllegalStateException if the broker epoch in the LeaderAndIsr/UpdateMetadataRequest/StopReplicaRequest is larger than its current broker epoch.

[jira] [Updated] (KAFKA-9839) IllegalStateException on metadata update when broker learns about its new epoch after the controller

2020-08-10 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-9839: --- Affects Version/s: 2.2.1 Detected this issue in a customer's environment, I've

[jira] [Commented] (KAFKA-10038) ConsumerPerformance.scala supports the setting of client.id

2020-08-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174125#comment-17174125 ] Luke Chen commented on KAFKA-10038: --- This might need a KIP. Working on that. >

[GitHub] [kafka] showuon commented on pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

2020-08-10 Thread GitBox
showuon commented on pull request #9149: URL: https://github.com/apache/kafka/pull/9149#issuecomment-671191319 @kkonstantine , could you help review this PR to improve logging? Thanks. This is an automated message from the

[GitHub] [kafka] showuon commented on a change in pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

2020-08-10 Thread GitBox
showuon commented on a change in pull request #9149: URL: https://github.com/apache/kafka/pull/9149#discussion_r467713932 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -363,6 +363,7 @@ private boolean sendRecords() {

[jira] [Comment Edited] (KAFKA-10340) Source connectors should report error when trying to produce records to non-existent topics instead of hanging forever

2020-08-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174105#comment-17174105 ] Luke Chen edited comment on KAFKA-10340 at 8/10/20, 6:45 AM: - After

[GitHub] [kafka] showuon opened a new pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

2020-08-10 Thread GitBox
showuon opened a new pull request #9149: URL: https://github.com/apache/kafka/pull/9149 Improve the logging in `maybeCreateTopic` to let user know if `!topicCreation.isTopicCreationRequired(topic)`, we won't create this topic because the topic creation setting is disabled or the topic

  1   2   >